Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp893124rwd; Tue, 13 Jun 2023 01:38:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ55HqxamVsaQF767JUAlsqpFzwx1mjqXVYDujudItqcUXQUN8RJJmIjJ0OQ/9oJXJBj9X9u X-Received: by 2002:a17:907:7d89:b0:978:9223:661b with SMTP id oz9-20020a1709077d8900b009789223661bmr13348873ejc.46.1686645536849; Tue, 13 Jun 2023 01:38:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686645536; cv=none; d=google.com; s=arc-20160816; b=zg+OTU+/V0QZzbvcJ3FF3G+md70HpRl3pdPNRJ7qBKU3OSInmdkrrB62g1pFk8yQ9h T/K+EV8MqOU635fbbvxM63W0CytTMRoEh7gxJoZgqbwRKTDBd1NgRtsBaWixX1qGgjFN 9pC57hFC9K80tatJbVNaTD3e5Bb16SC5gDLfNIZk/YY1TQKu9ppV52WtXFBCbpfMFwA5 KMH3oDPEecNHGpL5wq4uN1sZ13vIBnFLbbdH5DDA7/QklDh9yn4nwpOm6NdNRD7OSlLY mXjbbnDuJDB14HiYx3MO9ktJLB+L+WTvqYqeCzU+GBvSXTbZ0Jnl9GSAX3QW+aDZvViK ybrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=SYRIoby+lA+8xPL1nYLbIKzvRrrWy4OnoUYj+gc4zR8=; b=PKLc23ulJs9EirRC+UxOv2euNciGE7yV99/QZpU3iBsYySFz8ab0ZlJ2+AzuWhKMgO xG10k/gOyI7iKYuc4rc5TAjc1VuY4JpRTTdpb+QhOpiaTjKXvHkriHkl6mPPxMHaYtiz y8h5o2bNF0opT0wrquxX3OLJUpMOWZiuEzQHVTflgcHnz4L8T2PkG9UMTjU7uitaFeee FdqgmXVGixulq8+U5byv31jwEKENO1647wyIL/81/OjA3XHAba6IzKE15wNKCbqB5S8L HInf0buDJ+lXYoIF/Mes66D7uPalSbIoBaFw+ULrU3GzKNN1zvyua8Ycty129c7WNYWe aYiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pPZhDlWc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qu10-20020a170907110a00b0096f935a9482si5843114ejb.188.2023.06.13.01.38.41; Tue, 13 Jun 2023 01:38:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pPZhDlWc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240553AbjFMIb7 (ORCPT + 61 others); Tue, 13 Jun 2023 04:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241237AbjFMIb4 (ORCPT ); Tue, 13 Jun 2023 04:31:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B231E188 for ; Tue, 13 Jun 2023 01:31:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C518163210 for ; Tue, 13 Jun 2023 08:31:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C869C433EF; Tue, 13 Jun 2023 08:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686645112; bh=810ANMJOJe05cXQJf2iu3tB0bGE5HE0U1LC3MB7XogY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=pPZhDlWculNdB7/aU4yNG9abO/dxRjdnxP2IyQoB3I+/h/1H8s0ZSA1pOFZdACwra Og7IYfK7eUTEpSyUPmyDmah87bUMaMbWhaxxd7r5TOtvFtfelyi0MbdwH9PTNweaqQ nv68Rh3fKJhyoxyH7MEFORuk+5BPMu1j2IJSeZvt7uAv3AtwzEsbda+T0gAtTVkAnv lZa4khGbvaIB3hN/CfuBNjS8GHxBSgQqN3swbjb9ub+OgMIMAdMXTGkJtdCdRrPtXC dFF2+vCPZuZgDuOZYhDoEPThjUirp/Y55YghYic/vRrhqgxVmOsMfiwcCZWauN/2kc V3jqtLmKAJbsg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 4/4] [v2] wifi: rtlwifi: simplify LED management From: Kalle Valo In-Reply-To: <20230608095051.116702-4-dmantipov@yandex.ru> References: <20230608095051.116702-4-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168664510862.24637.10587241603155144086.kvalo@kernel.org> Date: Tue, 13 Jun 2023 08:31:51 +0000 (UTC) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dmitry Antipov wrote: > Introduce 'rtl_init_sw_leds()' to replace per-chip LED > initialization code (and so drop 'struct rtl_led' as no > longer used), drop 'init_sw_leds' and 'deinit_sw_leds' > fields from 'struct rtl_hal_ops', adjust related code. > > Signed-off-by: Dmitry Antipov Is there a reason why you are changing error messages to debug messages like here: - pr_err("switch case %#x not processed\n", - pled->ledpin); + rtl_dbg(rtlpriv, COMP_ERR, DBG_LOUD, + "unknown LED pin %d\n", pin); The commit log mentions nothing about that. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230608095051.116702-4-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches