Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e030e496-b667-b1de-492b-8b0cc04ffe14@yandex.ru>
Date:   Tue, 13 Jun 2023 11:36:05 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 4/4] [v2] wifi: rtlwifi: simplify LED management
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Ping-Ke Shih <pkshih@realtek.com>, linux-wireless@vger.kernel.org
References: <20230608095051.116702-4-dmantipov@yandex.ru>
 <168664510862.24637.10587241603155144086.kvalo@kernel.org>
Content-Language: en-US
From:   Dmitry Antipov <dmantipov@yandex.ru>
In-Reply-To: <168664510862.24637.10587241603155144086.kvalo@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/13/23 11:31, Kalle Valo wrote:

> Is there a reason why you are changing error messages to debug messages like here:
> 
> -		pr_err("switch case %#x not processed\n",
> -		       pled->ledpin);
> +		rtl_dbg(rtlpriv, COMP_ERR, DBG_LOUD,
> +			"unknown LED pin %d\n", pin);

Well, this sounds to be more problem-specific rather than
generic "something unexpected in the switch statement".

> The commit log mentions nothing about that.

It seems I have to write more detailed commit message.
Should I resend?

Dmitry