Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: rtw88: add missing unwind goto for
 __rtw_download_firmware()
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20230607012741.10353-1-pkshih@realtek.com>
References: <20230607012741.10353-1-pkshih@realtek.com>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     <tony0620emma@gmail.com>, <s.hauer@pengutronix.de>,
        <dan.carpenter@linaro.org>, <lkp@intel.com>,
        <linux-wireless@vger.kernel.org>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <168664542578.24637.12994274738056453898.kvalo@kernel.org>
Date:   Tue, 13 Jun 2023 08:37:07 +0000 (UTC)
Precedence: bulk

Ping-Ke Shih <pkshih@realtek.com> wrote:

> This flaw is detected by smatch:
>   drivers/net/wireless/realtek/rtw88/mac.c:748 __rtw_download_firmware()
>   warn: missing unwind goto?
> 
> Though most things of dlfw_fail have been done by
> download_firmware_end_flow() and wlan_cpu_enable(), an exception is that
> download_firmware_end_flow() clear BIT_MCUFWDL_EN bit conditionally.
> So, make this change to clear the bit.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202306052310.OVhcUjZ3-lkp@intel.com/
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-next.git, thanks.

91ccdbb94fea wifi: rtw88: add missing unwind goto for __rtw_download_firmware()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230607012741.10353-1-pkshih@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches