Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2337285rwd; Wed, 14 Jun 2023 01:05:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4VjHHd2xPQm23pfHvUs0ZDemvqqMuias7X0/ywgeJT8YTFPdAo0Z5rTMsL7Cdg0UMVgrAF X-Received: by 2002:a17:903:2289:b0:1a9:40d5:b0ae with SMTP id b9-20020a170903228900b001a940d5b0aemr13088800plh.12.1686729940091; Wed, 14 Jun 2023 01:05:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686729940; cv=none; d=google.com; s=arc-20160816; b=C3FbRI7hHakfcbE4oCLCMYATZB9UmMUIgPbEe1d1IPNCEM2k/05OMetbu1mLNwYCGy p4nAM2rzMcdSm6HTYmdfjGFqC7/UAoqzzn/zSV/2JI+PYbK/Tu96vdVTOJQfxkPGKYSu RyP6rV2EhG41rEKOh87j5ZGEJfWjhLEL6XTaTzlK9K8NC2EILi+xiPCr4lQulKwLtetm g3y6cbE6YqEC9iOr9rMj4N/jg4waHhPVZqdhW/IGVR3drZI6Rp5LBHKadaQLOsDUXs9c lCQecyuAiBTQT41C3Km8Kjt2B7/A85T/SCZiPa1MJ2/x0lIMjr+ovQkXfHh3HtVRYJiH a69w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=dVSXEn0iiAGSkxkpTSrJSP4GcGEkjq1CULMPAClVb+k=; b=hUubn0rcLXPHs90KO7pRtM78rAax1EW/KQt9U7yGW36I1dVPjJUsFSYVeGTIU+6DMl ziRHIViqKIzq66yxe6BE3Roxfy9YjPuNE/c/sGHUKEkaSlXuee2fbJU0gGhkdvGrSXOg iT64LrEt3dhpISQ1kwQPAtKjoAJUKcMoC44fao4Scf/ovKvP8mA00kjGmuWjSDEvjCQ+ kLhwWMYD3KQffkeDc9wfXCq97B981q1uJLWCUGl0lYj+5QXG8t3v4FLV21iClhR5MMM9 COmE5fSR6MFzP92TrJXkHIif3AduS/YpePV+1iocmlExCXvPJpIAHScPNmezIDm8p/aI QBvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=hIrxg+jl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l12-20020a170903120c00b001b04741042csi7649958plh.93.2023.06.14.01.05.31; Wed, 14 Jun 2023 01:05:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=hIrxg+jl; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238164AbjFNIDR (ORCPT + 62 others); Wed, 14 Jun 2023 04:03:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243018AbjFNIC4 (ORCPT ); Wed, 14 Jun 2023 04:02:56 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9709426B0; Wed, 14 Jun 2023 01:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=dVSXEn0iiAGSkxkpTSrJSP4GcGEkjq1CULMPAClVb+k=; t=1686729742; x=1687939342; b=hIrxg+jlyKYbkzXDBkSYr81cpv3/Zri/jGdpVwA3+zUdytb wor943IT1iiwrbm3MplqSy/hEdshWXnZbrOp83MBqGaj+xMfd4Kv667pJiTaTcaxNxuDfFwK0hhup JTK47WL6k9BQ2H07mDSmL3w8YA7pH3s8UMa56/V7ey/itDqQh2Xx/kdguTRjIjUN9mmeAQXxYeFye 4ioWu5Op1oIo5jI/i8pSsXmBC86SNHYuxZYCO3caVp6tpgf8ucrTlvfm/owhbpL/GyyisfB5e/taS y6+ETyzqmtKgAENmT2L969+WMho3qnfWVeC60ofWKPXrgdnnvYZbouBWwVCwCXDw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1q9LSE-005zlN-31; Wed, 14 Jun 2023 10:02:11 +0200 Message-ID: <12c1079d6e73f8f62c33b8a53dff7ff4de0728dc.camel@sipsolutions.net> Subject: Re: [PATCH] b43legacy: Remove unneeded variable From: Johannes Berg To: wuyonggang001@208suo.com, Larry.Finger@lwfinger.net, kvalo@kernel.org Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 14 Jun 2023 10:02:10 +0200 In-Reply-To: <194e8e87fda5f02664fcfac3717458f2@208suo.com> References: <20230614075250.29097-1-zhanglibing@cdjrlc.com> <194e8e87fda5f02664fcfac3717458f2@208suo.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2023-06-14 at 15:55 +0800, wuyonggang001@208suo.com wrote: > Fix the following coccicheck warning: >=20 > drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded=20 > variable: "count". Hey, no. Please stop it already. This won't even _compile_. Just don't. There's really not much value in cleaning up those coccicheck warnings in the first place. You're just wasting everyone's time (including your own). johannes