Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <058dd31ef48495f8641f5b66839aaea039af0f08.camel@sipsolutions.net>
Subject: Re: [PATCH] b43legacy: Remove unneeded variable
From:   Johannes Berg <johannes@sipsolutions.net>
To:     wuyonggang001@208suo.com, Larry.Finger@lwfinger.net,
        kvalo@kernel.org
Cc:     linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 14 Jun 2023 10:16:57 +0200
In-Reply-To: <12c1079d6e73f8f62c33b8a53dff7ff4de0728dc.camel@sipsolutions.net>
References: <20230614075250.29097-1-zhanglibing@cdjrlc.com>
         <194e8e87fda5f02664fcfac3717458f2@208suo.com>
         <12c1079d6e73f8f62c33b8a53dff7ff4de0728dc.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-06-14 at 10:02 +0200, Johannes Berg wrote:
> On Wed, 2023-06-14 at 15:55 +0800, wuyonggang001@208suo.com wrote:
> > Fix the following coccicheck warning:
> >=20
> > drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded=20
> > variable: "count".
>=20
> Hey, no. Please stop it already. This won't even _compile_. Just don't.
> There's really not much value in cleaning up those coccicheck warnings
> in the first place. You're just wasting everyone's time (including your
> own).

And BTW, I've just looked at all your other contributions to other areas
of the kernel, and heard from others as well - not doing any better!

I can only suggest that you stop all of your patch submissions and re-
evaluate what you're even trying to do. And not just you personally, but
all of the @208suo.com folks who popped up recently.

johannes