Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2441140rwd; Wed, 14 Jun 2023 02:55:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4zWOqTMHCCrl9wjetQlvYxY5cD5eKyFm7llPV/TTfg/0J2e4x86pnQr7IO8pMUe3XvSzxz X-Received: by 2002:a05:6a00:b96:b0:658:26a8:9d9e with SMTP id g22-20020a056a000b9600b0065826a89d9emr1964022pfj.29.1686736557863; Wed, 14 Jun 2023 02:55:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686736557; cv=none; d=google.com; s=arc-20160816; b=h4bD+bdIYBva/X56MAe0DR2fKnGoihEW9kgnfA0T4a33a34ZMpJLc7y+Q+HwDxhKjA dTBdiRH/nZOJiqbu2ZM9eA9R3brKqPnncmgi+HNLabkgsGlmRkPCza1csygqZv/Z8/SZ cCeBIiz5Cpd6DWRQ2TcMjnMZVG1tFDcuhT1imq4n0qqNm9aNooP81ZouymNQ2vfmXu7W TJW7W950aQrkfq9RBLMqAmqUSthAc+iB3Gq624QfYNke7BnrI1+DIUXukhgGp4cWym1c sG9/u5+rDeM3xkFiaLr3IlnFc11P6GV5KktHJoEvARTCaJl/c1b4lzUZB4JTO4whpZMY 6ThA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EfgXlS6vwTpfuUxeI2FEZwT9oPXc6Pxv5tri2UU1wYc=; b=PCB3/d0Nvd1NlHFTQIo0D5n2i5T6dg16uG2fWEsVF3bil3Lv14dXEnk0NjUzEXz6cQ IiH30mPWOHHFcw6EVbW76Amj71+1Z7028QlOlc9lbDlB4WSZuWySxbkprqq5tytfBWxb AoR5CT9PibMF+KmtjFUXaRfuKt5b2E+EA7McQt1zOi/+OvVDkBEQtboNqW5bkK0oNdF6 jTmiJ9pekP6ps1N7r7/w0ENbS7XnUKxV5wZSUhhaLUVSXnfV/K0YTX99t13u+gp4LdJ1 ug19lKSvNaUB6PTSaxZ7Sf34NbfhfvNMY+afZdnnpMlyErUyFN4d59GKzs8G/GEVqUqw sHHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="TGk4a/1+"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u123-20020a637981000000b00524eef20da6si10738742pgc.642.2023.06.14.02.55.50; Wed, 14 Jun 2023 02:55:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="TGk4a/1+"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243758AbjFNJpq (ORCPT + 61 others); Wed, 14 Jun 2023 05:45:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244316AbjFNJou (ORCPT ); Wed, 14 Jun 2023 05:44:50 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C345E271B for ; Wed, 14 Jun 2023 02:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686735834; x=1718271834; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2uBa9Pp/VnXmxZ+CjSZQlPD0j/bGGqxqxKbZPWcgTWU=; b=TGk4a/1+uaN4Nfp0/S1L4STEeD5732MeDXIk3MmlxLmu62EVTViS2wEa n3o1DelRMIXBV7xJYVPLJwOwACXr4nBb55lfkXgkeyyJAXNFGCHjdDdOX sti8Au2iQGHjmAuSzTZmOeOsGK8T/suxIPm5H+n5+jJMH1OZ5KHSHszbd Ci4O5M2CtTlZcbTp9HD69yTiyWgmVATH0DA17Yz1lgwDrtVL6afyCN4y9 SJsyNv2ATn2+Ci8oUKIv/LX0hdEhi4uxqswf7PAmyGtBGmLMVVVEUImvY UoRqOu6/4c6BTJ7qvqcWbuZxxqCyQBpPrWRvEiNhnJVgRNcI39LrG3Org Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="361049874" X-IronPort-AV: E=Sophos;i="6.00,242,1681196400"; d="scan'208";a="361049874" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2023 02:42:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="711989883" X-IronPort-AV: E=Sophos;i="6.00,242,1681196400"; d="scan'208";a="711989883" Received: from basharil-mobl.ger.corp.intel.com (HELO ggreenma-mobl2.lan) ([10.214.203.45]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2023 02:42:22 -0700 From: gregory.greenman@intel.com To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Johannes Berg , Gregory Greenman Subject: [PATCH 13/20] wifi: iwlwifi: mvm: always send spec link ID in link commands Date: Wed, 14 Jun 2023 12:41:30 +0300 Message-Id: <20230614123446.daecd0e626f7.I0f8a16a6d80a283c9f947c9bb0fc50a7c6853948@changeid> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230614094137.379897-1-gregory.greenman@intel.com> References: <20230614094137.379897-1-gregory.greenman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg The firmware technically only needs this when the link is newly added, but it's much easier for debugging if it's always available, so include it. Signed-off-by: Johannes Berg Signed-off-by: Gregory Greenman --- drivers/net/wireless/intel/iwlwifi/mvm/link.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/link.c b/drivers/net/wireless/intel/iwlwifi/mvm/link.c index af9ace787ec5..563396dfd3cd 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/link.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/link.c @@ -245,6 +245,7 @@ int iwl_mvm_link_changed(struct iwl_mvm *mvm, struct ieee80211_vif *vif, cmd.modify_mask = cpu_to_le32(changes); cmd.flags = cpu_to_le32(flags); cmd.flags_mask = cpu_to_le32(flags_mask); + cmd.spec_link_id = link_conf->link_id; ret = iwl_mvm_link_cmd_send(mvm, &cmd, FW_CTXT_ACTION_MODIFY); if (!ret && (changes & LINK_CONTEXT_MODIFY_ACTIVE)) @@ -271,6 +272,7 @@ int iwl_mvm_remove_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif, cmd.link_id = cpu_to_le32(link_info->fw_link_id); iwl_mvm_release_fw_link_id(mvm, link_info->fw_link_id); link_info->fw_link_id = IWL_MVM_FW_LINK_ID_INVALID; + cmd.spec_link_id = link_conf->link_id; ret = iwl_mvm_link_cmd_send(mvm, &cmd, FW_CTXT_ACTION_REMOVE); -- 2.38.1