Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <31903d55380fae200aad3626308e5b48f05dc14b.camel@sipsolutions.net>
Subject: Re: [PATCH 02/15] wifi: iwlwifi: mvm: debugfs: add entry for
 setting maximum TXOP time
From:   Johannes Berg <johannes@sipsolutions.net>
To:     gregory.greenman@intel.com
Cc:     linux-wireless@vger.kernel.org,
        Avraham Stern <avraham.stern@intel.com>
Date:   Wed, 14 Jun 2023 12:03:50 +0200
In-Reply-To: <20230612184434.4ab332037a25.I57c33574a61edd68bd0ec1aa7009f31111fd7efe@changeid>
References: <20230612155116.168000-1-gregory.greenman@intel.com>
         <20230612184434.4ab332037a25.I57c33574a61edd68bd0ec1aa7009f31111fd7efe@changeid>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-06-12 at 18:51 +0300, gregory.greenman@intel.com wrote:
> From: Avraham Stern <avraham.stern@intel.com>
>=20
> Add an entry for setting the maximum TXOP time in microseconds.
> The configured value can be read from the same entry.
>=20
> Signed-off-by: Avraham Stern <avraham.stern@intel.com>
> Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
> ---
>  .../wireless/intel/iwlwifi/mvm/debugfs-vif.c  | 38 +++++++++++++++++++
>  drivers/net/wireless/intel/iwlwifi/mvm/mvm.h  |  3 ++
>  .../net/wireless/intel/iwlwifi/mvm/rs-fw.c    |  3 ++
>  3 files changed, 44 insertions(+)
>=20
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c b/drive=
rs/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c
> index 3613b1fdc5d9..762bce70e262 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c
> @@ -679,6 +679,42 @@ static ssize_t iwl_dbgfs_quota_min_read(struct file =
*file,
>  	return simple_read_from_buffer(user_buf, count, ppos, buf, len);
>  }
> =20
> +static ssize_t iwl_dbgfs_max_tx_op_write(struct ieee80211_vif *vif, char=
 *buf,
> +					 size_t count, loff_t *ppos)
> +{
> +	struct iwl_mvm_vif *mvmvif =3D iwl_mvm_vif_from_mac80211(vif);
> +	struct iwl_mvm *mvm =3D mvmvif->mvm;
> +	u16 value;
> +	int ret;
> +
> +	ret =3D kstrtou16(buf, 0, &value);
> +	if (ret)
> +		return ret;
> +
> +	mutex_lock(&mvm->mutex);
> +	mvmvif->max_tx_op =3D value;
> +	mutex_unlock(&mvm->mutex);

This is a strange debugfs file, it only takes effect the next time
iwl_mvm_rs_fw_rate_init() is called, which can be kind of random? Seems
like it should force a reinit?

johannes