Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
To:     Johannes Berg <johannes@sipsolutions.net>,
        Ilan Peer <ilan.peer@intel.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] wifi: mac80211: Remove "Missing iftype sband data/EHT cap" spam
Date:   Wed, 14 Jun 2023 15:26:48 +0200
Message-Id: <20230614132648.28995-1-nicolas.cavallari@green-communications.fr>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
UI-OutboundReport: notjunk:1;M01:P0:3IuVxyuHRuI=;tkE++l+Jmdeqi4kp51P6qk9MIRK
 WzSJcETRA8pw79iwFGrvBdV1LlyK/i17+3e2ryao3Kwv4akqfc+Q4/AELW7E0C8Do/CyG3TTX
 C+rY3ztWJrEhpg5iS1cf3z5/JP4r2foy9qAzypp6w5p+tnY/XSzuDKZa4FxM5jIbF3fA5WV+E
 smpUfP5EYd7r4pKs0800NaQobSDWjzs6L0KNJF/RkOAo4MaiDHFKDQA9u7/heBY9Cx8MFjRq1
 EqnC+wOSjeEbsA51bw9/DsN8klHJab7xPOmR0rZA0rf0y+dvrKQkYWDXLwtB2LU9RnkbWkLT7
 Vz7g5DpWOXA9jM14F8PGsIJY4/5Y48iDqZWo4B6baLXNAQVUkjz0qudOOSsy/g4ZUY7GJw+kD
 +a68zkLk04MtMNuQCXtR5KYdC+A+UfEyQhmwKIq2nxsv7yTNiRJxhplZ3Ppsq2VbW2Js6yZoS
 uzCbBqaSvApwmLMag0mpusr4KodSHutAc+XcUhKRXwV0MclEAxv6dVWMpDbAx4mf/8PntwNhb
 KKfUw1q/XnKz3dAZ9pezO5ZnNbcvQtf2fKJpHuKnJJYhijUm7wx4DCvv91Zo16gYq/FbSrFa3
 AdRT9aygAr36WMNbmHBklq+otL1wXDrbxvmgjyPbPwz+FUMQfL92PtkBAtVcpo1bG9jbip9dy
 sFTkOgmMqTbsV8GHRvWJYVhd+M+sUtJUoXKHdOJ6Vg==
Precedence: bulk

In mesh mode, ieee80211_chandef_he_6ghz_oper() is called by
mesh_matches_local() for every received mesh beacon.

On a 6 GHz mesh of a HE-only phy, this spams that the hardware does not
have EHT capabilities, even if the received mesh beacon does not have an
EHT element.

Unlike HE, not supporting EHT in the 6 GHz band is not an error so do
not print anything in this case.

Fixes: 5dca295dd767 ("mac80211: Add initial support for EHT and 320 MHz channels")

Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
---
 net/mac80211/util.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index 3bd07a0a782f..325a1e107240 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -3801,10 +3801,8 @@ bool ieee80211_chandef_he_6ghz_oper(struct ieee80211_sub_if_data *sdata,
 	}
 
 	eht_cap = ieee80211_get_eht_iftype_cap(sband, iftype);
-	if (!eht_cap) {
-		sdata_info(sdata, "Missing iftype sband data/EHT cap");
+	if (!eht_cap)
 		eht_oper = NULL;
-	}
 
 	he_6ghz_oper = ieee80211_he_6ghz_oper(he_oper);
 
-- 
2.40.1