Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Azeem Shaikh <azeemshaikh38@gmail.com>
Cc:     linux-hardening@vger.kernel.org, linux-wireless@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH v3] wifi: cfg80211: replace strlcpy() with strscpy()
References: <20230614134956.2109252-1-azeemshaikh38@gmail.com>
        <874jnaf7fv.fsf@kernel.org>
        <CADmuW3WEUgnpGXg=ajpRvwON6mFLQD9cPKnhsg35CcNqwcywxA@mail.gmail.com>
Date:   Wed, 14 Jun 2023 18:15:31 +0300
In-Reply-To: <CADmuW3WEUgnpGXg=ajpRvwON6mFLQD9cPKnhsg35CcNqwcywxA@mail.gmail.com>
        (Azeem Shaikh's message of "Wed, 14 Jun 2023 10:55:13 -0400")
Message-ID: <875y7qcbxo.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Azeem Shaikh <azeemshaikh38@gmail.com> writes:

> On Wed, Jun 14, 2023 at 10:24=E2=80=AFAM Kalle Valo <kvalo@kernel.org> wr=
ote:
>
>>
>> Azeem Shaikh <azeemshaikh38@gmail.com> writes:
>>
>> > strlcpy() reads the entire source buffer first.
>> > This read may exceed the destination size limit.
>> > This is both inefficient and can lead to linear read
>> > overflows if a source string is not NUL-terminated [1].
>> > In an effort to remove strlcpy() completely [2], replace
>> > strlcpy() here with strscpy().
>> >
>> > Direct replacement is safe here since WIPHY_ASSIGN is only used by
>> > TRACE macros and the return values are ignored.
>> >
>> > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#str=
lcpy
>> > [2] https://github.com/KSPP/linux/issues/89
>> >
>> > Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
>> > ---
>> > v1: https://lore.kernel.org/all/20230612232301.2572316-1-azeemshaikh38=
@gmail.com/
>> > v2: https://lore.kernel.org/all/20230614134552.2108471-1-azeemshaikh38=
@gmail.com/
>>
>> In the change log (after the "---" line) you should also describe what
>> changes you made, more info in the wiki below. In this case it's clear
>> as the patch is simple but please keep this in mind for future patches.
>>
>> No need to resend because of this.
>>
>
> Thanks Kalle. I did have the below line in my changelog. For future
> patches, do you mean that changelog descriptions need to be more
> specific than this? For example - updated title from "x" -> "y"?
>
>> Changes from v1 and v2 - updated patch title.

Ah, I missed that because the format was not what we usually use. I
recommend something like this:

v3:

* add bar

v2:

* https://
* fix foo

v1:

* https://

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes