Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6f8db032286923845202c7d658f1d39db79a758c.camel@sipsolutions.net>
Subject: Re: [PATCH 10/27] wifi: mac80211: isolate driver from inactive links
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Wen Gong <quic_wgong@quicinc.com>, linux-wireless@vger.kernel.org
Cc:     ath11k@lists.infradead.org
Date:   Wed, 14 Jun 2023 20:32:48 +0200
In-Reply-To: <1c26c205-0240-7670-117d-02a7af068724@quicinc.com>
References: <20220902141259.377789-1-johannes@sipsolutions.net>
         <20220902161143.5ce3dad3be7c.I92e9f7a6c120cd4a3631baf486ad8b6aafcd796f@changeid>
         <5d82e564-86bf-c26b-077a-d0bc14e2d3c3@quicinc.com>
         <74f3eb848326607b15336c31a02bdd861ccafb47.camel@sipsolutions.net>
         <d10b88b4-0bd7-a38c-e8d7-8982a281c4b3@quicinc.com>
         <e5adbed1524b27228c152ba14f78c550c8730baa.camel@sipsolutions.net>
         <c15e368e-2fea-a1d8-9c0d-db9278ded5e5@quicinc.com>
         <113761966918b2f390d3c9304307b42a0b4a829b.camel@sipsolutions.net>
         <76863dec-1b2f-b933-7c5e-21c732de4bc6@quicinc.com>
         <2cc79101249548f2a92c14af6aff6121143907d6.camel@sipsolutions.net>
         <1c26c205-0240-7670-117d-02a7af068724@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-05-24 at 15:41 +0800, Wen Gong wrote:
>=20
> May I add a new ops in struct ieee80211_ops? like this:
>=20
> u16 active_links(struct ieee80211_hw *hw, struct ieee80211_vif vif, u16=
=20
> new_links)"
>=20
> then ieee80211_set_vif_links_bitmaps() call the ops to get the links for=
=20
> station and set the sdata->vif.active_links with the return value from=
=20
> lower driver,
> it means lower driver will dynamic select the links count at this moment.
>=20
> If lower driver not register ops active_links, then keep current logic.
>=20

I guess you can can send patches for whatever you want :)

But I have no idea what you're trying to do? Why would you need to have
a callback?

Was this for link selection in the driver? We should have a patch
somewhere that adds a BSS_CHANGE flag for when the valid links change,
so the driver can select others.

johannes