Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp715045rwd; Thu, 15 Jun 2023 00:38:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5663F6zSQF8lMTbvfRCk9DFFmeu4X0PEGz4fTJX7rlWeumdIQ8zl7adWfOkpYMQ3F0NwvR X-Received: by 2002:aca:2110:0:b0:398:4d53:48e5 with SMTP id 16-20020aca2110000000b003984d5348e5mr10371516oiz.47.1686814738753; Thu, 15 Jun 2023 00:38:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686814738; cv=none; d=google.com; s=arc-20160816; b=S+V8FSyw4KPIm9yl6DUcIxXDOGvnLkISUjLnXbyF60lE18B+QgB5LxY/D8Ci79tX8a ZMGrZGAyhBOy4Xum2DqJyzlwzqYrEUNWyz3op5PDMkf7tsvUYUTga5AqOc48kF25DMLa yPRzT9sTEFiUnr+Dfs5zJPlzETSkGPQqaeZaXR5teHRvOKkmX2mjkxaGkvin2xKxZuEc Yzow7uTKXGWHJeZDpWrEXZNsOW4a6Kvzck5aLPWvuz1RbTBmtmzXKHrZyIE3rKrqdMbd 9mYtZreZ4XUsHTC8AeAJKaAn6/znH/e/jIkjG8PfOmAxE/WwcR9RU14FXckuXvy7KgM+ v9+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=YuLKRa+mgAV6OrGcWswVfnUSqUebM2SagqXD4IH6hbM=; b=BkFBz2T2NbMjE+7jW58okO6+Jj9F78YR3a9+2mboEvogO56QBqBYjxcjpd7TsWuHkp nUhH0hArTHosGJjKyrF+HE7seZDbQc8xIcWrjUwhbWo06IUdWm7VFQgquGiCcockpMs8 QRRh6irROFzfxpJheVoMJQjas7U97RkXFTtAQNxkAaRUQ9cEgSVH97Kz2ZeQLiGoQCR7 tSam5J3ODrHOtGFcVhJLOHQjLpN7399BDCsGFZkBNE8PPwgnEyiQVf1pPNKWbosntM2f I8/7w5j44DXLcv65X4fNASnZTMQ38/xIjCBRNpR6I7tg+cVr6I6jqOt/93xoBfI1M64F fdzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BnpG3PLR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i194-20020a639dcb000000b0051b90567f99si2148346pgd.690.2023.06.15.00.38.50; Thu, 15 Jun 2023 00:38:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BnpG3PLR; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245010AbjFOHdp (ORCPT + 61 others); Thu, 15 Jun 2023 03:33:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244856AbjFOHdT (ORCPT ); Thu, 15 Jun 2023 03:33:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8CE81BD4 for ; Thu, 15 Jun 2023 00:33:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3BF1563274 for ; Thu, 15 Jun 2023 07:33:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58719C433C0; Thu, 15 Jun 2023 07:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686814379; bh=+54sRTulTDcQyrmLFvPzrEc5jKHyclMpBX1rU9atwg4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=BnpG3PLRW5SNuX8lAhh+1OUFs53WuXGEUDzfNOqFEucl4BQWETByWPyVimz8Dgi9w awG0sOVyeCnWfi0OQIaNWjXHd8gsT/peNj0H1oWyTPR3QHchGE9HST8l7BT882TqMn UGLdHhjrZdv8GlXR1GXaY2b1vm2tHpvECajfS9dohxXj0wzhSNZAwoQOE6ZMXf4zCP FPCAQL8reL0cKD+xKILo9dfVcR0yxL/QbjKevQ2EL9naam4RhRSUWQNRnCJUQ+9Cnj aFbVtHfn0E4KpHXe7jXq1xKO6RNwtfNjq4+PnNVO2ZAvXlHQeP5AVspT36qMw7nknO bGmoH3uRaKlkw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/3] wifi: brcmfmac: handle possible WOWL configuration error From: Kalle Valo In-Reply-To: <20230607161611.85106-1-dmantipov@yandex.ru> References: <20230607161611.85106-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Franky Lin , brcm80211-dev-list.pdl@broadcom.com, linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168681437386.8111.5132863492672751351.kvalo@kernel.org> Date: Thu, 15 Jun 2023 07:32:58 +0000 (UTC) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dmitry Antipov wrote: > Convert 'brcmf_configure_wowl()' to return 's32' which may be > an error raised by 'brcmf_fil_iovar_data_set()', pass the > value to 'brcmf_cfg80211_suspend()' and adjust related code. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Antipov Using s32 for an error value is strange for me, usually we use int. This patchset feels like random cleanup which makes me wary. How are these 3 patches tested? -- https://patchwork.kernel.org/project/linux-wireless/patch/20230607161611.85106-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches