Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp957245rwd; Thu, 15 Jun 2023 04:38:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5xR6B6pn/bxH1YlGyVfVn8dcGehNs4kjhD/A/2Z11l8Kno3umaJJwCS2WWCCwSWo8nmHQP X-Received: by 2002:a17:907:7b91:b0:977:d48f:97ad with SMTP id ne17-20020a1709077b9100b00977d48f97admr20259310ejc.75.1686829086583; Thu, 15 Jun 2023 04:38:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686829086; cv=none; d=google.com; s=arc-20160816; b=I4pck5LWPeFMy4nqoTHwOV6wrxbbuiRiSBHBHGK9WaYmtOpg3OuDNlxW2/Bntv63NI yox3vIJcItQ0I85hLZ0uGOnTUVWV1dokjpmSoSGR7qu9N1DObYLkfu5AjL5lHiLisT6h CDY5bh93QJ/oxZ0ElNhNoekLWrFdhpYjInTYlU9sMjvpBDlNoTWdgUVo3CoMclf3w5FE xgy1R8KxyYepi0hVD3MvH30gF10Ekrytcct1DpoyAQF7Iyrn4l30Ijx6jZlMb7Bi9VgX CLj/OFoSuaQs7s0qp3te/K0k9kggRTId6ED1/JkvunSRq3G7xwm07wOjpWVkuRAr3hlT 9G5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=w9UHKTahrSARO5s4o60uFfHDKgLe7UNkLyc9fYWJD0Y=; b=tx7p0vs8fkd+4goaYHnOrezQvVAA8mhkpRI4Ab4qG9eDU9hL0DSPgbXFR6qWV5dpMR bf1uANnkBvKjBZBMwMUYhKyVSB0zHu+O80O+y9QsoAMt12pwijIoUU6LNdl5mw8/26IT pJaaUARSMU41VZuuMp7Z4DTl1sGZji9XN8KTHxejFmsZYrhQrGOgZ7vtmqeAdcaMTqD1 foQ8e5jC5/qc6+FHC52YV1DJfunY6apsUyuwQPC8puKpm0uzIIANMP+3cb+rcJybjnm6 wJmy5vJmW5H3PK1/U6t3lo63c1Y+PZDd2IhfzRUk1CuWvXPIbGWk1vsdspPCLSomW6iz 8eNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TtpHxPUX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g7-20020a170906868700b00977e4a1fe32si9748025ejx.539.2023.06.15.04.37.50; Thu, 15 Jun 2023 04:38:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TtpHxPUX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240382AbjFOLfy (ORCPT + 62 others); Thu, 15 Jun 2023 07:35:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231357AbjFOLfx (ORCPT ); Thu, 15 Jun 2023 07:35:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92598ED for ; Thu, 15 Jun 2023 04:35:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 230AC62833 for ; Thu, 15 Jun 2023 11:35:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9735AC433C0; Thu, 15 Jun 2023 11:35:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686828951; bh=HRKs8EDAMspjkc4t+uSo5TJHix7Rge5uKAkGMWz4HuM=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=TtpHxPUX/FT1K6E8TAqgXlrquSrQWTe7UjZkbStkfBNjBK54jy9Dq91tOMX0ZurWq zg8Q9iQ6WjoxQnftPEJx0gtUeeKKN004PJrdO2V3v6F2PRXBHa7CCO5yd4A/SvL1LH 35Aj9aLy1R3cdBCRfF6oggdybHQ3YfPDGiGToRqd9wqTH3fWQoRoaxiWefcn3SilHF 15FbPFChl4BFFqQr9L55+NRQlQ3SgQNr8AQOQGWdFp1rfGry75lX1uJji5IEYvzc87 2bKdJ8VxRByT2BA6aJH0x9kgeV3mUwioUDowi1NvfZbLMdmxlYmBEbcCKvC4rV3KYR cyZCV6YZcY1sA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath12k: fix conf_mutex in ath12k_mac_op_unassign_vif_chanctx() From: Kalle Valo In-Reply-To: <20230608104444.3134-1-quic_wgong@quicinc.com> References: <20230608104444.3134-1-quic_wgong@quicinc.com> To: Wen Gong Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <168682894712.15751.14642356726851590142.kvalo@kernel.org> Date: Thu, 15 Jun 2023 11:35:50 +0000 (UTC) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong wrote: > "mutex_unlock(&ar->conf_mutex);" is always called at end of function > ath12k_mac_op_unassign_vif_chanctx(), so delete this unlock to make > sure lock/unlock is paired. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 3a5d50f8eb4f wifi: ath12k: fix conf_mutex in ath12k_mac_op_unassign_vif_chanctx() -- https://patchwork.kernel.org/project/linux-wireless/patch/20230608104444.3134-1-quic_wgong@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches