Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1006303rwd; Thu, 15 Jun 2023 05:17:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5lm9s999GpYH0Yp1AcLERJZkxQ1daPKjzFV1OecBMy0YCHmJZ5WwO5app6ON6ecsteA6Ou X-Received: by 2002:a9d:7e8d:0:b0:6b0:df47:170a with SMTP id m13-20020a9d7e8d000000b006b0df47170amr14329158otp.6.1686831432480; Thu, 15 Jun 2023 05:17:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686831432; cv=none; d=google.com; s=arc-20160816; b=KjBUyHOyMBZ8CMAbV7/qLB80gizvs4W5/6CrEuLGfVKYnqG6SyZIQ+2GgWUsD6brRX YlTK6aSYYa9pakSKWXASTnSN6+mhE+jJdR4eBlnGZkR7nhtuUthT91ly/wQZss5LvIsI srx8dLu+bHbWSltoFJd094eSe/FraZX5Wah/9UMiQceFmW5cs1aNHLIjn2BRfQ7AxA5k GjIKq2BmYskEMN6Z+J8BqNy2OyaISGPxrEOl6BGWzLxaaU18dzhJ35YgUwcNT0DiBU9q vBFVBZPPr8Rya5RhZ+ajqIgN30o9YWoabP/fWBGYVcktShYgjiHHPSD2Kai2VVKllJ3F hVqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=nfNH8m351l5ZhSIa0CbHJa2PB9w2SHoU4VndzEx3NuI=; b=OofLPGf7f0G0QsZtazmDeil92HuIzP5gnFP2KeXLlnKBPkZGFlXNjXub1JDzV/NSYz OP+MHF21fvV7Xapwytz/N7tjbbuIX0KEE0VZ+LlB/fKDxKju/8eVMd2bu/I7qWPiQsnt AvqOuk+m7S4CyEkzdveNA6iAF4TcDZt2Ex2yf0MmR3wnSTPZY76N7bqmD/ujP6Zp7Ydt Z1lIZcyVJFHptJr/guO4EHs/7wGXRovIjWoMia9KHe3NefNzDyDTT6/srIB60/Hc+9bF xZ9llEMjI947VjcMbYDparundVxmgdtuHSj6w0D8A9Fy0d2NOr/X7E6Al/rX3jlLDv0Q eqFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HhzbrC48; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 4-20020a630704000000b0054fe20987d7si644306pgh.220.2023.06.15.05.17.04; Thu, 15 Jun 2023 05:17:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HhzbrC48; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238766AbjFOL76 (ORCPT + 61 others); Thu, 15 Jun 2023 07:59:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238762AbjFOL7j (ORCPT ); Thu, 15 Jun 2023 07:59:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36FE93C00 for ; Thu, 15 Jun 2023 04:54:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AB293611AF for ; Thu, 15 Jun 2023 11:54:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 525E7C433C0; Thu, 15 Jun 2023 11:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686830077; bh=6CoRaWMid+fQTV2bHeZBEjDGeum3/Gt6XAbRRbm/J4E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HhzbrC486BKWz6RYvwnlLwmCVZyHQV7rzfIHQcNtb7dIFz4P2XAfLR6NYatxDSsbx NevboWz9ELM5tjUOY33CX7KaFkIVGpYenQoK3X5YVz6oeKK+Fz7c5JGSrSYm6usm0D EDakWDLV5TGgQOAijHU6y3Q83Kpj9l60/YyGevKNrnLCH/qvTiq3LojjrIAmDg5tnF y5s7NGowIfo7OxZ7oMg4sEVBiCCgD1jJ6oWY8zoGUTeFDv8iwcipPMbTiDotR0vDEm WSq96piZ1z4o2Sx27f1PC0K4gkzNtqLlL+aVJSS7AroB97oVHVWA8uV6ma60OQBM+S f/Fbv9XMttwFA== From: Kalle Valo To: Dmitry Antipov Cc: Yan-Hsuan Chuang , linux-wireless@vger.kernel.org Subject: Re: [PATCH] wifi: rtw89: delete timer and free skb queue when unloading References: <20230615110519.61687-1-dmantipov@yandex.ru> Date: Thu, 15 Jun 2023 14:54:34 +0300 In-Reply-To: <20230615110519.61687-1-dmantipov@yandex.ru> (Dmitry Antipov's message of "Thu, 15 Jun 2023 14:05:19 +0300") Message-ID: <87leglaqkl.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dmitry Antipov writes: > Delete TX purge timer and free C2H queue in 'rtw_core_deinit()'. The commit log should always answer to the question "Why?". Please explain in the commit log why this is needed. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches