Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1037226rwd; Thu, 15 Jun 2023 05:41:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ74qpaIdIOzQmu+lhl9AdmxPM8WugWC9tDEyx77N8tFoUi0XvWwrXF0xSLdgcBmtPmN7jTS X-Received: by 2002:a05:6808:23cf:b0:39c:798e:6d14 with SMTP id bq15-20020a05680823cf00b0039c798e6d14mr15992435oib.10.1686832882995; Thu, 15 Jun 2023 05:41:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686832882; cv=none; d=google.com; s=arc-20160816; b=eGk0vWYT977csTzjIcH/aSCOfSXFnXV9rvInxdHuXVPqdefd9NbgRQSGEz+zzXbAQn MHNzDSC3iO7ftXrbt5iNh02qnMB42KCf6v1lO13zCBvaB5CVEzm1R8BB7j5v3y/Y7mkm gvH7kCejVsulT4Et8VdXa1LoJTO25FXBLkcduo3sxfcuKha1pzJONypdOZ9xdndCM4dQ 8KPiL/xbaDeeLVCfUZwbVWSbaWgQ9+ubhKQKb+9J/i3R7SXRZGzf8EdWrTG4MNSG5W3H xUvUMDvuiTKgGksKjUlj4DvwT6vvJ3EYODtQDllGg+x9D4CsfephHdUR1OK9YZSHAOSU GAow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :from; bh=p2JLR7eyq01/9LwarS3LHAUpoOAFYw45kGwkior1nBQ=; b=QAPrKU91BYuBpAgwjci8bYfDbiHivN5sV3yzqnaa7OTQwLifA8DrNZb3L8U5xpmZvL oqPBwoPySxghjlGQ2kJnCQx1cWEc3HeYniBQfdOXFOjBXGxeI0GgPwjwG0+8t9c8rATM TlrZmgfHUoqVL59jOZC47gBWsgNYYnoPBd2bd8fgojsT25ML5pZBOj5N+8htPHZkSt6G pFmIvcBaqsLNkPaS+ekG8Q4PwZ13plygMt9bYOXSSrlNQdSfI7FF4cWfywv1Bhak7klz AvLwh+qef9pLNpwmbsmxQDGnxQwuPLdow6EMnNL1MNYI9nz2dCBfltu54cJ5MLgYklbV JxNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=wZaYxj4t; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n186-20020a6327c3000000b0054fe05a3e28si2769202pgn.94.2023.06.15.05.41.12; Thu, 15 Jun 2023 05:41:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=wZaYxj4t; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240110AbjFOM1G (ORCPT + 62 others); Thu, 15 Jun 2023 08:27:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240094AbjFOM1C (ORCPT ); Thu, 15 Jun 2023 08:27:02 -0400 Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E443D1FE5 for ; Thu, 15 Jun 2023 05:26:58 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1686832016; bh=p2JLR7eyq01/9LwarS3LHAUpoOAFYw45kGwkior1nBQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=wZaYxj4t35pT4fSuD75cWoRyumlNt1uky7QihvJZ9XfDNtr7RXz/M8yX9GkKfFe23 qFCjstYDZfADu4JBSaZjE9lha5hQ5fB9RNJc9GBiDkLqhrQemu8sdn5bY8TLArP1+e IoNdDaoTTLwbr8pvv5tFs36eiXt7EMzWNJS28S9KbAjkHzcqrJkknQMDb5hPzPyiuq B52fAsW+iBpFkv+ByvGFra8d7i+80Y3ONHxF/3XPbIZmI0APcvPfMQ96SUs5dwXrWZ Pd1YJuc0ApZtuLg9RF6AI4o5uWPaw4WE/XeXfeNFM41oB4OidSZH+Gx2jPvNuXp9XJ Ozw8hJ/mnSZaw== To: Kalle Valo Cc: Dmitry Antipov , linux-wireless@vger.kernel.org Subject: Re: [PATCH] wifi: ath9k: convert msecs to jiffies where needed In-Reply-To: <878rcmf7jt.fsf@kernel.org> References: <20230613134655.248728-1-dmantipov@yandex.ru> <87y1knw7ng.fsf@toke.dk> <87pm5yd3rz.fsf@kernel.org> <87a5x2l1bt.fsf@toke.dk> <878rcmf7jt.fsf@kernel.org> Date: Thu, 15 Jun 2023 14:26:55 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87y1kkgbcg.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kalle Valo writes: > Toke H=C3=B8iland-J=C3=B8rgensen writes: > >> Kalle Valo writes: >> >>> Toke H=C3=B8iland-J=C3=B8rgensen writes: >>> >>>> Dmitry Antipov writes: >>>> >>>>> Since 'ieee80211_queue_delayed_work()' expects timeout in >>>>> jiffies and not milliseconds, 'msecs_to_jiffies()' should >>>>> be used in 'ath_restart_work()' and '__ath9k_flush()'. >>>>> >>>>> Signed-off-by: Dmitry Antipov >>>> >>>> I believe this warrants a: >>>> >>>> Fixes: d63ffc45c5d3 ("ath9k: rename tx_complete_work to hw_check_work") >>> >>> I can add that. >> >> I was hoping you'd say that - thanks :) > > BTW you can always assume that I can change or fix the commit messages. > Just let me know exactly what to change, being able to copy paste is > best :) ACK :) -Toke