Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2057798rwd; Thu, 15 Jun 2023 21:16:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4iNyI4l2oQAsCZiWU6C8Tz8Q5DHJFTvBNNa0K+ifKuq1XYkQNutfIz+plTss9nqEMU8Khe X-Received: by 2002:a05:620a:4c82:b0:75b:23a1:3653 with SMTP id to2-20020a05620a4c8200b0075b23a13653mr572817qkn.20.1686889006411; Thu, 15 Jun 2023 21:16:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686889006; cv=none; d=google.com; s=arc-20160816; b=eSRwWJEoqTjNrIwjXRZlhT6x4dNqfmLWWVAeN+W1Az9QXWLxOs3u41z6/jcQdfSFOp xbRKwowHxrL21aPSeV/ZxEsl8NHZBHed5hykb1S0b2n2OH7Ucf3ljME8O3SiIndyIGZt oMAHG9gzVT6VO5fQr3PNyPe0qj5rSN5vGU2SOGykdyjKVTk8463p3tBZYUgvQZ3nnOsk x2zZ0wA97itXHnx9c8IL3uWiJHMWx+LSdwDduV9pnIU+0Soxu3V1PNsp53j5ooWyngY2 sAfmgQLt7jOI18aNj3SVjDVn+E/IIIDXrgjcRrnxzUHqOPDNj0S1f+jlttm+0zhE6Kiv DU1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:authenticated-by; bh=7HRTOnTAlrncPPQCDZMNkD4Pl/pIDWRZOtoutmyhnTg=; b=OPZnapEGvC+E1rq0TYGVol1AModrcY4DRDqk/OMfLKeEad6Q1Q+yQ92T+qojXlUasW 945AqO2QkNetSZXCXHH9dmSzDRT8/WlVuJZkX19MXJh24Ep/wcUgD4+5b6wMMRD7nvhJ AldshxGa5vdTnSPh8M0bZ+uNDKn9Ifg14cI9jjKDLkBf3wRVU7Nqr0si0eeW5ejgfyVu lYFs0gZoJrIHFW+XCGxvCBaa3d+dqyC4VqiRqodPHycAAs6dWJ9SE8lqHEEabPtbdrc/ WmZLielIG9/a07v6dUzhJB59o7d3jKqMC45L+DfU4IMfhwHbu4y0cchclhZsnK99IUWF I2+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x20-20020aa79574000000b0065a02d1d8f1si1142688pfq.379.2023.06.15.21.16.32; Thu, 15 Jun 2023 21:16:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240297AbjFPDpX (ORCPT + 61 others); Thu, 15 Jun 2023 23:45:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231232AbjFPDpU (ORCPT ); Thu, 15 Jun 2023 23:45:20 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11A7C18D for ; Thu, 15 Jun 2023 20:45:18 -0700 (PDT) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 35G3ioo17029301, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 35G3ioo17029301 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Fri, 16 Jun 2023 11:44:50 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Fri, 16 Jun 2023 11:45:09 +0800 Received: from [127.0.1.1] (172.21.69.188) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Fri, 16 Jun 2023 11:45:09 +0800 From: Ping-Ke Shih To: , CC: , Subject: [PATCH 0/6] wifi: rtw88: correct AP and PS mode behaviors Date: Fri, 16 Jun 2023 11:44:25 +0800 Message-ID: <20230616034431.17403-1-pkshih@realtek.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [172.21.69.188] X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) X-KSE-ServerInfo: RTEXMBS04.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org In AP mode, HI queue is used to transmit broadcast/multicast right after issuing beacon, and we need set MORE_DATA in TX description to make hardware transmits all packets in one go. Also, have special deal with this queue when doing scan and flush. After stopping AP from SCC (AP + STA), only one STA is working, so PS mode is expected to enable. However, firmware checks the MAC port used by AP mode before, and then can't enter PS mode. We add the last patch to set "default port" to the port used by STA. Then, firmware will check correct port to enter PS mode in expectation. Po-Hao Huang (6): wifi: rtw88: use struct instead of macros to set TX desc wifi: rtw88: Fix AP mode incorrect DTIM behavior wifi: rtw88: Skip high queue in hci_flush wifi: rtw88: Stop high queue during scan wifi: rtw88: refine register based H2C command wifi: rtw88: fix not entering PS mode after AP stops drivers/net/wireless/realtek/rtw88/fw.c | 68 ++++++++++ drivers/net/wireless/realtek/rtw88/fw.h | 13 ++ drivers/net/wireless/realtek/rtw88/mac80211.c | 3 + drivers/net/wireless/realtek/rtw88/main.c | 15 ++- drivers/net/wireless/realtek/rtw88/main.h | 1 + drivers/net/wireless/realtek/rtw88/pci.c | 5 +- drivers/net/wireless/realtek/rtw88/reg.h | 2 + drivers/net/wireless/realtek/rtw88/rtw8723d.c | 5 +- drivers/net/wireless/realtek/rtw88/tx.c | 84 +++++++----- drivers/net/wireless/realtek/rtw88/tx.h | 122 +++++++----------- drivers/net/wireless/realtek/rtw88/usb.c | 15 ++- 11 files changed, 216 insertions(+), 117 deletions(-) -- 2.25.1