Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <49f9687e-39ef-aad2-b02a-eb54a21b70f2@canonical.com>
Date:   Fri, 16 Jun 2023 06:57:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [RFC 1/1] wifi: rtw88: Add support for the SDIO based RTL8723DS
 chipset
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     Yan-Hsuan Chuang <tony0620emma@gmail.com>,
        Kalle Valo <kvalo@kernel.org>, linux-kernel@vger.kernel.org,
        linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
        Emil Renner Berthing <emil.renner.berthing@canonical.com>
References: <20230615142044.1357257-1-heinrich.schuchardt@canonical.com>
 <CAFBinCAEFvmxnBDJPSs+mGqAraGUDFkCB3SjRTEyC9waA3P8JQ@mail.gmail.com>
Content-Language: en-US
From:   Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
In-Reply-To: <CAFBinCAEFvmxnBDJPSs+mGqAraGUDFkCB3SjRTEyC9waA3P8JQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 6/16/23 00:13, Martin Blumenstingl wrote:
> Hello Heinrich,
> 
> On Thu, Jun 15, 2023 at 4:21 PM Heinrich Schuchardt
> <heinrich.schuchardt@canonical.com> wrote:
> [...]
>> On my Lichee RV Dock board this patch is enough to make The RTL8723DS
>> work. But unfortunately after running some time the driver crashes.
>> My impression is that the crash is not specific to my patch but must
>> be hidden in one of the existing functions it is invoking.
>>
>> This seems to be related to not checking pkt_stat->pkt_len.
>>
>> My kernel was built against v6.4-rc6.
> As Larry has mentioned: support for the RTL8723DS chipset is in
> wireless-next.git
> You can find the whole series here: [0]
> 
> It seems you're missing at least "wifi: rtw88: sdio: Check the HISR
> RX_REQUEST bit in rtw_sdio_rx_isr()" [1]
> That patch should fix the exact issue that you described.

Thanks for your great work.

With the series on top of v6.4 my RISC-V LicheeRV Dock runs fine.

Best regards

Heinrich

> [0] https://lore.kernel.org/linux-wireless/20230522202425.1827005-1-martin.blumenstingl@googlemail.com/
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/commit/?id=e967229ead0e6c5047a1cfd5a0db58ceb930800b