Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2e78d1f5-4dc5-9665-e3a1-ee00dcc41630@yandex.ru>
Date:   Fri, 16 Jun 2023 13:20:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 4/4] [v2] wifi: rtlwifi: simplify LED management
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Ping-Ke Shih <pkshih@realtek.com>, linux-wireless@vger.kernel.org
References: <20230608095051.116702-4-dmantipov@yandex.ru>
 <168664510862.24637.10587241603155144086.kvalo@kernel.org>
 <e030e496-b667-b1de-492b-8b0cc04ffe14@yandex.ru> <87h6rad3fp.fsf@kernel.org>
 <bccf723a-9f57-73a7-37af-badc6c156daa@yandex.ru> <87cz1vbulk.fsf@kernel.org>
From:   Dmitry Antipov <dmantipov@yandex.ru>
In-Reply-To: <87cz1vbulk.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/16/23 12:54, Kalle Valo wrote:

> rtl818x is not active. You can actually check that yourself:
> 
> git log drivers/net/wireless/realtek/rtl818x/

Note MAINTAINERS marks drivers/net/wireless/realtek/rtl818x/rtl8180 as
orphaned but drivers/net/wireless/realtek/rtl818x/rtl8187 as maintained.

> I want to also mention that the maintainers are not really enthusiastic
> about random cleanups to random drivers from new contributors, they
> increase our workload and there's always a risk of regressions. I try to
> be nice and take few cleanups now and then, but if there's too much such
> patches I'll start to back off.
> 
> Instead random cleanups I would be very happy to see these issues fixed
> in wireless drivers:
> 
> o removal of strlcpy()
> 
> o fixing sparse warnings (my goal is to have wireless drivers sparse
>    warning free)
> 
> o removal of BUG_ON() (no wireless driver should use BUG_ON() which
>    crashes the whole system)

Got your point, thanks.

Dmitry