Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 14:26:12 +0200
From:   Sascha Hauer <s.hauer@pengutronix.de>
To:     petter@technux.se
Cc:     pkshih@realtek.com, linux-wireless@vger.kernel.org,
        Larry.Finger@lwfinger.net, andreas@fatal.se, iam@valdikss.org.ru,
        kernel@pengutronix.de, kvalo@kernel.org, linux@ulli-kroll.de,
        petter.mabacker@esab.se
Subject: Re: rtw8822cu (LM842) stalls when running HW offload scan
Message-ID: <20230616122612.GL18491@pengutronix.de>
References: <20230612133023.321060-1-petter@technux.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230612133023.321060-1-petter@technux.se>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Mon, Jun 12, 2023 at 03:30:23PM +0200, petter@technux.se wrote:
> Some time ago https://bugzilla.kernel.org/show_bug.cgi?id=217034 was
> created. From the beginning it was just about some error printouts.
> Then Andreas (who created the bug report) mentioned that it seems to
> work worse after bumping the firmware to > 9.9.10. After some fixes
> from Sascha the error printouts dissappeared. But when I also started
> to run this using firmware > 9.9.10 I also got problems. On my i.MX8
> and RPi4 board it works fine, but on some of my less powerful boards
> such as and older RPi and my i.MX6 SoloX board, it always fails using
> 9.9.10 firmware. After some digging in the git log, I discovered
> that HW scan offload was introduced in a later firmware. So when I
> disable HW offload scan it seems to work again on all my boards. But
> still I want to understand why the HW offload scan don't work for
> me.
> 
> Like described in the bug report I get below when running on latest
> 6.4 mainline with all relevant patches around rtw88 applied.

I can't reproduce this here. I am currently running v6.4-rc3 plus:

wifi: rtw88: usb: silence log flooding error message

I tested on a i.MX6S (not SoloX) board with Firmware 9.9.14.

A "nmcli dev wifi rescan" works just fine and the link also continues to
work.

I verified that FW_FEATURE_SCAN_OFFLOAD is set and used in the driver,
also that it's not set in Firmware 9.9.9. I also tried to put some
load on the link by running iperf3, still no difference.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |