Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7cdadb5c-75d8-74ec-ca3a-11539878b55a@gmail.com>
Date:   Fri, 16 Jun 2023 15:05:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] wifi: p54: Add missing MODULE_FIRMWARE macro
Content-Language: de-DE, en-US
To:     Juerg Haefliger <juerg.haefliger@canonical.com>, kvalo@kernel.org,
        linux-wireless@vger.kernel.org
References: <20230616121917.1034761-1-juerg.haefliger@canonical.com>
From:   Christian Lamparter <chunkeey@gmail.com>
In-Reply-To: <20230616121917.1034761-1-juerg.haefliger@canonical.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/16/23 14:19, Juerg Haefliger wrote:
> Add the missing MODULE_FIRMWARE macro for "3826.eeprom".
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Sure.

Acked-by: Christian Lamparter <chunkeey@gmail.com>

For people looking for the "3826.eeprom": Default values
are provided by p54spi_eeprom.h . But there's a MAC field
and antennas dbi values in there for customization.

Cheers,
Christian
> ---
>   drivers/net/wireless/intersil/p54/p54spi.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/intersil/p54/p54spi.c b/drivers/net/wireless/intersil/p54/p54spi.c
> index 19152fd449ba..ce0179b8ab36 100644
> --- a/drivers/net/wireless/intersil/p54/p54spi.c
> +++ b/drivers/net/wireless/intersil/p54/p54spi.c
> @@ -28,6 +28,7 @@
>   #endif /* CONFIG_P54_SPI_DEFAULT_EEPROM */
>   
>   MODULE_FIRMWARE("3826.arm");
> +MODULE_FIRMWARE("3826.eeprom");
>   
>   /* gpios should be handled in board files and provided via platform data,
>    * but because it's currently impossible for p54spi to have a header file