Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <83f35ea2-935e-3026-908e-74a5147b22f8@amd.com>
Date:   Sun, 18 Jun 2023 21:22:58 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH V3 5/7] drm/amd/pm: add flood detection for wbrf events
Content-Language: en-US
To:     Evan Quan <evan.quan@amd.com>, rafael@kernel.org, lenb@kernel.org,
        Alexander.Deucher@amd.com, Christian.Koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        kvalo@kernel.org, nbd@nbd.name, lorenzo@kernel.org,
        ryder.lee@mediatek.com, shayne.chen@mediatek.com,
        sean.wang@mediatek.com, matthias.bgg@gmail.com,
        angelogioacchino.delregno@collabora.com, Lijo.Lazar@amd.com
Cc:     linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-wireless@vger.kernel.org
References: <20230616065757.1054422-1-evan.quan@amd.com>
 <20230616065757.1054422-6-evan.quan@amd.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20230616065757.1054422-6-evan.quan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SndkQzl2UEltcFVVVmo0dm94MjVLM2tndXgrcTI2dTJVNGRhbk84UGxjaGxF?=
 =?utf-8?B?TmM5Y0lPZnZwNnhLUGo2eGxDYVgzYUZDeWlKZEltaCtLSWxFUzVmQ2YvZm5h?=
 =?utf-8?B?cXhyTXEyb0RFMnQ3QmthclJUUG15R3pncXdaV25STWd2d1hXYzduTjZmVHp3?=
 =?utf-8?B?Z3hlWHd5aUFmUUpVUUNUVHJCYU0wMVlVVGlMNldWWVoxWmZJY0RBUXZLbm5v?=
 =?utf-8?B?STMxcklVS25NcXdWNkdQN1d0R3pjMGpXa083WGw5RW1JWUpDMVJVbnNuZk56?=
 =?utf-8?B?T3ZMTnBhYk50N0Q1WVlvVFRmeEZVcTQ1TTR4dlJGeUwvQ1Jma0ovOTlWSDRZ?=
 =?utf-8?B?eERkek4zUWV6Z0Y5anUyaUJScStKenAzcHpLOVZRZmVXWHhxU3VoS2U0a1py?=
 =?utf-8?B?Wm5LUzRUNmRSR0FzSjI5OWx4Wnd1NFBQNFVEdWNyZnVtdVBhSkhPUFhlcGs2?=
 =?utf-8?B?YXVIejJ2QVZYWWEzQzVxc3QyTnBEZXg2a3RTcEVDWTIrdGZhY0xPN0hpSElK?=
 =?utf-8?B?SUdjWEU2MHk0dldGejRsRlpweUF3OU5LVm9GRWlHYnRwSUtmTHdlN043SVo2?=
 =?utf-8?B?a3ZyL2E2U28rRUlISmNDbzYwQ24rQk1mSVJjYzdEb0xMeDZZamkvRFF4SnRZ?=
 =?utf-8?B?OXVjczdVb2k1elFDc25RNGVCQk5iYU9aZEZNemFFdVE4YlJONUQ2WlFMWTBi?=
 =?utf-8?B?T3VOVk9pVy9NM24xd0RCa252Nlk3b2RQcStXdkVmVER6ZStjT0NPSXNHU3ZI?=
 =?utf-8?B?NldkWGlrSEN5UVJCWmp1Tk5nbUl1OVFsTG9JSExaQXlseXdNR2s0Z2NveVFI?=
 =?utf-8?B?SmY4ano2b1ZBM0tGVkFwT1hkUGxNQitWUnQ1Q25EK1V1V1BWSmpzcFM0VnBr?=
 =?utf-8?B?U3ZlN0xVWko1T2d3YjhObFV4aFEwWkRWRTJzc2ZNR1NNQndXclJVb3dvUDJo?=
 =?utf-8?B?MS96N1J5VzlrSHloQnhnRmtOV3pic1dwc3BFeG5oYkI5OFc4NjRGcUxWYTZa?=
 =?utf-8?B?d2JyZGsxN3I1Mkt0TVI3QW5Dc2s0WHpnY3kyb1E3YzJYZGVYbTlMMll2SG1I?=
 =?utf-8?B?VXVBdy94Y3N0QjFXOGlwN0hXODJrZ05sWUdnRzNZYWlTR2pUeGlISHlVSFpI?=
 =?utf-8?B?TjlWQm8xRFZOeHE0ais5MjF1eUVRcGtNemVNVmFEblc1bEtVOVVSeXlaQjF3?=
 =?utf-8?B?WnkyTTRaaHN4MmdwNDcyODl5Z0V6QURIeGFWdkU0ZzFIdHp3bzBsSjYxZ0FP?=
 =?utf-8?B?cURCUVo3WjhrcW9FYXprMFBYODNPZTB2OHZCZGg0RE11UndUTlhJMXBZTHFI?=
 =?utf-8?B?cUM4aFF2VG5iWDRVTDlmUDZpL2VLL3NTLzAyYVNHeGVmeWUyU2JiRVhDNGd0?=
 =?utf-8?B?L1NFOHhTMWMrRWFLZHlzZlRMR1lhTjhOMUFESTNsKytJU0VKc0JJdlY4VSsz?=
 =?utf-8?B?ajF2M2Q3VWRLd0NzRUhIOGkyTDJhelU1bmJsNmtQVFZEQlZaUlRMb0VtRjNK?=
 =?utf-8?B?TkNTemdJbDVVVDBLMUV6WUYxWGZFZnYySGV1VWl0Nm51SWJaanN5SHNFbUg1?=
 =?utf-8?B?M044THpvcUpZMC9uY3V4MXFLQ0ZJOFdicGFBU3F3NVNHRHAxOCsxTU5xTTk3?=
 =?utf-8?B?VWZaYjIvUnNHTHRDd0pib2sxeVNaanpTeXpSdkQ0aVZmOHlLU1ExTXZwYjBy?=
 =?utf-8?B?MGJQcGdNcldpZjdZbWowV3hqZG9mMGt5YmNaSlVWd0RpMTNGa2E5Mkk4em9Y?=
 =?utf-8?B?VEF5eTFDaU1NNnBSTGw1d1k2cFBacDRUUmpUTXh3RlI5Z3VmbDJ5bVcvZkRC?=
 =?utf-8?B?RVliSldqQjE5MFFTZjdPNDFlRzJvSGo5c0hmdlI1R3V5dHQ1QjRtT01uNHF5?=
 =?utf-8?B?SHd6T1FjeVptaEtLTmJQRStTMWJ0MWZMYk5zWVZwV3ArbFNaZlZrUkdzNU1R?=
 =?utf-8?B?YzJxUkh2azEwZFFDdGV2azZQMFlqZFFRRWVyUDdGcmdoSEJWSkNBQTBMSk9D?=
 =?utf-8?B?bW9QZ0drQ0RNaW9nUnZmVm85akI5a3BQUUlPRVNCc293MlA3NVlKdzlwK3ZC?=
 =?utf-8?B?SnJWVkVNUW5qa0RpWUxqa2E3Z0YwSXQzc0hmbWVmWmVNM3FYT1FMU0RuUHNE?=
 =?utf-8?B?emNrSFRiUlV4aE04MmlOemJkRmZUMjVzUEExN3VqL0pQOTV6cmRydFZWTlZU?=
 =?utf-8?B?YUE9PQ==?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46a1dd6b-57ae-49d0-0dd9-08db706c1b5f
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 02:23:02.2115
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 19UFpwm+cAx1XhISoVcioXX/1EvAMM9ZGquanXXHTbjogMF4DlOn2eR00lxF+NFkxB6knFUX48O6g9PWp/XXdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8424
X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On 6/16/23 01:57, Evan Quan wrote:
> To protect PMFW from being overloaded.
> 
> Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c     | 28 ++++++++++++++++---
>   drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h |  7 +++++
>   2 files changed, 31 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> index 89f876cc60e6..2619e310ef54 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> @@ -1272,6 +1272,22 @@ static void smu_wbrf_event_handler(struct amdgpu_device *adev)
>   {
>   	struct smu_context *smu = adev->powerplay.pp_handle;
>   
> +	schedule_delayed_work(&smu->wbrf_delayed_work,
> +			      msecs_to_jiffies(SMU_WBRF_EVENT_HANDLING_PACE));
> +}
> +
> +/**
> + * smu_wbrf_delayed_work_handler - callback on delayed work timer expired
> + *
> + * @work: struct work_struct pointer
> + *
> + * Flood is over and driver will consume the latest exclusion ranges.
> + */
> +static void smu_wbrf_delayed_work_handler(struct work_struct *work)
> +{
> +	struct smu_context *smu =
> +		container_of(work, struct smu_context, wbrf_delayed_work.work);
> +
>   	smu_wbrf_handle_exclusion_ranges(smu);
>   }
>   
> @@ -1311,6 +1327,9 @@ static int smu_wbrf_init(struct smu_context *smu)
>   	if (!smu->wbrf_supported)
>   		return 0;
>   
> +	INIT_DELAYED_WORK(&smu->wbrf_delayed_work,
> +			  smu_wbrf_delayed_work_handler);
> +
>   	ret = amdgpu_acpi_register_wbrf_notify_handler(adev,
>   						       smu_wbrf_event_handler);
>   	if (ret)
> @@ -1321,11 +1340,10 @@ static int smu_wbrf_init(struct smu_context *smu)
>   	 * before our driver loaded. To make sure our driver
>   	 * is awared of those exclusion ranges.
>   	 */
> -	ret = smu_wbrf_handle_exclusion_ranges(smu);
> -	if (ret)
> -		dev_err(adev->dev, "Failed to handle wbrf exclusion ranges\n");
> +	schedule_delayed_work(&smu->wbrf_delayed_work,
> +			      msecs_to_jiffies(SMU_WBRF_EVENT_HANDLING_PACE));
>   
> -	return ret;
> +	return 0;
>   }
>   
>   /**
> @@ -1343,6 +1361,8 @@ static void smu_wbrf_fini(struct smu_context *smu)
>   		return;
>   
>   	amdgpu_acpi_unregister_wbrf_notify_handler(adev);
> +
> +	cancel_delayed_work_sync(&smu->wbrf_delayed_work);
>   }
>   
>   static int smu_smc_hw_setup(struct smu_context *smu)
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h b/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
> index ff0af3da0be2..aa63cc43d41c 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
> +++ b/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
> @@ -478,6 +478,12 @@ struct stb_context {
>   
>   #define WORKLOAD_POLICY_MAX 7
>   
> +/*
> + * Configure wbrf event handling pace as there can be only one
> + * event processed every SMU_WBRF_EVENT_HANDLING_PACE ms.
> + */
> +#define SMU_WBRF_EVENT_HANDLING_PACE	10
> +
>   struct smu_context
>   {
>   	struct amdgpu_device            *adev;
> @@ -576,6 +582,7 @@ struct smu_context
>   
>   	/* data structures for wbrf feature support */
>   	bool				wbrf_supported;
> +	struct delayed_work		wbrf_delayed_work;
>   };
>   
>   struct i2c_adapter;