Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6abc24f254fd265f8f533ef52e2798c617e30359.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: iwlfifi: fix -Wunused-const-variable gcc warning
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Dmitry Antipov <dmantipov@yandex.ru>,
        Gregory Greenman <gregory.greenman@intel.com>
Cc:     Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org
Date:   Mon, 19 Jun 2023 12:17:20 +0200
In-Reply-To: <20230619100030.284920-1-dmantipov@yandex.ru>
References: <20230619100030.284920-1-dmantipov@yandex.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-06-19 at 13:00 +0300, Dmitry Antipov wrote:
> Fix the following gcc 13.1 warning observed with W=3D1:
>=20
> drivers/net/wireless/intel/iwlwifi/dvm/rs.c:207:39: warning:
> =E2=80=98iwl_rate_mcs=E2=80=99 defined but not used [-Wunused-const-varia=
ble=3D]
>=20
> This table is actually used in 'rs_sta_dbgfs_scale_table_read()'
> only if CONFIG_MAC80211_DEBUGFS is enabled.
>=20
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
>  drivers/net/wireless/intel/iwlwifi/dvm/rs.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c b/drivers/net/wi=
reless/intel/iwlwifi/dvm/rs.c
> index 687c906a9d72..ecad7403ec96 100644
> --- a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
> +++ b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c
> @@ -203,6 +203,8 @@ static const u16 expected_tpt_mimo3_40MHz[4][IWL_RATE=
_COUNT] =3D {
>  	{0, 0, 0, 0, 277, 0, 478, 624, 737, 911, 1026, 1070, 1109}, /* AGG+SGI =
*/
>  };
> =20
> +#ifdef CONFIG_MAC80211_DEBUGFS
> +
>  /* mbps, mcs */
>  static const struct iwl_rate_mcs_info iwl_rate_mcs[IWL_RATE_COUNT] =3D {
>=20

Maybe move it to the existing ifdef, or even into the function?

Also, you have a typo in subject, 'iwlwifi', but should probably be
"wifi: iwlwifi: dvm: ..." since dvm/mvm are hugely different.

johannes