Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Dmitry Antipov <dmantipov@yandex.ru>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
CC:     Kalle Valo <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 3/3] [v3] wifi: rtw88: remove unused USB bulkout size set
Thread-Topic: [PATCH 3/3] [v3] wifi: rtw88: remove unused USB bulkout size set
Thread-Index: AQHZoDDgsqypGkZyX0KWVgPRq7dcwq+TEihw
Date:   Tue, 20 Jun 2023 03:49:19 +0000
Message-ID: <5ecd668942f44275953081ae63acc57c@realtek.com>
References: <20230616085917.60662-1-dmantipov@yandex.ru>
 <20230616085917.60662-3-dmantipov@yandex.ru>
In-Reply-To: <20230616085917.60662-3-dmantipov@yandex.ru>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

// add rtw88 USB author Sascha for his comments.

> -----Original Message-----
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Sent: Friday, June 16, 2023 4:59 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org; Dmitry Antipov <dmantipov@yandex.ru>
> Subject: [PATCH 3/3] [v3] wifi: rtw88: remove unused USB bulkout size set
> 
> Drop no longer used 'bulkout_size' of 'struct rtw_usb'
> and related macros from usb.h, but preserve sanity check
> in 'rtw_usb_parse()'. This follows commit 462c8db6a011
> ("wifi: rtw88: usb: drop now unnecessary URB size check").
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
>  drivers/net/wireless/realtek/rtw88/usb.c | 5 -----
>  drivers/net/wireless/realtek/rtw88/usb.h | 5 -----
>  2 files changed, 10 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c
> index 6862338b1d51..40e614f58349 100644
> --- a/drivers/net/wireless/realtek/rtw88/usb.c
> +++ b/drivers/net/wireless/realtek/rtw88/usb.c
> @@ -186,13 +186,8 @@ static int rtw_usb_parse(struct rtw_dev *rtwdev,
>         switch (usbd->speed) {
>         case USB_SPEED_LOW:
>         case USB_SPEED_FULL:
> -               rtwusb->bulkout_size = RTW_USB_FULL_SPEED_BULK_SIZE;
> -               break;
>         case USB_SPEED_HIGH:
> -               rtwusb->bulkout_size = RTW_USB_HIGH_SPEED_BULK_SIZE;
> -               break;
>         case USB_SPEED_SUPER:
> -               rtwusb->bulkout_size = RTW_USB_SUPER_SPEED_BULK_SIZE;
>                 break;
>         default:
>                 rtw_err(rtwdev, "failed to detect usb speed\n");

If we decide to remove rtwusb->bulkout_size, I suggest to remove whole
switch..case chunk.