Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp7476510rwd; Tue, 20 Jun 2023 01:36:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4dJELvHpCeWQHxZGrz/CEfnVFSvTU3ybqtxbi6e1MXRwk0OHAfvC8QBNVnxSBXWyITOVED X-Received: by 2002:a05:6a20:12c7:b0:118:384f:89bc with SMTP id v7-20020a056a2012c700b00118384f89bcmr15123976pzg.27.1687250160412; Tue, 20 Jun 2023 01:36:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687250160; cv=none; d=google.com; s=arc-20160816; b=s0Pbl641gVPxof9wM2cFjcBXkasqE05rAV0TvCA4FuHiBKiWlYm5lb6KDSeID87gGX MCq9t3mYkrzVAEaAIztiDRJVyrgpxS374e91RVVV5yk10bDDrGnXB8QsfB18c9O4dCpF GxCOkyG4zGFoGuWoNsJmlFYMSEisYz3MnoyPLKmYD8u8ZlOMHY27rGX1TQB3sYDLTz0h F+59x3HRh2dW7E0IXPR0/UzBkD7P468/vIlN+c7OEGDpuixk0Hb6HtM70YKycyTzImw9 r7ZuyTlWxj3uJbezFvkUFOOq/heymCea93ddkyRX47orVM5I4uO7UmMmxmhMBuAoimj2 9bYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=s67ry7Co9MPhktxsgxXhz8/DBce/8Tak4qy6/Iz1lww=; b=EpipCQeHsBgBt/jlacIR09pAMNA4eGwZo17z5FP6ibylhvEPsyM3uCCIeTWZhUgfzJ 312vr2JK0j5hAMbURBjVA+JEK1EfNBusU92Bb4zA5MZ6PbOdkHDrcfA0Q14/HcgQ3ayg 2U2BdruFHFf4zUET2roDR/dxsqAhtM51YlVKGUcu40qedI6DdhCg/wrieHo9t+Lk1L5L C46HLqBorIO2HbwZgxJuIB5A+rCsUwfswPBLkaupz2oDUMUI4POxDIcloNupvmEa9dP2 go/fkY/yXud6We3VjJgsSYtzVaImNeWhawvP/mtxjwgpc3w2lVKi9kg3r0KnA0W8VjTd XLYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=kxAX+Rqr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h65-20020a625344000000b0065e445224e5si1202536pfb.332.2023.06.20.01.35.51; Tue, 20 Jun 2023 01:36:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=kxAX+Rqr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231654AbjFTIJT (ORCPT + 59 others); Tue, 20 Jun 2023 04:09:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231636AbjFTIJS (ORCPT ); Tue, 20 Jun 2023 04:09:18 -0400 Received: from forward100a.mail.yandex.net (forward100a.mail.yandex.net [IPv6:2a02:6b8:c0e:500:1:45:d181:d100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D550DB1 for ; Tue, 20 Jun 2023 01:09:15 -0700 (PDT) Received: from mail-nwsmtp-smtp-production-main-39.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-39.vla.yp-c.yandex.net [IPv6:2a02:6b8:c0d:31b:0:640:fdf8:0]) by forward100a.mail.yandex.net (Yandex) with ESMTP id 973AD46CE6; Tue, 20 Jun 2023 11:09:08 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-39.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id v8cEIqsDXeA0-WoxGkl3S; Tue, 20 Jun 2023 11:09:08 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1687248548; bh=s67ry7Co9MPhktxsgxXhz8/DBce/8Tak4qy6/Iz1lww=; h=Message-ID:Date:Cc:Subject:To:From; b=kxAX+Rqr/AGt/MD7gNJ1MkroAkFWIGHXKLO72eW9HSrVhc5GXoxGgRH3Y371aKMEc ivQTKWWLr3tyqtvJzU4JvujcLxb0bVC66EIdSnagmttxy+S1RZPFa8AHpC2MrkFTdP Lh+KbQ8OhinTUrWGG2M+aWLSHIBsGz0liVxcdXeA= Authentication-Results: mail-nwsmtp-smtp-production-main-39.vla.yp-c.yandex.net; dkim=pass header.i=@yandex.ru From: Dmitry Antipov To: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= Cc: Kalle Valo , linux-wireless@vger.kernel.org, Dmitry Antipov Subject: [PATCH 1/2] [v2] wifi: ath9k: avoid using uninitialized array Date: Tue, 20 Jun 2023 11:08:40 +0300 Message-ID: <20230620080855.396851-1-dmantipov@yandex.ru> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org In 'ath_tx_count_frames()', 'ba' array may be used uninitialized, so add 'memset()' call similar to one used in 'ath_tx_complete_aggr()'. Signed-off-by: Dmitry Antipov --- drivers/net/wireless/ath/ath9k/xmit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c index f6f2ab7a63ff..8babaaacacf5 100644 --- a/drivers/net/wireless/ath/ath9k/xmit.c +++ b/drivers/net/wireless/ath/ath9k/xmit.c @@ -466,6 +466,8 @@ static void ath_tx_count_frames(struct ath_softc *sc, struct ath_buf *bf, *nframes = 0; isaggr = bf_isaggr(bf); + memset(ba, 0, WME_BA_BMP_SIZE >> 3); + if (isaggr) { seq_st = ts->ts_seqnum; memcpy(ba, &ts->ba_low, WME_BA_BMP_SIZE >> 3); -- 2.41.0