Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9058517rwd; Wed, 21 Jun 2023 02:23:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6W+dFxDd+MQVUko/oaAdBPzI6VATdB5ryREFhAw+AHtFzvtsoPa3UHzRbsYBbn/+eYsNf3 X-Received: by 2002:a05:6a21:999d:b0:120:dd5b:a10b with SMTP id ve29-20020a056a21999d00b00120dd5ba10bmr7624388pzb.37.1687339414015; Wed, 21 Jun 2023 02:23:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687339413; cv=none; d=google.com; s=arc-20160816; b=KEM9dJITSvHnXZBK2EyJfZuQJ1okivum5UAtLRL7pnpGBQy0QGt129w8sHrIFcsPUa LlFMkGmdXjUfet0q+hj+qpiyVo9uZF1YVP0LCO6Vodu/VG/hFMI60EkRgJ6YUS8nevtI 98pogNVBFDPri0HFD/yK0nL6rfZextEn7n5Nn/kqXpK27ceIM2KEnYXg3sNJ3zHkznZL K0YPg4C2yvs+zaUAUsT7BedRNbzFdNqOz91wQas3kgCoY1D/TqfrMgE+5ev9uvIb3VpL UhxsIF8NlToiWMF07TIt1t0q07ID5ohhN0LwjVrpIEy95+bNdo0v23IviyKPIa/CWFMO UU8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=1sazfbQfnjI17a+qA2NaZaAjRDkip2Z0lzzQuI5cNCo=; b=upWyPl0+nN+2fAg5XCxzIcHAG6xtGkYkHNGgtdG9Njh3Q8lSo+6a3hwe2yiycuJ3EO oBg2jFqB4UxUUncwk+oFGP/VqCL3c96LY81SNRY+inhumw9rgiFKRluCbO30/ovhSkA6 s/x6YfQhSj9LMghtijleEOSLIRyAO6loh22+D6FbA7MW1VrpiarkqM39xo7rul0i8hrR 1Bsl+sLx8cJdNi0rkFRIM98FMYfXtkOrZ5wU8QNd4MPtEGIIxe7xrJTabkSCoAwMH4Sr +oLWL87NqIqHmqHV4jh5KA+MExoJID+ZOa5zP1axko7aeUuir8SFu48Y7CQPBgSXlw4P PIVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gkMvHoNm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b12-20020a170902bd4c00b001ae0691dff4si3676293plx.630.2023.06.21.02.23.21; Wed, 21 Jun 2023 02:23:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gkMvHoNm; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231262AbjFUJV3 (ORCPT + 60 others); Wed, 21 Jun 2023 05:21:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231218AbjFUJV0 (ORCPT ); Wed, 21 Jun 2023 05:21:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5D8B1B4 for ; Wed, 21 Jun 2023 02:21:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F04CF614C7 for ; Wed, 21 Jun 2023 09:21:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E157C433C8; Wed, 21 Jun 2023 09:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687339279; bh=nsVwiMkVL0ODjNvgmiZTSWnr0tfEycFYv1F01wZoxPc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gkMvHoNmph3INS0Snn7Xf9+ONo66zes9q7k/pYzOI82XzDW+Mc3vyT3ua3mbbmsPi CnXYj8CeIgqSXtNlsSDz4zXzNB5t8zT/3oRp/On46cEx6cUfE9whpYZuAXQcOoxFXu LA3M6HyN9EWqdKgGV5699+SVOWm6dUcSJbv9pNJPOln2YrrTotrJS4BxzX4zEy5sqZ VT9jTxcM1BfNwaCxnpKjWecA6tUkUwEddaYgB8OW0JD9BwMM7oAWPmyBEwC6AJoyaD b7RyaQK6GitdccsJXMoH2X5s6c1seDkEPYvlpvPgRqkGUEGYJSuthPB7NgkW/Tw98q w0l4QGEO71kPw== From: Kalle Valo To: Ping-Ke Shih Cc: , , Subject: Re: [PATCH v2 0/6] wifi: rtw88: correct AP and PS mode behaviors References: <20230616125540.36877-1-pkshih@realtek.com> Date: Wed, 21 Jun 2023 12:21:14 +0300 In-Reply-To: <20230616125540.36877-1-pkshih@realtek.com> (Ping-Ke Shih's message of "Fri, 16 Jun 2023 20:55:34 +0800") Message-ID: <87edm59nn9.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ping-Ke Shih writes: > Note: The patch 5/6 ("wifi: rtw88: refine register based H2C command") > adds new static function that is used by patch 6/6, so compiler will > warn unused function if we build this path. Thanks for the note, this is always good to know. In general it would be better to avoid having the warning at all, for example in this case one solution would have been to merge patches 5 and 6 into one patch. But no need to resend because of this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches