Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     <Amisha.Patel@microchip.com>
Cc:     <linux-wireless@vger.kernel.org>, <Ajay.Kathat@microchip.com>,
        <Claudiu.Beznea@microchip.com>
Subject: Re: [PATCH v2] wifi: wilc1000: add SPI commands retry mechanism
References: <20230614203215.9652-1-amisha.patel@microchip.com>
Date:   Wed, 21 Jun 2023 12:32:36 +0300
In-Reply-To: <20230614203215.9652-1-amisha.patel@microchip.com> (Amisha
        Patel's message of "Wed, 14 Jun 2023 20:32:46 +0000")
Message-ID: <87zg4tdutn.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

<Amisha.Patel@microchip.com> writes:

> From: Amisha Patel <amisha.patel@microchip.com>
>
> In some situations like, chip wake-up with powersave enabled, SPI
> commands are failing temporarily. Reissuing commands after reset helps
> to overcome the failure. So, add the retry limit and reset command
> sequence API for read/write SPI commands.
>
> Signed-off-by: Amisha Patel <amisha.patel@microchip.com>

[...]

> +retry:
>  	result = wilc_spi_single_read(wilc, cmd, addr, data, clockless);
>  	if (result) {
>  		dev_err(&spi->dev, "Failed cmd, read reg (%08x)...\n", addr);
> -		return result;
> +
> +		/* retry is not applicable for clockless registers */
> +		if (clockless || !retry_limit)
> +			return result;
> +
> +		wilc_spi_reset_cmd_sequence(wilc, retry_limit, addr);
> +		retry_limit--;
> +		goto retry;
>  	}

A for loop is recommended over a goto loop. Also in this case I find
'retry_limit == 0' more readable than '!retry_limit', it's a counter
anyway.


-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches