Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp9098136rwd; Wed, 21 Jun 2023 03:03:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4xiAlelVqOeCGXupUciOjfE2c3ZJLStPt0ArkmOPKZ8QRONfZlCYwIbUVte3atrAGZbokz X-Received: by 2002:a05:6a00:1a88:b0:66a:3b01:2360 with SMTP id e8-20020a056a001a8800b0066a3b012360mr1717685pfv.21.1687341780137; Wed, 21 Jun 2023 03:03:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687341780; cv=none; d=google.com; s=arc-20160816; b=zb+w33N7oD9qaaSV5aMIGXXSvbH/TfzP3jNje2N0wgjCYNv+G4hvCHUdRNIuZQGDqM 3X0L3bc4HNRXyRPDm1o9yST1aar13Wa6MI01jgecCwl/Q3QvdV72dReG7rkkUcE+Lhex pweU+8qDYTgxjp49Qt+WptRnePFKfKDGrj2WSZGfkrV5rp5HqdEXxflzLPlsjEacNtin 7VWR/hCr14e4bOAg46QNLE5Ut373DaQnaGYALdlMu380V5X9bUt+ki3r5e48GQQRL60l if4jfbq1ITUghnsl2ak78MsbkQzbVEu1TRuS6zHT2K7kcYy2nbNFQukM3wuUsrL996Mj kujw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=xrQtyYcG+nzp3NnkTV4+3aI/A0IVhEHrM9cJEXlBuPA=; b=YjPPw8+MQY2ltayjYriM/VkVOPlgW9MwtVCZ1bKAQCHioY1mJ7M+QKpyu9Fz+jL9ls AGYO04FXb4GLWLQnncP0/j5pty4ZTFe7m/BiEFxwY1PIKLJYjdPWmFCZH1DKVEkue4Gp gRxLzMYmI94Woz95gqIS22alxFkQ0VahiCZhBo4hEqc5lumexfWHhbiK2k09OGSn1A2u zKwZ9vLm75cSeUggwGpiWVJsN3OH/yNF+QG/0v9hMy6zD4t3ugnGYvpQojfHdPRtpvMt nsGRj4VB5Ygw8+D2+XYIULdVoMtfegn1PMGDYuVJW0lFNGmv/U7bN2EJCnQyHTkZJO6N 4LOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LS76cS7B; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j190-20020a636ec7000000b005572b563e5esi1604926pgc.160.2023.06.21.03.02.50; Wed, 21 Jun 2023 03:03:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LS76cS7B; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231889AbjFUJm3 (ORCPT + 59 others); Wed, 21 Jun 2023 05:42:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231923AbjFUJls (ORCPT ); Wed, 21 Jun 2023 05:41:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C51F1BC6 for ; Wed, 21 Jun 2023 02:41:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CF050614DE for ; Wed, 21 Jun 2023 09:41:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49291C433B9; Wed, 21 Jun 2023 09:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687340491; bh=Am9NL8L9eEag9mpNcdUvp8YnrDJy7hNusrhJfo2GqhI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=LS76cS7BsA5/uFMe/r+nt4tpgVB8lJvHfnrbcmntckvg/f3MMRzGot8+CidSd7m7I 12xhEJKgHgJqwYMTMWnVyqYhJGaYb4wffRGxFcNhVlJW1WYXIkmqb0CQn9juliq+MB tB4CKs1K2UYUqfvovaHxuLdYT/nkED85Ojwal+U4CIyjWUS88PlKHa85+HgNcbxglx B1MZvcJL1qbHyrbFVtC0205skE4fEj4DU1ov3SdYZFvWdUGLrAzzyhyZhfBFBSShDP Gyq0M3qpeapzHxp/HqkBzHm6D1l3hxcxI8GRIJJpF/IUOXRA0w8L2mtJzi7T+gYXlJ Xeg7mEQtRmbyQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw88: process VO packets without workqueue to avoid PTK rekey failed From: Kalle Valo In-Reply-To: <20230616031713.16769-1-pkshih@realtek.com> References: <20230616031713.16769-1-pkshih@realtek.com> To: Ping-Ke Shih Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <168734048798.380100.11902910174609581862.kvalo@kernel.org> Date: Wed, 21 Jun 2023 09:41:30 +0000 (UTC) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ping-Ke Shih wrote: > From: Chih-Kang Chang > > In the wpa_supplicant rekey flow, it sends an EAPOL packet 4/4 through > nl80211_tx_control_port() and triggers wake_tx_queue() in the driver. > Then, it sends nl80211_new_key() to configure a new key in mac80211. > However, in wake_tx_queue(), a workqueue is used to process the tx packet, > which might cause the driver to process the EAPOL packet later than > nl80211_new_key(). As a result, the EAPOL 4/4 packet is dropped by mac80211 > due to the rekey configuration being finished. The EAPOL packets belongs to > VO packets that need high priority. Therefore, we process VO packets > directly without workqueue to ensure that packets can process immediately. > > VO is normally used by voice application that is low traffic load and low > latency, that doesn't affect user experience. > We test iperf with VO packets(iperf3 -P4 -u -b 10000M -S 0xdf) > before after > TX throughput 162M 162M > ping RTT 3.8ms 3.7ms > > Signed-off-by: Chih-Kang Chang > Signed-off-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 67d7f24b194e wifi: rtw88: process VO packets without workqueue to avoid PTK rekey failed -- https://patchwork.kernel.org/project/linux-wireless/patch/20230616031713.16769-1-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches