Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33d80292-e639-91d0-4d0f-3ed973f89e14@amd.com>
Date:   Wed, 21 Jun 2023 12:08:33 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF
 mitigations
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Johannes Berg <johannes@sipsolutions.net>,
        Evan Quan <evan.quan@amd.com>, rafael@kernel.org,
        lenb@kernel.org, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, mdaenzer@redhat.com,
        maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
        hdegoede@redhat.com, jingyuwang_vip@163.com, lijo.lazar@amd.com,
        jim.cromie@gmail.com, bellosilicio@gmail.com,
        andrealmeid@igalia.com, trix@redhat.com, jsg@jsg.id.au,
        arnd@arndb.de, linux-kernel@vger.kernel.org,
        linux-acpi@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org
References: <20230621054603.1262299-1-evan.quan@amd.com>
 <20230621054603.1262299-2-evan.quan@amd.com>
 <3a7c8ffa-de43-4795-ae76-5cd9b00c52b5@lunn.ch>
 <216f3c5aa1299100a0009ddf4e95b019855a32be.camel@sipsolutions.net>
 <b1abec47-04df-4481-d680-43c5ff3cbb48@amd.com>
 <36902dda-9e51-41b3-b5fc-c641edf6f1fb@lunn.ch>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <36902dda-9e51-41b3-b5fc-c641edf6f1fb@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUVkeHBBWm9kWEVqRGdFRnZMQWtQZHRXS0M5WVRBOTVqSFg2cHNyZ1JLQk9K?=
 =?utf-8?B?WjFwclc3R1RNQi9uM01tNVg4L1pSQ1NKNXd4djV3YkpZSHd1QmFEZUltUlJE?=
 =?utf-8?B?NXRmV1NGMWMzdWRnYnorQnNCaXUzS1FiTjZFSC9ZTFJDNkZCUDJWU3VTRndR?=
 =?utf-8?B?bEdYcGxKNVUyVk1wR2pnY0JNZ2tCOGpDdytCMjFjOUd5SU1CY1oybGZZcXgx?=
 =?utf-8?B?Y1QwM2k5WU9mZHJBNEpWQmd3VDY5Wk1wTU84QVdDMUdVcjg5amNNeFhCeEw0?=
 =?utf-8?B?aW1sc1hTWlNJbmRLOTZjYjd3VkFsRVhtT3ZPVDdmWFhRTUcwbW5tc0V5clNT?=
 =?utf-8?B?MmZTejhoUldLblhSL0lrSGVMUlowdWl3cFE4Q0tTbmFlR0ZKRzVMR2N5THNr?=
 =?utf-8?B?d29kRkFxWlhpMWRHUkIzRjdsTmJsNTI4NlMzZ0UvYU1HVG9mRERaQlE0QzhN?=
 =?utf-8?B?YlF5NEtYV1A4RmtXTk5ZTjFnUUlpSXpmUi9pV1N2U1YvK2FJRTl4M1BpQWJ2?=
 =?utf-8?B?bnl1aUFraDZZRWI5L3FxYnF2TUV0U0liV1h3VVpNWjByNC9FWlV1djI2OXVB?=
 =?utf-8?B?Nkc4ajVpd09tYjllTjhBMzBPemlLb1BMOHpCZUNidkt1ZUtSYlRGbmhUU2NU?=
 =?utf-8?B?ZnlNdXY5czl1eVIwMzRObzhnUmwyZ0tNMXlpUnk5ejlzVG1tRlZLQnFoMmIw?=
 =?utf-8?B?V3FQNDRhZWkza1A4QUMvODFCOUJ5VER5ekx5c1AvczViTzl0SlhBQzNHMWhM?=
 =?utf-8?B?UUYzVW5LS1dxRG1ldEVtaS85Z3hJQkhpUTFoMmwwY1BFUTBIaTVsQlhONi9F?=
 =?utf-8?B?YVBUV0Y1SUJoajV0bVA2UmpiVzNsVnJTQzZXSVNsaHhjWSs2b01qQ2E2U2pv?=
 =?utf-8?B?RlRXMkdqVGtDVE02WTk5aDF6dGNSc2pQVjNPSE4vUXhrSGd4ejdWdUZOdVJk?=
 =?utf-8?B?eGw4aklMMVM3VHpwbWhYT3NkUkkvejJ3VEE2QlRFMngyazk4M1RucDVnRG9C?=
 =?utf-8?B?Q29QMUF1RmFnTHA1Y0RLS0gvWTZoZnVaV1BQdzF2c2RlWm5CR1ZSOGlqTnNr?=
 =?utf-8?B?bytvbk5wMGtwRjVJUG9pcG56aWhsSG1uWktBaTQrdjd4bEFSVlMrRHU1RW1P?=
 =?utf-8?B?Sm4yS29lQVRSbkZ6TzRNTEMrYitWOGhhTUFpUUlZcUFTaDgxMGE2Y1RlUU5w?=
 =?utf-8?B?VU5sY3JQRHNJR3E4UWtjSTZuaFpVNVBSeDE0RmdBRWNwOUI3ZjdpbkRDTlE2?=
 =?utf-8?B?SHc3QmJCS1ZoQXQxTEFqMTNBZVJFSG12ZzExYzRxVUZJMXJndnorMlBDRTJK?=
 =?utf-8?B?SnFUNDRUbGpiMnc2Z0c4Yk1BcFV2WDRPbzZicUppQVRHNzVEK0VhT056MlZY?=
 =?utf-8?B?THFsb2lsN1NJcGJCc2NLRFlXbG5qaG1OR0puR045ZkF0dkF5NzhjWGhoeU50?=
 =?utf-8?B?RzJua3pNaGRXZmJMQjd0WFFGbVpLQVV3SndFM3Vabm9CdC9GNm9yMzd0T1pO?=
 =?utf-8?B?NUFBWGpXODNxZm1UTG1uYmxaOERxbEVYUzRzNlpaVk9tdjRBb043Nkc5b2Jq?=
 =?utf-8?B?QVpkeHI3RTFGM1lNNnpMYU13WEt5OXdHNFZia2t4K3hwM1BsR3dlN2pWVDNT?=
 =?utf-8?B?V1BMbHRQOHhXQnVudFM5WmFYdmhCenA3MWxhRXU5ODIxWld6MUIyK3JoM2Yw?=
 =?utf-8?B?VFdmTWpBRWJLOU81a2ZnUGRhVGdDQUxMK0hpMWg5RUs3dFFjbE5zUEhHUkdO?=
 =?utf-8?B?VGZUR294em0xQ09zTzcxazJZL05rNDRjNmNabk9GNW1EVEpqR1BoYXMxKzhu?=
 =?utf-8?B?bE1aek9OeUpjZTVESGpvQUEwRnlGWGY3UW9sZlZCb3JESE13ZG15bzV4azlD?=
 =?utf-8?B?VUh6SmZIVXFsMDNVeG9la3FzZ2pJZXNHQ3BIWUl5cWNabEpZYkZSUnh1d1Jp?=
 =?utf-8?B?YTNEdDhwU1Zud2MyVThvSWN0aDdFZDVkR1AzSDRZaWswVjRhKzEyd2NYamVG?=
 =?utf-8?B?N0FRSjdTR0YrUTZFZllMcHBYeXZuRXhnTndNV1UvaFpWL0k4OU9UZmxFUFg3?=
 =?utf-8?B?TVE2aHZ4b1VCNVphQXhiOVR2ZVhsN3lDYWJyWW9FN2dvVHJPNUNxSkJ6cFRO?=
 =?utf-8?Q?K5Hlxc/XGyGtBsMq5N+OG7xlN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dab95048-8de4-4020-ecc2-08db727a2748
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 17:08:37.5273
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2FBWPmZUh1kT+RCT90pFbIwQWqF4hjf+rDulOmBg3YIdiqG4cqS67rLtk4q58mDW83BZHJbJUa3wRfawNBthhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6259
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 6/21/2023 11:52 AM, Andrew Lunn wrote:
> On Wed, Jun 21, 2023 at 11:15:00AM -0500, Limonciello, Mario wrote:
>> On 6/21/2023 10:39 AM, Johannes Berg wrote:
>>> On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote:
>>>> On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote:
>>>>> From: Mario Limonciello <mario.limonciello@amd.com>
>>>>>
>>>>> Due to electrical and mechanical constraints in certain platform designs
>>>>> there may be likely interference of relatively high-powered harmonics of
>>>>> the (G-)DDR memory clocks with local radio module frequency bands used
>>>>> by Wifi 6/6e/7.
>>>>>
>>>>> To mitigate this, AMD has introduced an ACPI based mechanism that
>>>>> devices can use to notify active use of particular frequencies so
>>>>> that devices can make relative internal adjustments as necessary
>>>>> to avoid this resonance.
>>>> Do only ACPI based systems have:
>>>>
>>>>      interference of relatively high-powered harmonics of the (G-)DDR
>>>>      memory clocks with local radio module frequency bands used by
>>>>      Wifi 6/6e/7."
>>>>
>>>> Could Device Tree based systems not experience this problem?
>>> They could, of course, but they'd need some other driver to change
>>> _something_ in the system? I don't even know what this is doing
>>> precisely under the hood in the ACPI BIOS, perhaps it adjusts the DDR
>>> memory clock frequency in response to WiFi using a frequency that will
>>> cause interference with harmonics.
>> The way that WBRF has been architected, it's intended to be able
>> to scale to any type of device pair that has harmonic issues.
> So you set out to make something generic...
>
>> In the first use (Wifi 6e + specific AMD dGPUs) that matches this
>> series BIOS has the following purposes:
>>
>> 1) The existence of _DSM indicates that the system may not have
>> adequate shielding and should be using these mitigations.
>>
>> 2) Notification mechanism of frequency use.
>>
>> For the first problematic devices we *could* have done notifications
>> entirely in native Linux kernel code with notifier chains.
>> However that still means you need a hint from the platform that the
>> functionality is needed like a _DSD bit.
>>
>> It's also done this way so that AML could do some of the notifications
>> directly to applicable devices in the future without needing "consumer"
>> driver participation.
> And then tie is very closely to ACPI.
>
> Now, you are AMD, i get that ACPI is what you have. But i think as
> kernel Maintainers, we need to consider that ACPI is not the only
> thing used. Do we want the APIs to be agnostic? I think APIs used by
> drivers should be agnostic.
>
>        Andrew
I think what you're asking for is another layer of indirection
like CONFIG_WBRF in addition to CONFIG_ACPI_WBRF.

Producers would call functions like wbrf_supported_producer()
where the source file is not guarded behind CONFIG_ACPI_WBRF,
but instead by CONFIG_WBRF and locally use CONFIG_ACPI_WBRF within
it.  So a producer could look like this:

bool wbrf_supported_producer(struct device *dev)
{
#ifdef CONFIG_ACPI_WBRF
     struct acpi_device *adev = ACPI_COMPANION(dev);

     if (adev)
         return check_acpi_wbrf(adev->handle,
                        WBRF_REVISION,
                        1ULL << WBRF_RECORD);
#endif
     return -ENODEV;

}
EXPORT_SYMBOL_GPL(wbrf_supported_producer);

And then adding/removing could look something like this

int wbrf_add_exclusion(struct device *dev,
                struct wbrf_ranges_in *in)
{
#ifdef CONFIG_ACPI_WBRF
     struct acpi_device *adev = ACPI_COMPANION(dev);

     if (adev)
         return wbrf_record(adev, WBRF_RECORD_ADD, in);
#endif
     return -ENODEV;
}
EXPORT_SYMBOL_GPL(wbrf_add_exclusion);

int wbrf_remove_exclusion(struct device *dev,
                struct wbrf_ranges_in *in)
{
#ifdef CONFIG_ACPI_WBRF
     struct acpi_device *adev = ACPI_COMPANION(dev);

     if (adev)
         return wbrf_record(adev, WBRF_RECORD_REMOVE, in);
#endif
     return -ENODEV;
}
EXPORT_SYMBOL_GPL(wbrf_remove_exclusion);

This would allow anyone interested in making a non-ACPI implementation
be able to slide it into those functions.

How does that sound?