Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <07ad6860-8ffb-cc6c-a8e5-e8dc4db4e87a@amd.com>
Date:   Wed, 21 Jun 2023 13:50:34 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF
 mitigations
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Johannes Berg <johannes@sipsolutions.net>,
        Evan Quan <evan.quan@amd.com>, rafael@kernel.org,
        lenb@kernel.org, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, mdaenzer@redhat.com,
        maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
        hdegoede@redhat.com, jingyuwang_vip@163.com, lijo.lazar@amd.com,
        jim.cromie@gmail.com, bellosilicio@gmail.com,
        andrealmeid@igalia.com, trix@redhat.com, jsg@jsg.id.au,
        arnd@arndb.de, linux-kernel@vger.kernel.org,
        linux-acpi@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org
References: <20230621054603.1262299-1-evan.quan@amd.com>
 <20230621054603.1262299-2-evan.quan@amd.com>
 <3a7c8ffa-de43-4795-ae76-5cd9b00c52b5@lunn.ch>
 <216f3c5aa1299100a0009ddf4e95b019855a32be.camel@sipsolutions.net>
 <b1abec47-04df-4481-d680-43c5ff3cbb48@amd.com>
 <36902dda-9e51-41b3-b5fc-c641edf6f1fb@lunn.ch>
 <33d80292-e639-91d0-4d0f-3ed973f89e14@amd.com>
 <9159c3a5-390f-4403-854d-9b5e87b58d8c@lunn.ch>
 <a80c215a-c1d9-4c76-d4a8-9b5fd320a2b1@amd.com>
 <8d3340de-34f6-47ad-8024-f6f5ecd9c4bb@lunn.ch>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <8d3340de-34f6-47ad-8024-f6f5ecd9c4bb@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXJDVHd3WDFCaU9qaEEyVEl1UG5tbEZCN2dudHBtVlRGN3dTN1RDVUNZenJn?=
 =?utf-8?B?ZzE2dlhuWms4cU9oM2hTQXVuSWxSUVhCTW9JRkM5NmxhV2t2cDB6bDdTY0FX?=
 =?utf-8?B?UkxFNHZNbzBzd2hPR2lHVkV2T3ZPcUxjdXNkamZwZWNiV3o2QnIzRStWbkJW?=
 =?utf-8?B?MFcwdXNmcUc5SktSd0R2ZUd0UmoybHNFVkM4eCtsRCtXbTlZZHVtNGhXYWYy?=
 =?utf-8?B?V2l5YnlPM0wrK0FGOFNmOVBwdlVBN1ZVZ3FPQ1lGR29XMW1jalVBTG1oempX?=
 =?utf-8?B?TGlzeFV4cFhvMjI4VnNNbzNnK3lPY2xzYzlTYWJUUy9KOFVjRU14SkZYemd6?=
 =?utf-8?B?ZzhQcXJmckRsRlc0aWRYTGJ1ei9vZDlLVitEcjA1RHR5Zzh5djM3NDZGajRW?=
 =?utf-8?B?K0t0MEwrREUzR3lDcmx5R2liNTJuckc0cUNEMGluTWtrZSs1UERlQWtLN3Vp?=
 =?utf-8?B?MlJMK3BpSlVDVGZ4NlFma3BiTW9FTkEwUXJnK0VvMHh4U01pYXpaSkVLcGlH?=
 =?utf-8?B?Vkx1Yk5ldlY1NThHRGIraTUzZU41MnFTUkh2aURtS1FDaGJJSVd4cjZ0T0RV?=
 =?utf-8?B?SGozZEZKQ2Z6UXg4SUVuUGlsWGJuRExkZ1VuMno1K0dKUXMxaWFFMTNYdm5L?=
 =?utf-8?B?WFVlVXdWbFJtMWVsaENKbHdLOG5pdk91TE5Ma091ZWNRdTV6WFFnR0pJVVRp?=
 =?utf-8?B?bUk3byt2YXZOQW1RWFQ1bnhrUGQ2dkllbFBBQTlLYnEwNHdvR05EN3V3WVFY?=
 =?utf-8?B?YWV0dVQvaWZxL1MvMVVRZi9XYlRoQ2QzYVlLQytuajRLUDR6dWNnYUM4SzJn?=
 =?utf-8?B?TVRKOVJLSkVEZTVUMk1Sc3FTTXlsWWNOWk1WOTl1NTg4NFMvQWpDTytCRUQ2?=
 =?utf-8?B?VDAzR04rQ1lFK3ptUTdJbUx4MFIvQzNHWUZCdng4bXN6bEl1QkkvR0R2QnZG?=
 =?utf-8?B?aGNFYXNiS0dEc0VJSTArZnlOUEl0SFJzNzhhMlY1VUlQVlFXeStwdnBhSXNL?=
 =?utf-8?B?ck5vSzVURzlaK1E4ZmZtWEZCdXdvKzdYWWtMSnlwNTUzTEl1NmlSZGxRY2N5?=
 =?utf-8?B?Y1hzd2E0Rm1UUWJUTzlMZTc4VkEwUmNlZEplNnFtMWJQNUY3SDZmV0R5OWZm?=
 =?utf-8?B?RGt3SmlzM2JBeUxaZW92VFNETTArdmg3MWNUQWQwS2ZZdC9qaXQ2azRMeHda?=
 =?utf-8?B?SnI0OU1keUM3L3hCQU8zQVR3UEJtVWphdm83YlRvQWNXYndMekJ1alVrb1RI?=
 =?utf-8?B?am5TSC9SaUZ2ODFtaTVhcFFYYUtTbUh1MWU2dGlHSWVsM1M5Y3ljeWtBZXdU?=
 =?utf-8?B?dDdpd0R1aTZMZG1jc3N3Y1RkcCtyRElMV2lJSE9QcXg2OEZlSzY2OG5RL00z?=
 =?utf-8?B?Y0t4TzNZZ3NvNVFpVXprYlBpT2VadGtmLzRxU0M5Q2FvZUtuU29TY2NrN2hp?=
 =?utf-8?B?L3VyVys4SGorbzFHTG55bkFKSjBCL2gyVHlMOERZWDdBSVVCSFF5eEpUWGxy?=
 =?utf-8?B?MXJSVWlpd3lrUGJTR0JWUUJqeWxPZjZidVFCYVQyd00rNi9HMUc0UXZYNjd5?=
 =?utf-8?B?K1NPMW9iclRqV0VFSmQ1YVdHT1N6UkRybWtOWm14NGViKzIvd0VMdGFpRUJG?=
 =?utf-8?B?WElIdnFKRnlrZlZNTm1RNCt5dDdINXpkVC8zbGswOXVpWU4vcmdZN3JjeTBN?=
 =?utf-8?B?U2ZQdmFtSkZLYWVpOE9sTXZBQk1WR2RBSUdXeUlpdlRGbmlkdk1yNFZoZDFF?=
 =?utf-8?B?NzBNK2lJYVVTTVV0OFdXc1lnNTVqN0U2a1dzc0haYm15dUNEQU1xY3JabW85?=
 =?utf-8?B?QUpUeExTVGtmZ3RVWW1HbW53QUZLRHFxbmJuaTV4QlRabll1RG5ld2tJUjdk?=
 =?utf-8?B?TWU1SExhQmhMM2twb0VEYTdQWVc0OTRQUXdocEhDRExXM0tYWFVZMXBSME9X?=
 =?utf-8?B?QVNpM016ZHN6WGM5K1daNFFLbEVJeC9EQzNQMG9HaklyeE5KVHVQU1Y3YTlL?=
 =?utf-8?B?cG5rclRvWVRtcnJ1NnQ5ckcyUmYrV3JlTEhaK1AzZjRkR0plcllwNU5qb1ht?=
 =?utf-8?B?bVBBRVdNRVZHV2RBLzBiNy9xbDJlMGNIT2x4Uk9scFBndmZhU25VVEM4TEk4?=
 =?utf-8?Q?8hW+xY8WEQ2tPOeGdihVZ5ALz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4fa8b6f-5b7e-4cb7-b909-08db72886811
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 18:50:39.1870
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1A3uIbhd/5+NY3IdInUvZx1BeSVfucusEti98y3ow+2styoHtgn7d18PSeYjfsQLMijr1SLgd7jy1OR5qecGjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5622
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

So if we go down this path of CONFIG_WBRF and CONFIG_WBRF_ACPI, another
question would be where should the new "wbrf.c" be stored?  The ACPI only
version most certainly made sense in drivers/acpi/wbrf.c, but a generic
version that only has an ACPI implementation right now not so much.

On 6/21/2023 1:30 PM, Andrew Lunn wrote:
>> And consumer would need to call it, but only if CONFIG_WBRF_ACPI isn't set.
> Why? How is ACPI special that it does not need notifiers?
ACPI core does has notifiers that are used, but they don't work the same.
If you look at patch 4, you'll see amdgpu registers and unregisters using
both

acpi_install_notify_handler()
and
acpi_remove_notify_handler()

If we supported both ACPI notifications and non-ACPI notifications
all consumers would have to have support to register and use both types.

>
>> I don't see why it couldn't be a DT/ACPI hybrid solution for ARM64.
> As said somewhere else, nobody does hybrid. In fact, turn it
> around. Why not implement all this in DT, and make X86 hybrid? That
> will make arm, powerpc, risc-v and mips much simpler :-)
>
> 	Andrew
Doesn't coreboot do something hybrid with device tree?  I thought they
generate their ACPI tables from a combination of DT and some static ASL.