Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <954b5c26-9f98-a45d-605f-ea7a5072f2e1@nbd.name>
Date:   Thu, 22 Jun 2023 17:29:17 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH v3 04/10] wifi: mt76: mt7996: init he and eht cap for
 AP_VLAN
To:     Shayne Chen <shayne.chen@mediatek.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        Bo Jiao <Bo.Jiao@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>,
        Peter Chiu <chui-hao.chiu@mediatek.com>
References: <20230605152141.17434-1-shayne.chen@mediatek.com>
 <20230605152141.17434-4-shayne.chen@mediatek.com>
Content-Language: en-US
From:   Felix Fietkau <nbd@nbd.name>
In-Reply-To: <20230605152141.17434-4-shayne.chen@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05.06.23 17:21, Shayne Chen wrote:
> From: Peter Chiu <chui-hao.chiu@mediatek.com>
> 
> Init he and eht capabilities for AP_VLAN type. Without this patch, the
> BA response from AP_VLAN will not include the ADDBA extension tag.
If that's the case, then I think this is something that needs to be 
fixed in mac80211 instead. Since interfaces with the AP_VLAN iftype are 
not exposed to the driver, I don't see why the driver should register 
capabilities for that type.

- Felix