Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <adf8c1b8ea96c0c6ddc12579eacb8d9948440dcf.camel@sipsolutions.net>
Subject: Re: [PATCH] cfg80211: fix sband iftype data lookup for AP_VLAN
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Date:   Thu, 22 Jun 2023 18:07:24 +0200
In-Reply-To: <20230622160501.40666-1-nbd@nbd.name>
References: <20230622160501.40666-1-nbd@nbd.name>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-06-22 at 18:05 +0200, Felix Fietkau wrote:
> Since AP_VLAN interfaces are not pushed to the driver,=C2=A0
>=20
That's a mac80211 thing though.

> the driver should not
> be expected to register iftype data for them.
> Map them to the regular AP iftype on lookup.

And this is in cfg80211 - not sure that seems right?

OTOH I'd expect no callers with VLAN here, it doesn't really make sense
since they're not a standalone mode that actually has HE/EHT, but still,
seems odd this way?

What's actually calling it? I'm guessing somewhere in mac80211?

johannes