Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230627012129.4066-1-youkangren@vivo.com>
In-Reply-To: <20230627012129.4066-1-youkangren@vivo.com>
From:   Julian Calaby <julian.calaby@gmail.com>
Date:   Tue, 27 Jun 2023 11:30:14 +1000
Message-ID: <CAGRGNgW7oVdbriG2uTQt0hbJLErXQ4JAX8aWo9Hv7A5idadHEg@mail.gmail.com>
Subject: Re: [PATCH v2] wifi: ray_cs: Replace the ternary conditional operator
 with min()
To:     You Kangren <youkangren@vivo.com>
Cc:     Kalle Valo <kvalo@kernel.org>, Dongliang Mu <dzm91@hust.edu.cn>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Simon Horman <simon.horman@corigine.com>,
        "open list:RAYLINK/WEBGEAR 802.11 WIRELESS LAN DRIVER" 
        <linux-wireless@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi You,

On Tue, Jun 27, 2023 at 11:24=E2=80=AFAM You Kangren <youkangren@vivo.com> =
wrote:
>
> Replace the ternary conditional operator with min_t() to simplify the cod=
e
>
> Signed-off-by: You Kangren <youkangren@vivo.com>
> ---
>  drivers/net/wireless/legacy/ray_cs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/legacy/ray_cs.c b/drivers/net/wireless/=
legacy/ray_cs.c
> index 8ace797ce951..5f97fcf5c4ba 100644
> --- a/drivers/net/wireless/legacy/ray_cs.c
> +++ b/drivers/net/wireless/legacy/ray_cs.c
> @@ -2086,8 +2086,7 @@ static void ray_rx(struct net_device *dev, ray_dev_=
t *local,
>                         rx_data(dev, prcs, pkt_addr, rx_len);
>
>                 copy_from_rx_buff(local, (UCHAR *) &local->last_bcn, pkt_=
addr,
> -                                 rx_len < sizeof(struct beacon_rx) ?
> -                                 rx_len : sizeof(struct beacon_rx));
> +                                 min_t(rx_len < sizeof(struct beacon_rx)=
));

This is obviously bogus, did you compile this before posting it?

Thanks,

--=20
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/