Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230626102752.1583-1-youkangren@vivo.com> <CAGRGNgW_eeM2h7JBe98asaYjnF8hwAr50n8dfSabeK2H0u4=Qg@mail.gmail.com>
 <PUZPR06MB59369ADE01FB04AD9A7279A9AA27A@PUZPR06MB5936.apcprd06.prod.outlook.com>
In-Reply-To: <PUZPR06MB59369ADE01FB04AD9A7279A9AA27A@PUZPR06MB5936.apcprd06.prod.outlook.com>
From:   Julian Calaby <julian.calaby@gmail.com>
Date:   Tue, 27 Jun 2023 22:58:58 +1000
Message-ID: <CAGRGNgV=aNXvVZ8QkxE8R3Lr7edm6BPZ3adi5E23QeFO-q7nRw@mail.gmail.com>
Subject: Re: [PATCH] wifi: ray_cs: Remove invalid conditional statements
To:     =?UTF-8?B?5bCk5bq35LuB?= <youkangren@vivo.com>
Cc:     Kalle Valo <kvalo@kernel.org>, Dongliang Mu <dzm91@hust.edu.cn>,
        Simon Horman <simon.horman@corigine.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "open list:RAYLINK/WEBGEAR 802.11 WIRELESS LAN DRIVER" 
        <linux-wireless@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "opensource.kernel" <opensource.kernel@vivo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Tue, Jun 27, 2023 at 10:44=E2=80=AFPM =E5=B0=A4=E5=BA=B7=E4=BB=81 <youka=
ngren@vivo.com> wrote:
>
> Dear Julian,
>
>     I found a warning at compiling time that the if and else branches had=
 no effect here. I looked at the code and found that the contents of both b=
ranches were the same, so I merged the contents of both branches into one a=
nd committed the changes.

That's great, but it needs to be in the commit message.

Thanks,

--=20
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/