Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3e7faf02-2724-9d27-364e-eedcd5fc5567@yandex.ru>
Date:   Wed, 28 Jun 2023 07:54:22 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] wifi: plfxlc: Fix possible data races in
 rx_urb_complete()
To:     Tuo Li <islituo@gmail.com>, srini.raju@purelifi.com,
        kvalo@kernel.org
Cc:     linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
        baijiaju1990@outlook.com, BassCheck <bass@buaa.edu.cn>
References: <20230628022121.1010517-1-islituo@gmail.com>
Content-Language: en-US
From:   Dmitry Antipov <dmantipov@yandex.ru>
In-Reply-To: <20230628022121.1010517-1-islituo@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/28/23 05:21, Tuo Li wrote:

>   		if (tx->submitted_urbs++ < PURELIFI_URB_RETRY_MAX) {
>   			dev_dbg(plfxlc_urb_dev(urb), "urb %p resubmit %d", urb,
>   				tx->submitted_urbs++);

BTW, doing 'tx->submitted_urbs++' inside a debugging statement is most likely
a bad idea.

Dmitry