Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Jun 2023 22:05:47 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     You Kangren <youkangren@vivo.com>
Cc:     Kalle Valo <kvalo@kernel.org>, Dongliang Mu <dzm91@hust.edu.cn>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "open list:RAYLINK/WEBGEAR 802.11 WIRELESS LAN DRIVER" 
        <linux-wireless@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        opensource.kernel@vivo.com
Subject: Re: [PATCH v3] wifi: ray_cs: Replace the ternary conditional
 operator with min()
Message-ID: <ZJ3kG7CSWSGw1Ql2@corigine.com>
References: <20230627043151.19576-1-youkangren@vivo.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230627043151.19576-1-youkangren@vivo.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?90MoqDgUhpj3w2dChPR4BXNQxd/iusA/cSU7KHWD7P3Lj8v1QxNc01BJ7I1B?=
 =?us-ascii?Q?PGtgPd2NpVroiSUM8EBh5UUUxkBoJyehaw68IptryAA8WjFhhvaGXxS3Pv60?=
 =?us-ascii?Q?ja/eQqQFZrKNlIEUwp5/D+cYRtX7Kkqe52QoBNPpBQ3QGohZaUvJIOVjdftn?=
 =?us-ascii?Q?PXkxnqzrpGKgs/fK6IxksFtlwGk4EAA0TgPM77WBRDYoC9iFj4FUm/DuKsju?=
 =?us-ascii?Q?FzSKfU+nMN0qT3fdlfkHCf2S8/eJf4Ys9OHXODQDyMfELew3WUjLoDA18kb5?=
 =?us-ascii?Q?YRAkovRFaXrdT4NlGqTdu+TYiHRwJODf/NNvy5NUq5yLkcj+9GUvbGzwuh0e?=
 =?us-ascii?Q?oAUW4d7RLBcZj8tT6AVI9svfAo0MeJKlDdkabPh8AsACspefxGRfjO3xD0S9?=
 =?us-ascii?Q?+G52F3+xxAUDeTUkQ/Tot7keAi9yMlYppx+2p7r3JODWI++Jz4OXf6zndH9z?=
 =?us-ascii?Q?FxQghLSM6VzL+x5oz3Y+kHs5p6jDyAUY7okx1hlH5ELPFjlxUxvQ6CdZaBWw?=
 =?us-ascii?Q?S3H6IWTA2EeUnuHzSe++K0d1gB5l3qnfLXJbndQqrsxaWE6Dz66QvW/MSSxU?=
 =?us-ascii?Q?gm2jJZ1eXyC4KGa/OrHbdfukxs7UkGNdfgeCnclV6cMw0jPQiHh3jLoZzdmR?=
 =?us-ascii?Q?zvHVzHbZKYaaxq6ui+OLgq6WpUY7s5a8WmH6FJC+ZIjMoNQwKdXOAvS0tZdB?=
 =?us-ascii?Q?ZP1wm+68axMIve1qQaOc6Lgqx2CgkthurPD2n7EFVKDyl0vhUmEZhPPRRTUB?=
 =?us-ascii?Q?jfX+15Nu1gihZMYoS3Aws41aDDgcx3JjcYV0H4tuIQe7+bGv/74yYfwx9Mee?=
 =?us-ascii?Q?hPmI6wkz231B2Ugn0vAMlVGueeghi0Nab9dtOxXlE8hX1hAoD3IJvAms2run?=
 =?us-ascii?Q?GAv1Fv+MDOYDlZcRDrD0lQQurTZSJgTJSnZB7mEpbzZv77fUnYPnStssBUDA?=
 =?us-ascii?Q?2KDHwwQEzT4XWZ9sBWvwkYL7OhlVKttle7zZwKN3P183+qY1BK+1fW1gYHAu?=
 =?us-ascii?Q?AArDXzcRidclX5O/NaV1vsTeCesGygWU7KW9CsToT7OsVOq9vIEUgUUjkCgU?=
 =?us-ascii?Q?6g/0Q0hjjlOrL/2Zb8GJkzBqeLEhgCCggoeLL0Q5UVBuzOU+EEqQ6DXmUYAk?=
 =?us-ascii?Q?YcmOsfqPbd7T6lK9OqqCdip+j1WqyHllME8eoPawWF/S4wBbjPXO8DXE5GGq?=
 =?us-ascii?Q?KVGaKJvPPUI6Z9jfe1MulJ3KY+0KwrCAMzJr0ZmlUfgKZQQRkRoDZP2rkr8q?=
 =?us-ascii?Q?0/b7+dABD0Xxm9jkf+wUhpYaA71DJn7vwBzWppqglcQjH10E0FDF4MvDus7U?=
 =?us-ascii?Q?KWyX4DL5mzY/ZNe+oQzw6H/OwYhu+YdQa+1YD5CGFSqGqYb8Gxkew2yupIf5?=
 =?us-ascii?Q?YhCfISfiFGDjiYA4QHECqnQuZjkJNVJDbGR3WMTUxN9L0K732PW87ojT5snw?=
 =?us-ascii?Q?qGP8WlWxJiAhy2lXdqRQrLL7pu0E4TZVk8Dqcfc/SXbSUIYiHw0VmnkNp5u+?=
 =?us-ascii?Q?zUmR4NOHYSQNHnadxDOnzsLxcOdujuKigQTRzIBXPJwqQ7yWZ9W5q6uXvlrK?=
 =?us-ascii?Q?ArWxImSSdrfd4WdzyaZLikHIyV9VTwfEX5a+UEZoKZuXSyK4hLvpT47cLwEf?=
 =?us-ascii?Q?wuKcdsAXeNAO1GyB/rwvCx42fhzpJ/F5RJgfEtAx8ykaJhTeCMygqli7U7BY?=
 =?us-ascii?Q?V58ZSA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef1fb1d6-260a-48cb-a302-08db78dc3dcd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 20:05:52.9060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ki2xG9gxuGSMA1A4q6k9M6ppUztA0EKO4YUENCHAxknHMdF2z+xKYUEpcDVOFeIWyvLgsno8ruqxN51/rESFh7DB1btNquo9RpWIkqZ9Yu8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5709
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tue, Jun 27, 2023 at 12:31:48PM +0800, You Kangren wrote:
> Replace the ternary conditional operator with min_t() to simplify the code
> 
> Signed-off-by: You Kangren <youkangren@vivo.com>
> ---
>  drivers/net/wireless/legacy/ray_cs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/legacy/ray_cs.c b/drivers/net/wireless/legacy/ray_cs.c
> index 8ace797ce951..25edbc655738 100644
> --- a/drivers/net/wireless/legacy/ray_cs.c
> +++ b/drivers/net/wireless/legacy/ray_cs.c
> @@ -2086,8 +2086,7 @@ static void ray_rx(struct net_device *dev, ray_dev_t *local,
>  			rx_data(dev, prcs, pkt_addr, rx_len);
>  
>  		copy_from_rx_buff(local, (UCHAR *) &local->last_bcn, pkt_addr,
> -				  rx_len < sizeof(struct beacon_rx) ?
> -				  rx_len : sizeof(struct beacon_rx));
> +				  min_t(size_t, rx_len, sizeof(struct beacon_rx));

Hi You Kangen,

unfortunately this patch doesn't seem to compile.