Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   You Kangren <youkangren@vivo.com>
To:     Johannes Berg <johannes@sipsolutions.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-wireless@vger.kernel.org (open list:MAC80211),
        netdev@vger.kernel.org (open list:NETWORKING [GENERAL]),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, youkangren@vivo.com
Subject: [PATCH v4] =?UTF-8?q?wifi=EF=BC=9Amac80211:=20Replace=20the=20ter?= =?UTF-8?q?nary=20conditional=20operator=20with=20conditional-statements?=
Date:   Mon,  3 Jul 2023 11:02:00 +0800
Message-Id: <20230703030200.1067-1-youkangren@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmtXOWREZ1FZZzZIV2loWkNxZkFxSklSaEdNQ3I2eXZMbFZzR2dtTVVZbHB5?=
 =?utf-8?B?MFU5UTdHYksyelZCa3pNMGNYSXJ5a2hSOFFCV01qa0NOeFd4RkpXMEdwWUo0?=
 =?utf-8?B?bUo2aUE0L3hHZzhQblhscXJqSWdCSzlGbnhkRjNEUFBSOVZRL1pnaTRaajh1?=
 =?utf-8?B?U014bTJoWTQ2S0ZYeGcwdTZEdWMwUnBhSjJDRGlQMGdCekNUQ0RMdGNDT1g3?=
 =?utf-8?B?eEZxODF6c2VoZlNtWGoxUTZldVBWVnFzZmNRNjJDWTFqQ09vVUY1bkkvZWJv?=
 =?utf-8?B?NnVhYVZzbTVUNVRXaGJoSnYrUWRjVFBRYmh5UTl1MGxCS2hGTC80ajNHcW9X?=
 =?utf-8?B?eGlNMzRlWTRhTlR6ZUdRb1IrckEvV1liUGlRdFNIbE9RQ3h5eDZRN0NDbmZM?=
 =?utf-8?B?N25RZnlwUUFLbFJ2cHM5bkIzb3ByclI3NFZEQnBidzhoR2kxejg1TEF4NmlT?=
 =?utf-8?B?WmFnRXNwQ0lSdDBTczlpakpmNzVpVkxSN1AzYUw5d01Yb0twTkttWUNBS2tw?=
 =?utf-8?B?YkQ0aUxFcWRlQU8rc0M4RFduQ0tRNm1iYTlFVjB4b3FhTXgyY29za1pmaCsv?=
 =?utf-8?B?WktuSFVLOXJXSmt1ODJKbk9xekg5RnZMWUQrWE5uYXgzdDdwQVRncTZzd3RC?=
 =?utf-8?B?OGdGaTJqVVNQYmNORmtmb3RaV2ZtbjVzdGF6eW8yK1Nucm9aSDVZZGp3cDk1?=
 =?utf-8?B?OWg2TXlocmRPdWlubHpVWVd5NnltdEZNc0wrRGxDWVJUK09vODdkNGdrWitV?=
 =?utf-8?B?V2pKbHpnK25OMk55eUt2T21KRkdCSlB0S21qZW5STWJPSW9tV3RCQzVkbUtG?=
 =?utf-8?B?QitJNVV4aU5PQ2NWQVBjYUVTQ3ExZjU3RXh3Z1I3SzhVb2xnOStxQkFacTl3?=
 =?utf-8?B?aGVOZlljTDR4YnZHTnF3amdPbkxrUzgzRG5YVUhVWTVxSSsxcUExL2swSlNM?=
 =?utf-8?B?dENUN1BkQVZmbFZFUUNlSWtPM25nY25mZVAvbFVLdkxwMXRITE9nL2g5djhB?=
 =?utf-8?B?UjJUeEZEb1lhaFIrSUJBUm5KdFJmY3EvTTBNMWc1cTJMcUNHLzRrZXl4dVlU?=
 =?utf-8?B?bnhnajVEYWZ3TTZDSGh4ZDYyQmRjUS9oMXdYSGhjUWVqUW9EbGxZSzdUNTRr?=
 =?utf-8?B?OU5nb1p6YmN2STNBNVR2UGM0bE1zOHJ2RC9wL0JYU0hVWEpITXhYM1Q3Skp1?=
 =?utf-8?B?emFZUmJUYlFnbXV4bVNIVUVZUVRVTDlqamdDS2pCZndSOUpRZkhPUjlSUVlv?=
 =?utf-8?B?a1psQnprWEFNSW1VelNad3BqUmgydU9OSUMxcHI0V2dJc0RhRDc3ek54MkZx?=
 =?utf-8?B?Mnc3eFR0WjJTbURIUEFNMmJzelJMbjc0bXhZWHlhWWx6V2tpQlNrMkVNZytY?=
 =?utf-8?B?YzFNUE1CSENoVjdQcThnTjVxbU54R280UWlEaHJnNlhVUXJReVVlSGRCb2My?=
 =?utf-8?B?cnN4elZtaWNCanFsM1VnYVp3dFJEQVR2cGpzeUIraW4xdVlwM3BhMk5aOVdv?=
 =?utf-8?B?NXY0dStzdmZURVRmaUtOdnhTcTUzU0NKcFUyT1NWQk0zOTVhNnZqVkZnUk5W?=
 =?utf-8?B?ekNYU2R6RkRzSVlrTzRTaEhQUXNrUjRKbXFwQUJRYWhVZGt4dEJNMzBWQWtW?=
 =?utf-8?B?Ui9BSVJpenZUNE5xZmRlTEIvM0JsR2RRWGNQRmRmbFdUa2JqeGhwVkl3bm8w?=
 =?utf-8?B?SWxyMEh5bEQrSitkNlI5S1VVQStUakNDQ2hnRW9paDd4VUtreGxaMDJiY2NK?=
 =?utf-8?B?dGtpbnd4Y2kveG9kcHZzaTZnZkhJRHlBQmh3NnZNR0lRL0JHQUZKdkNkUFhr?=
 =?utf-8?B?Qy9WdmhSczFGaEdxUm9FbFdGUjZ0bXdqWGtKVVUzZnBLQXhJdkxScUxJY290?=
 =?utf-8?B?ZGFVS3JncUI1MUovNVp4bC83R21ONTZSMXBaV0xJSHNwcUQ4OHFUL25CQ0Zw?=
 =?utf-8?B?aXN1MURGbEg3Rys1QU5Sd1ZxcjhoVC9tRndDeVU5UzFHcm5XWWJwOHNRNVc2?=
 =?utf-8?B?V2lURUlEUmh5V3ErU21ncHcrZCtYci8rb2k5SXFYR0FvYVNzeW4yMDNYemNK?=
 =?utf-8?B?aWlkYUM1RGlWZjhqd3luSmdZeE96U0JwQWo0dVFOenBIbDNrMSt1bDBBL2JB?=
 =?utf-8?Q?GYFJR+9XAvdT7g0GqJyEziisq?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1edd1555-5aec-4d7c-2b7b-08db7b71e2bc
X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5936.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 03:02:07.2589
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yNxC9aQgTK9YPn1e6vaKeU/4Zo7wjgWzvCz6Mj3jq6wQU15PrX5DoIP4WWzBjdhAqtDZ48PtctEGF1WCDvRD6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6231
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Replacing ternary conditional operators with conditional statements 
ensures proper expression of meaning while making it easier for 
the compiler to generate code.

Signed-off-by: You Kangren <youkangren@vivo.com>
---
 net/mac80211/tdls.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/mac80211/tdls.c b/net/mac80211/tdls.c
index a4af3b7675ef..41176491965d 100644
--- a/net/mac80211/tdls.c
+++ b/net/mac80211/tdls.c
@@ -946,7 +946,8 @@ ieee80211_tdls_build_mgmt_packet_data(struct ieee80211_sub_if_data *sdata,
 	int ret;
 	struct ieee80211_link_data *link;
 
-	link_id = link_id >= 0 ? link_id : 0;
+	if (link_id < 0)
+		link_id = 0;
 	rcu_read_lock();
 	link = rcu_dereference(sdata->link[link_id]);
 	if (WARN_ON(!link))
-- 
2.39.0