Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ff646259-8ce1-f1fe-4627-cdf99321dba8@leemhuis.info>
Date:   Fri, 7 Jul 2023 10:43:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: Linux-6.5 iwlwifi crash
Content-Language: en-US, de-DE
To:     Jeff Chua <jeff.chua.linux@gmail.com>,
        Larry Finger <Larry.Finger@lwfinger.net>
Cc:     Linux regressions mailing list <regressions@lists.linux.dev>,
        lkml <linux-kernel@vger.kernel.org>,
        Gregory Greenman <gregory.greenman@intel.com>,
        Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Linux Wireless <linux-wireless@vger.kernel.org>,
        Linux Networking <netdev@vger.kernel.org>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Johannes Berg <johannes.berg@intel.com>
References: <20230429020951.082353595@lindbergh.monkeyblade.net>
 <CAAJw_ZueYAHQtM++4259TXcxQ_btcRQKiX93u85WEs2b2p19wA@mail.gmail.com>
 <ZE0kndhsXNBIb1g7@debian.me> <b9ab37d2-42bf-cc31-a2c0-a9b604e95530@gmail.com>
 <CAAJw_Zug6VCS5ZqTWaFSr9sd85k=tyPm9DEE+mV=AKoECZM+sQ@mail.gmail.com>
 <7fee3284-b9ba-58f4-8118-fe0b99ae6bf7@leemhuis.info>
 <CAAJw_Zu=MPtGPARgCB2fteP+7F793YDFXE9RuzSH8EqYBS-OOw@mail.gmail.com>
 <64b8732f-6319-9f10-b82a-b4a3dd8d4b8e@lwfinger.net>
 <CAAJw_ZvZNQzrFyQizJnKe5PerqqAUOmPYd6cnjAcvs68xNdwSA@mail.gmail.com>
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@leemhuis.info>
Reply-To: Linux regressions mailing list <regressions@lists.linux.dev>
In-Reply-To: <CAAJw_ZvZNQzrFyQizJnKe5PerqqAUOmPYd6cnjAcvs68xNdwSA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
for once, to make this easily accessible to everyone.

Jeff, thx for bisecting. Johannes afaik is unavailable for a while
(CCing him nevertheless), hence:

Gregory, could you please take a look at this? And maybe provide a few
hints for Jeff how to generate more data that allows us to find the root
of the problem?

Jeff, btw, the iwlwifi bug reporting guide (
https://wireless.wiki.kernel.org/en/users/drivers/iwlwifi/debugging
) says to file a bugs in http://bugzilla.kernel.org/ Might be wise to do
this in case Gregory is also unavailable, but instructed someone to keep
an eye on things there.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

On 07.07.23 03:56, Jeff Chua wrote:
> On Thu, Jul 6, 2023 at 2:11 AM Larry Finger <Larry.Finger@lwfinger.net> wrote:
> 
>> Fow what it is worth, my 6.4-git (6.5-rc0?) commit d528014517f2 (pulled today)
>> is working OK with iwlmvm. Lspci says my device is
>>
>> 04:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1]
>> (rev 73)
>>
>> I think you do need to do a bisection.
>> Larry
> 
> 
> Larry,
> 
> I did a bisect and here's what it came up with ... reverted the
> following and iwlwiifi worked again.
> 
> 
> 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2 is the first bad commit
> commit 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2
> Author: Johannes Berg <johannes.berg@intel.com>
> Date:   Wed Jun 21 13:12:07 2023 +0300
> 
>     wifi: iwlwifi: split 22000.c into multiple files
> 
>     Split the configuration list in 22000.c into four new files,
>     per new device family, so we don't have this huge unusable
>     file. Yes, this duplicates a few small things, but that's
>     still much better than what we have now.
> 
>     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>     Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
>     Link: https://lore.kernel.org/r/20230621130443.7543603b2ee7.Ia8dd54216d341ef1ddc0531f2c9aa30d30536a5d@changeid
>     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> 
>  drivers/net/wireless/intel/iwlwifi/Makefile     |   1 +
>  drivers/net/wireless/intel/iwlwifi/cfg/22000.c  | 939 +-----------------------
>  drivers/net/wireless/intel/iwlwifi/cfg/ax210.c  | 452 ++++++++++++
>  drivers/net/wireless/intel/iwlwifi/cfg/bz.c     | 523 +++++++++++++
>  drivers/net/wireless/intel/iwlwifi/cfg/sc.c     | 214 ++++++
>  drivers/net/wireless/intel/iwlwifi/iwl-config.h |   2 +
>  drivers/net/wireless/intel/iwlwifi/pcie/drv.c   |   3 +
>  7 files changed, 1206 insertions(+), 928 deletions(-)
>  create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/ax210.c
>  create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/bz.c
>  create mode 100644 drivers/net/wireless/intel/iwlwifi/cfg/sc.c
> 
> 
> My best.,
> Jeff
> 
>>
>>
> 
>