Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a4265090-d6b8-b185-a400-b09b27a347cc@leemhuis.info>
Date:   Fri, 7 Jul 2023 12:55:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [Regression][BISECTED] kernel boot hang after 19898ce9cf8a
 ("wifi: iwlwifi: split 22000.c into multiple files")
To:     "Zhang, Rui" <rui.zhang@intel.com>,
        "Greenman, Gregory" <gregory.greenman@intel.com>,
        "Berg, Johannes" <johannes.berg@intel.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Baruch, Yaara" <yaara.baruch@intel.com>,
        "Ben Ami, Golan" <golan.ben.ami@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Sisodiya, Mukesh" <mukesh.sisodiya@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Johannes Berg <johannes.berg@intel.com>,
        Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        netdev <netdev@vger.kernel.org>,
        Linux kernel regressions list <regressions@lists.linux.dev>,
        Jakub Kicinski <kuba@kernel.org>,
        Bagas Sanjaya <bagasdotme@gmail.com>
References: <b533071f38804247f06da9e52a04f15cce7a3836.camel@intel.com>
Content-Language: en-US, de-DE
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@leemhuis.info>
Reply-To: Linux regressions mailing list <regressions@lists.linux.dev>
In-Reply-To: <b533071f38804247f06da9e52a04f15cce7a3836.camel@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

[CCing the regression list, netdev, the net maintainers, and Linus;
Johannes and Kalle as well, but just for the record, they afaik are
unavailable]

Hi, Thorsten here, the Linux kernel's regression tracker.

On 07.07.23 10:25, Zhang, Rui wrote:
> 
> I run into a NULL pointer dereference and kernel boot hang after
> switching to latest upstream kernel, and git bisect shows that below
> commit is the first offending commit, and I have confirmed that commit
> 19898ce9cf8a has the issue while 19898ce9cf8a~1 does not.

FWIW, this is the fourth such report about this that I'm aware of.

The first is this one (with two affected users afaics):
https://bugzilla.kernel.org/show_bug.cgi?id=217622

The second is this one:
https://lore.kernel.org/all/CAAJw_Zug6VCS5ZqTWaFSr9sd85k%3DtyPm9DEE%2BmV%3DAKoECZM%2BsQ@mail.gmail.com/

The third:
https://lore.kernel.org/all/9274d9bd3d080a457649ff5addcc1726f08ef5b2.camel@xry111.site/

And in the past few days two people from Fedora land talked to me on IRC
with problems that in retrospective might be caused by this as well.

This many reports about a problem at this stage of the cycle makes me
suspect we'll see a lot more once -rc1 is out. That's why I raising the
awareness of this. Sadly a simple revert of just this commit is not
possible. :-/

Ciao, Thorsten

> commit 19898ce9cf8a33e0ac35cb4c7f68de297cc93cb2 (refs/bisect/bad)
> Author:     Johannes Berg <johannes.berg@intel.com>
> AuthorDate: Wed Jun 21 13:12:07 2023 +0300
> Commit:     Johannes Berg <johannes.berg@intel.com>
> CommitDate: Wed Jun 21 14:07:00 2023 +0200
> 
>     wifi: iwlwifi: split 22000.c into multiple files
>     
>     Split the configuration list in 22000.c into four new files,
>     per new device family, so we don't have this huge unusable
>     file. Yes, this duplicates a few small things, but that's
>     still much better than what we have now.
>     
>     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>     Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
>     Link:
> https://lore.kernel.org/r/20230621130443.7543603b2ee7.Ia8dd54216d341ef1ddc0531f2c9aa30d30536a5d@changeid
>     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> 
> I have some screenshots which show that RIP points to iwl_mem_free_skb,
> I can create a kernel bugzilla and attach the screenshots there if
> needed.
> 
> BTW, lspci output of the wifi device and git bisect log attached.
> 
> If any other information needed, please let me know.

--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.

P.S.: for regzbot

#regzbot ^introduced 19898ce9cf8a
#regzbot dup-of:
https://lore.kernel.org/all/a5cdc7f8-b340-d372-2971-0d24b01de217@gmail.com/