Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230709181323.12085-2-johannes@sipsolutions.net> <19f7bc7f43922c257238127d5fe84ea01cf2be79.camel@intel.com>
In-Reply-To: <19f7bc7f43922c257238127d5fe84ea01cf2be79.camel@intel.com>
From:   Jeff Chua <jeff.chua.linux@gmail.com>
Date:   Mon, 10 Jul 2023 18:16:17 +0800
Message-ID: <CAAJw_Zuo1L3yTP-PVgdW74uYg=R7YxXF0hA5s0Gfm1bCqC90RQ@mail.gmail.com>
Subject: Re: [RFC PATCH] wifi: iwlwifi: remove 'use_tfh' config to fix crash
To:     "Zhang, Rui" <rui.zhang@intel.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
        "Berg, Johannes" <johannes.berg@intel.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Gregory Greenman <gregory.greenman@intel.com>,
        Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Linux Networking <netdev@vger.kernel.org>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 10, 2023 at 9:53=E2=80=AFAM Zhang, Rui <rui.zhang@intel.com> wr=
ote:
>
> On Sun, 2023-07-09 at 20:13 +0200, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > This is equivalent to 'gen2', and it's confusing to have two
> > of the same configs. The split config patch actually had been
> > originally developed after this, and didn't add the use_tfh
> > in the new configs because they were copied to the new files
> > after ...
> >
> > There's clearly still an unwind error in iwl_txq_gen2_init()
> > since it crashes if something fails there, but the reason it
> > fails in the first place is due to the gen2/use_tfh confusion.
> >
> > Reported-by: Jeff Chua <jeff.chua.linux@gmail.com>
> > Reported-by: "Zhang, Rui" <rui.zhang@intel.com>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D217622
> > Link:
> > https://lore.kernel.org/all/9274d9bd3d080a457649ff5addcc1726f08ef5b2.ca=
mel@xry111.site/
> > Link:
> > https://lore.kernel.org/all/CAAJw_Zug6VCS5ZqTWaFSr9sd85k%3DtyPm9DEE%2Bm=
V%3DAKoECZM%2BsQ@mail.gmail.com/
> > Fixes: 19898ce9cf8a ("wifi: iwlwifi: split 22000.c into multiple
> > files")
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>
> Hi, Johannes,
>
> Thanks for the patch. It fixes the problem on my side.
>
> Tested-by: Zhang Rui <rui.zhang@intel.com>
>
> thanks,
> rui


Johannes,

Fixed as well! Thank you!

cc to those I've posted before as well.

Jeff