Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Arowa Suliman <arowa@chromium.org>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
        Arowa Suliman <arowa@google.com>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] wifi: ath11k: Add crash logging
References: <20230710230546.3544912-1-arowa@google.com>
Date:   Tue, 11 Jul 2023 09:40:53 +0300
In-Reply-To: <20230710230546.3544912-1-arowa@google.com> (Arowa Suliman's
        message of "Mon, 10 Jul 2023 16:04:53 -0700")
Message-ID: <87wmz77xxm.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Arowa Suliman <arowa@chromium.org> writes:

> Change crash logging from debug to informational and add warning when
> firmware crash MHI_CB_EE_RDDM happens.

Why? What's the reason why you want to change this? The commit log
should always describe that.

> Tested-on: Qualcomm WCN6855

This is not correct format:

https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag

> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202306141105.c1e82Q0y-lkp@intel.com/

The robot only reported problems with your patch, it didn't report the
original problem. So you should remove these two lines.

> Signed-off-by: Arowa Suliman <arowa@google.com>

From and s-o-b have different email addresses.

Also this seems to a second version of your patch so you should have
marked it as v2 and include a changelog what changed from v1.

Please read our documentation from the wiki link below how to submit
patches.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches