Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e5a92f9c-2d56-00fc-5e01-56e7df8dc1c1@suse.com>
Date:   Wed, 12 Jul 2023 11:22:17 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] USB: disable all RNDIS protocol drivers
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Enrico Mioso <mrkiko.rs@gmail.com>
Cc:     Jan Engelhardt <jengelh@inai.de>, linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Kalle Valo <kvalo@kernel.org>,
        Oleksij Rempel <linux@rempel-privat.de>,
        =?UTF-8?Q?Maciej_=c5=bbenczykowski?= <maze@google.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>,
        Jacopo Mondi <jacopo@jmondi.org>,
        =?UTF-8?Q?=c5=81ukasz_Stelmach?= <l.stelmach@samsung.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        linux-wireless@vger.kernel.org,
        Ilja Van Sprundel <ivansprundel@ioactive.com>,
        Joseph Tartaro <joseph.tartaro@ioactive.com>
References: <20221123124620.1387499-1-gregkh@linuxfoundation.org>
 <n9108s34-9rn0-3n8q-r3s5-51r9647331ns@vanv.qr> <ZKM5nbDnKnFZLOlY@rivendell>
 <2023070430-fragment-remember-2fdd@gregkh>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <2023070430-fragment-remember-2fdd@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0Rtei91ZnBBai9uRENkU1NWU09oSFZqS0dmMkMvSWdvMElibTVQNjhRL1RB?=
 =?utf-8?B?ZU5LbFBaWHlpRmNiWEkxZy9HVWw5dlR5RUhFOXFJcGVQdFlUeDRrRHc4ZVBX?=
 =?utf-8?B?bnN6MEdaWUdpUlh6YU55Zzh6Q3Z3TzFKUlEvVUpLc1V4dTNhTTU1OE1MdnAr?=
 =?utf-8?B?aTRySUlGMFRid1R5Mmh5elpPWkRBQStudXVHSkZXOHVpOUdnQWo1S05jV2VS?=
 =?utf-8?B?NkY3WUpsSWV1R01hcThGeTRVR1c2TUFxY04zcC9SRjVLclVXT2p5VjR4TG9G?=
 =?utf-8?B?TDRmS1BPakpHb09GZlg5K3RRR2lQTXoxNERTVCs3UGlqVlEzbmtzNlExQ3ln?=
 =?utf-8?B?cjIwaFVPS0g4WGtPK0dPVnNGOHVFaU9uczhpaFV5Q2U1b1ZhbWpKa3pzQWdq?=
 =?utf-8?B?bDNPbk53RVB3UlpMT21TYmh3Uk1TL1ErdW54cThvc1ptdEZ6N2thbkpIcGNR?=
 =?utf-8?B?T1dNUzlNNExtV1g5NmVXTmVFclpWZk1yV24vaENoZ245SXJXR0xnVG5RNzBK?=
 =?utf-8?B?UFBRYVVBMm1kSFB3RFVpMXB6N3djR25xcW8xb1hxWTdIOTF1SnEramhZejVy?=
 =?utf-8?B?bjBDNWhWTnk3T2kyZGZqcENBRllDZU85RWVGMGF2bUl3aDRLM0hHcEtidjhO?=
 =?utf-8?B?QWV4aXk5Zk9IVzVpYmh5S3F6bXE3bW1POE1vQUROZ2VDejRadlIvV0xHZ2lL?=
 =?utf-8?B?eldhQTlaR3VzV3pmMDNMNlVqMlJEVXZNa2dYcTVYbnhMZjhVbi9NaFhtbWpP?=
 =?utf-8?B?L1F0dHhxUkRiVzdQVE9kN2JneHRjN2pNTjJOa25nMzk1YVRacUtzRWRmUHVO?=
 =?utf-8?B?ZDlxRHJ4eU1WMlBxRlY0cnFQNERxOTJFZXBhM2ZtRVNIcEdjV3Nucm15cmlr?=
 =?utf-8?B?L3piRER2K0xUanpkQW1IaEpmVk9nTkVpeEdmZmpra0MwQ0RWRzNkcXA1VVVR?=
 =?utf-8?B?UFdzZllqMDUvcHhueDFuQnVmK0V6SnpIWEdhTU45elczdHk0VEhCWVpCZm44?=
 =?utf-8?B?U3NvMi9uNDRCd0FmelBLQjNSVnFpOTVCdk9xN25tdzRPdGpobTgzSitKNFA5?=
 =?utf-8?B?UFQ4RHNXdGQ3YkVNalE5NERWbVlUV3JlT2puNEdyUDU0NjRBUnNQQ1o4Vk1a?=
 =?utf-8?B?SFlMWVVLOXVlS0d4QUZBSWZmVk9GNzBQcGZSMDR1Sy9YQXJpTEpIMmdYQXRp?=
 =?utf-8?B?VTlvYnlNYi8zNExLMktJVFBWNVZ4SEhmZ1dmdklPNHFNSTFFWFRnZW1Pd3Fu?=
 =?utf-8?B?L0VyMnpEUGFjRDY1V0R2L01WdlZEWHRMeTdoOGh4SXdBY2tsa1pzcEtoVWFU?=
 =?utf-8?B?aVBUYVFkYkR5QytPdm1Qb0pwWFFCeXpxdE53Y2hLZU1LYysySU5VUXdJK3M5?=
 =?utf-8?B?VTByZDdKODJWaEZpd3E5b2NJRFh6MDlGaE8yMldCSkZQVzhhcXE1bUJGWHFX?=
 =?utf-8?B?ZFNuRlh5MVNIY2NVMHBjaWtjMkUyazdTbzJESDRwZ1FEVHptMkpUclZNS0Vo?=
 =?utf-8?B?L1A1TXFuQTVRRkZDQ2VqbDlOS09BOGVaMFpPbzVnNTNxU3dTS2djS1p2ZmUy?=
 =?utf-8?B?U3dUWGcyTkFjUC9KVWZEcXFnd1pTbVpneEcrOHBiVnd4eVRpaHV4a2lBdlQ1?=
 =?utf-8?B?L2VVanpEQXhXc29nWm1ubE04V01pRHBWQlYzMzg0RXU5MWtUaHIrZjVDSmdW?=
 =?utf-8?B?UTJUY1lOYnIzeVRFMFNESnlYVExvK2h6Rm5CRkwxUjh4OGM1ZC9UUHFENkJX?=
 =?utf-8?B?VndJeHAwTFJ1NlFPQkhUU1Rla1NTUDF2amFjeFRaOVF6aGdJb2ZlbHBFeUd0?=
 =?utf-8?B?M1VsdXMyMWEwMzh6TmE4alY1RmF2QWFSZSttblZ1OUtRVTFtbXlkRVZGUUI5?=
 =?utf-8?B?QThXUDhyNGYxcko1Zm1tLy9DNzY1ZDI1djJxa0R0WVBFSjhMQTRISUw3S0k1?=
 =?utf-8?B?enZ5QnVmd2p0bnluNE5sS0dkbGdQQ2NrOGZWSWFLblM4b04zZUV0UUJJczdM?=
 =?utf-8?B?Tjd3UG5JL1ljTGY0UFp1dlJZMVlPVkF5emViRGsrckc0VEJVbVgya2RFa2N2?=
 =?utf-8?B?ZmdyYVhwdzVhY3hRYnQ4T01qSEJCWHhLcFRwRUFhanNHeU55dHhaYmgzdzV0?=
 =?utf-8?B?RDhocnd3TGNUc2RESTY3aklaT1dSUkRGNkFMcWMrVlhrMFBXUE5TUlp0RVpT?=
 =?utf-8?Q?rMt/yYKjuMZmrvr3aDfTwAg=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2cf5eb5d-29d3-41ff-854f-08db82b97ea1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 09:22:21.0105
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4MEwJvTtjwpcZmPiGRNGdM3yn0ER5nTboVJuEOTOX+4lWGC4uEa2sIEIA0lRpRbIZbrblzkvzIj7JZNbXv4xlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9685
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 04.07.23 08:47, Greg Kroah-Hartman wrote:
> On Mon, Jul 03, 2023 at 11:11:57PM +0200, Enrico Mioso wrote:
>> Hi all!!
>>
>> I think the rndis_host USB driver might emit a warning in the dmesg, but disabling the driver wouldn't be a good idea.
>> The TP-Link MR6400 V1 LTE modem and also some ZTE modems integrated in routers do use this protocol.
>>
>> We may also distinguish between these cases and devices you might plug in - as they pose different risk levels.
> 
> Again, you have to fully trust the other side of an RNDIS connection,
> any hints on how to have the kernel determine that?

Greg,

it is a network protocol. So this statement is kind of odd.
Are you saying that there are RNDIS messages that cannot be verified
for some reason, that still cannot be disclosed?

	Regards
		Oliver