Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Jiri Slaby <jirislaby@kernel.org>,
        Nick Kossifidis <mickflemm@gmail.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        linux-wireless@vger.kernel.org (open list:ATHEROS ATH5K WIRELESS DRIVER),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] drivers: wireless: ath5k: fix parameter check in ath5k_debug_init_device
Date:   Wed, 12 Jul 2023 20:42:59 +0800
Message-Id: <20230712124259.15096-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DSuGf+HYb0GXl2a5e1XIdg1Je7orM5qh4QGU0r/Zuv4DdR+xJNPKyCwFMhCv?=
 =?us-ascii?Q?A9O3dmzbU01Jl7BOcXNg1ZSf0FcPK6p479bFCQOwAhW+0zYHDUMdbLkwtKqt?=
 =?us-ascii?Q?bWAWpyXJjfC1wi3qYEKMbpmA0SG95zvi7ElvFmmTvURcRagSwk6BZ54+3L5H?=
 =?us-ascii?Q?d4XpTXzbIPZi6hEHq14rqGWq+pLSvViXvQzwqnmd/bFIyY24Th8b04EmEckS?=
 =?us-ascii?Q?jmkL/H/PpytG5zoKbDdtElK1fzWBcHKVKXTDe3SxoJkQSVkB/2Dn1XVwtbvq?=
 =?us-ascii?Q?yB5EXiLbYzeCS7QIM17InRz0TqHQuCGCLWr8ghiI+CoIjkiDaEBwvjzmZs69?=
 =?us-ascii?Q?CkGbTxhRkXMBibfUlTMNeSOBbhoXyTsaazG7Tp4OAJLxHPtR0D4GHaVHV3Kq?=
 =?us-ascii?Q?3aNnS01hLjUhD96cCfvQictpUH3cR5DAtBmHlwXML2ZRJEHuobAsINlOy3Jw?=
 =?us-ascii?Q?Hf0SNaLCbyDmEooBISFPbP0YXY70Y/RRMwbDJxPL51jZN/R5PDdZoVXrPj0m?=
 =?us-ascii?Q?z5liM/lNtjK5E/KzKu+8wNWe7V02e1qoGHb5TdMhSM4QSiV9Sur9ocpwUQT8?=
 =?us-ascii?Q?2ktENlbokQWqPqi8O9WKuKYv74CeH3a17k4zgAk5OVG0aaQwe6ga0Kg50HFP?=
 =?us-ascii?Q?Z567AUIZdenxdbDSKcQ/VUepodLmSi7ZQy9okGguqvz4Pz2OhEQy3jA9vshx?=
 =?us-ascii?Q?7L3JxNUHf8cn/HwNDwcS7Zute/Gs/gOGV07kEE3QbGOzmEKDSlSOPX498Esg?=
 =?us-ascii?Q?v+X7ENA2m26iAgOldWIG2QChsFjXq+D9JwId4s4EZYtSQ2Ac0vSRDPNr/vXw?=
 =?us-ascii?Q?1V1NPTEA10J66cX8XJee9znzSoTpHlUEKeMGfSAY3G6Y+3lBIKrv9xqwLuag?=
 =?us-ascii?Q?y+LjC9NNJLdfn5CBn5t6EeP7aOqAn7WQXOaknFWf3GKQVFGQKicf99k+vHl0?=
 =?us-ascii?Q?FwZwSR/Dm6q4FSfWP+PJTFtG2h9r4ADmrcEQRgeScimkPSknIEp7T5HJ4b7J?=
 =?us-ascii?Q?wmRKvUmEDl6qQAvhYdpqYLYomBtrhcfbvImqqVnT1+6jAAEt1W5jSTRgiEIK?=
 =?us-ascii?Q?iMBHTUtpvW5th356YjR4Ibr+ypjpf/WeNj3PSuGCv2PdkqmhyCSBfIB5H9hh?=
 =?us-ascii?Q?CbZ3N2BYK/8RZn1GuoBdh8mbrSDIHo2W6N/UacuqzhzMudybD1GKIQfy5zw1?=
 =?us-ascii?Q?BjAi6ZM9s87d5bd250T4508AbJLj6ahj1TPPN4IU7EjyU3gk7/19s4BLgYPT?=
 =?us-ascii?Q?ZLUPFRoWGxHOT3LuR7cpZkVD9rKhFndxidT8OAbp7qvXfkgcZHpP6gB144QX?=
 =?us-ascii?Q?AL6G1uTB7qbPKNKiQSG0ewb26uciK3jWNhbjA0bcuAAP6jCpBf4tnZozQCLH?=
 =?us-ascii?Q?i0wYTl51GtCOIm8vnZgG0E7MP0LD7DkcOrnHo8ny8KHtaSx3f05i7NB7Jmkg?=
 =?us-ascii?Q?8NuCE3Wy5XJrUO47Xrx0fHIUFHR6RaWxONVziAVMjvpGNbFr4U8Tqh7ngGDC?=
 =?us-ascii?Q?BMz8ALBq7HDt5fvOT8MaWPWcO96fu9KMnq15WGrTQMw5E+AmdQVkUtFhWz0r?=
 =?us-ascii?Q?mW4ds+KAz1A9OIcGUoqWQHW//8q/FGr0avkHJeY4?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52aa9fb8-3257-44fe-a19a-08db82d58c29
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 12:43:09.7356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K2a/Z5iL7PEOjn/HN7lJiROMc1aEjuuu7vQY7muEcGOViReeARA0LxpdI3ZMOsCse2o8sNwjK8eWYvlBPIVe+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6359
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Make IS_ERR() judge the debugfs_create_dir() function return
in ath5k_debug_init_device().

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/net/wireless/ath/ath5k/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
index 4b41160e5..08058b3f7 100644
--- a/drivers/net/wireless/ath/ath5k/debug.c
+++ b/drivers/net/wireless/ath/ath5k/debug.c
@@ -982,7 +982,7 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
 	ah->debug.level = ath5k_debug;
 
 	phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
-	if (!phydir)
+	if (IS_ERR(phydir))
 		return;
 
 	debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
-- 
2.39.0