Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Gregory Greenman <gregory.greenman@intel.com>,
        Kalle Valo <kvalo@kernel.org>, Minjie Du <duminjie@vivo.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        linux-wireless@vger.kernel.org (open list:INTEL WIRELESS WIFI LINK
        (iwlwifi)), linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com
Subject: [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register()
Date:   Wed, 12 Jul 2023 21:14:06 +0800
Message-Id: <20230712131407.16462-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jn/AGYEpeFiTor04ER5+wr76t66XkrY1kAQq70f1vu/86TdeAg07XmkdVOCd?=
 =?us-ascii?Q?Q7fQhPHy6HOwgCWWzeb1dAcPb4TNfk0+2XHdt+Xddejr0zRWfZoMf1PNsVza?=
 =?us-ascii?Q?vw0GI9Hbbky42AnAF4t7dKB5ZFa1RF+tyHp5f7VKVHhRZf08spf17Hf6fwTB?=
 =?us-ascii?Q?qPGVRvM7kefaL/QTNCPIrY9gsJckqihQJLIWYCfmUxq9LgVncA9R0gkY44xB?=
 =?us-ascii?Q?5AUYlIz95VIG00WJyYNelpeel29aKMNUZpFoVUd71MEe6UlhUHFPPsiFvDqV?=
 =?us-ascii?Q?kMpNTOXr8vpOzog8zjo6QZVl62i6cmwlYRezD15vm/VwzsmA3eP6dHYisiiX?=
 =?us-ascii?Q?DxrZn6S6MF4djPFg3rkbPcm79mVsAujvOTHQ52PFTm51073WKclcySvlZXlN?=
 =?us-ascii?Q?ASr4LvGp4EjfLTnKCsAsdMrHT/rJFpqXYnU1KbhwyfIWQ549TEI/8JOm6ppY?=
 =?us-ascii?Q?A9/AcB5R1vawyH7VCY0/jzWUQDYsHiKVsqrGBD+dGmysFlBc7ARSpS9O6uRi?=
 =?us-ascii?Q?vQFdV9uehukLPsXkris/WZ58zXIKJ8UcWp8XjFo+BPw+5QvJAATn7C8u/yue?=
 =?us-ascii?Q?lulba5DgpXkWT3Y4XqJ+zrL7BVYa0kk17lWRcFw75Eq4b+nnmtMKs77GLPlQ?=
 =?us-ascii?Q?n38gx1UE8t33M6MQFu1Z3O/LVvLcsQ0PuFpBb5bVarjGgWhBvjJXh17QLM39?=
 =?us-ascii?Q?u4cs7r/6ueLKJqbLUBmMO4H+vwgPMTvzHTqSv+CjoOE7C7wO2wtV9EMri2HC?=
 =?us-ascii?Q?DtwXMfl6R9vcUI3LmfulEA9T8LSOgmRb31a0mUyrmyOBXMgZ5UTO/+3k+Knr?=
 =?us-ascii?Q?H/x7xIBFxkb4UVD9Fjgvf36jLb/Ak/Y4JbYsKm1QDxlcRzMfxH8ggVYDUzJL?=
 =?us-ascii?Q?49QMLRo/IRxSolE6EGsVh4mt8iX6iYXgW6SF/nld932tl8jvgySyV39tWuJ/?=
 =?us-ascii?Q?4v9zLhZFzVh03KsJ/LKS0R36KB/yKpB1LuC9lumZXQCltbKf9bWwMns6Ibgo?=
 =?us-ascii?Q?HfKaHWn6H/cKqyax6w+HvxMVZtyWgLVpvJhxtwvgkb/Fz4IwD+/4MfCr+AiQ?=
 =?us-ascii?Q?Ie9NuZJiSqX+1JGm1GBG6nCfhTrtQTDpVJy8SVToYgGYdiJ2UaY8xdBxgoMk?=
 =?us-ascii?Q?ual8rtDL8sg5Gr6ya9/WDSQ07vlhf021dxoL2XbGd3Shb/lig2LOUlbzfxJb?=
 =?us-ascii?Q?LCFmIngHG2A///tcqezEXHb4CRrzORA4BQrwAxMlT1GkcIkLmuvd/M7tmrsk?=
 =?us-ascii?Q?KzY5gX9Hi5VgKirey6hTG/M7gkxQNgB/siIN6NHTFuYduoIhQ/kf2WH26dTF?=
 =?us-ascii?Q?3YUcvXFCVsxEHe4/zIsuzrktgDyIjziYqgYfS01k64KISG5y1P9OHzfUY+Py?=
 =?us-ascii?Q?b9CYDhYHxrQ20SP6Eejwsq84iB/wWP8fYIzelipcjRvCAZ2RglQs2i+dWkxJ?=
 =?us-ascii?Q?zFtaeAzYtvohDvBNHGPyAzHM4ESlMFTa7n/53CXquFHhYIelR8jMiEIDag2J?=
 =?us-ascii?Q?Kxe9GAvevTdto19kFWGSk10Mb9YRefPhaWrfz/pGqxULOJaaDOASc6AAXzA7?=
 =?us-ascii?Q?rL67gEvMDy71/ocSpnkQf9tNfd70BLm+qja1MGP4?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78d5bb0d-2fc6-4b1e-2379-08db82d9e4c1
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 13:14:16.2277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8lPOV9dhbkb6P19svP0bcQbcu+xP6aKhYWOaurJzqeLCn2U8+hSPct8jtrq03L1/XtTZNm4X4gRHKPR8Vx6dHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6052
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Make IS_ERR() judge the debugfs_create_dir() function return
in iwl_mei_dbgfs_register().

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/wireless/intel/iwlwifi/mei/main.c
index 54445f39f..e5d203a62 100644
--- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
+++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
@@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
 {
 	mei->dbgfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
 
-	if (!mei->dbgfs_dir)
+	if (IS_ERR(mei->dbgfs_dir))
 		return;
 
 	debugfs_create_ulong("status", S_IRUSR,
-- 
2.39.0