Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Wed, 12 Jul 2023 16:01:22 +0200
Message-Id: <CU08YMZ7867W.ITLC05RV2R69@syracuse>
From:   "Nicolas Escande" <nico.escande@gmail.com>
To:     "Minjie Du" <duminjie@vivo.com>,
        "Gregory Greenman" <gregory.greenman@intel.com>,
        "Kalle Valo" <kvalo@kernel.org>,
        "Stephen Rothwell" <sfr@canb.auug.org.au>,
        "open list:INTEL WIRELESS WIFI LINK (iwlwifi)" 
        <linux-wireless@vger.kernel.org>,
        "open list" <linux-kernel@vger.kernel.org>
Cc:     <opensource.kernel@vivo.com>
Subject: Re: [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters
 check in iwl_mei_dbgfs_register()
References: <20230712131407.16462-1-duminjie@vivo.com>
In-Reply-To: <20230712131407.16462-1-duminjie@vivo.com>
Precedence: bulk

On Wed Jul 12, 2023 at 3:14 PM CEST, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return
> in iwl_mei_dbgfs_register().
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/=
wireless/intel/iwlwifi/mei/main.c
> index 54445f39f..e5d203a62 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> @@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *=
mei)
>  {
>  	mei->dbgfs_dir =3D debugfs_create_dir(KBUILD_MODNAME, NULL);
> =20
> -	if (!mei->dbgfs_dir)
> +	if (IS_ERR(mei->dbgfs_dir))
>  		return;

same as the other one

> =20
>  	debugfs_create_ulong("status", S_IRUSR,