Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp519282rwp; Wed, 12 Jul 2023 17:57:21 -0700 (PDT) X-Google-Smtp-Source: APBJJlGI/gUq4Diz1zdibq7Q5DlbgtUfxTHsoTroO48CoGC/E7IqYf4xXmaTA0v+giIpe0CvCPHY X-Received: by 2002:a05:6402:2037:b0:51a:2c81:72ee with SMTP id ay23-20020a056402203700b0051a2c8172eemr423673edb.20.1689209841250; Wed, 12 Jul 2023 17:57:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689209841; cv=none; d=google.com; s=arc-20160816; b=IL7BGPVzKnqCC3ybDFvEUjcmAAinCYnxvevKAAfN9ZiFy8Hs27DcKh4Uni5fHo0e40 lTaFv71IrcNHch47sR+L+OkXBVv2pjM0JHP6ZcZPPd9Szs+17+0Fl3TLJ04bidvHSpsq 0X00Fhc0mQti+vYFghHsH0bb5I+TOSIt1K2YPuNRIgVTofRRLye7nW9Bp3P+E0YH/Qrj WTK3NcDUBSZpwgGt920uPwXe7KgriAzBzHdH6wOCuY8OFB77UQ6KZlaErgI9/qULCJsk FdTWQTNLryI3j5fxpcfsb2Ei/dXM7laC32VjwU2dNqPARK3WwElkSK0UbQRENhAhshig rraw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=QpLcig33slZ8UJwEidtJIGOO4TPYI+tHkBrSRomMty8=; fh=DqD+B2jbstMWcufyTqGU5kwPET9nZSleYgDV+890OMg=; b=ibFzvPYzIpFTy5HVTJiIG3W+bhh/bJjSvnbmOyBcEFD24wHISwXW5kt4QHwNVan3ci NGbkrIM2PO+YUjx6e/5UMOrBPjC5DJJKedtZ/BGIDCJBHo8ZWHQ/0Jj58RCZAaQFmqD/ c7ucCWOU3gLjGCBM4LEfpPnznxF9REXusKk2vuYj9becdMYv9mn02OYXEbqG7FUOl18H DL272aorfD3RlgeMXIik7M+BTKZ+jwx5RlOXuwZY/fzj63a5oFYMt7sLXu6Ynu3GEPeb IFTvzf24Zk8iUjOMg6Nn9on/DHp+gyhwq0Mp87rvjNp7+FWtdty3r2a0wwbj5XfvsI2P jV8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HLwIxN8O; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x6-20020aa7d6c6000000b0051fde1c1bf7si3165150edr.417.2023.07.12.17.57.06; Wed, 12 Jul 2023 17:57:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HLwIxN8O; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231573AbjGMA4u (ORCPT + 61 others); Wed, 12 Jul 2023 20:56:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232841AbjGMA4s (ORCPT ); Wed, 12 Jul 2023 20:56:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ECE826A5; Wed, 12 Jul 2023 17:56:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C5C4619E4; Thu, 13 Jul 2023 00:55:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37C64C433C7; Thu, 13 Jul 2023 00:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689209727; bh=aCZYR0LmWlN9sSkfeilkskDKIFbQhyEmAW03O19rxUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HLwIxN8OXFRBK4hp+EoG/9vNXZB3hWed4N4JKygh/9+moV6+qt7eSuxxlJsMty/G6 B8r0sJpRIAlw5L5cJDpnmHhW41r4kgEeAuaMx+JGZ1XiMGd6fvxEu5+AMVeoEY/dMD bMQcLO4I1bnCsA2vsnb3lyp2LAOCoCG1k17AKfz9DpDxftf5XfoLuoOMkKTiq6GGYY HRBiBRtUP2AUZKWdVLV8X3K3qMf7zK66M26UQcoBRs0xJwFor7KXSwZxeeOtXc2gx2 EqE4xnndLBJW5D6Pnp1dCgGc1RSJPiaBUd6slocfFuyQj5E72Dwxk+B5+81wo1Esa8 kkY7P9wT+efOA== Date: Wed, 12 Jul 2023 17:55:26 -0700 From: Jakub Kicinski To: amitkarwar@gmail.com, ganapathi017@gmail.com, sharvari.harisangam@nxp.com, huxinming820@gmail.com Cc: Jiasheng Jiang , kvalo@kernel.org, dkiran@marvell.com, patila@marvell.com, bzhao@marvell.com, linville@tuxdriver.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mwifiex: Add check for skb_copy Message-ID: <20230712175526.55709bfd@kernel.org> In-Reply-To: <20230707095121.10453-1-jiasheng@iscas.ac.cn> References: <20230707095121.10453-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 7 Jul 2023 17:51:21 +0800 Jiasheng Jiang wrote: > Add check for the return value of skb_copy in order to avoid NULL pointer > dereference. > > Fixes: 838e4f449297 ("mwifiex: improve uAP RX handling") > Signed-off-by: Jiasheng Jiang Amitkumar, Ganapathi, Sharvari, Xinming please review.