Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp521753rwp; Wed, 12 Jul 2023 18:00:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlEjX7cKSE/tcTiZbB3FRk5GFQMAv3TyN6vussvPidtJ4DueqGw1vCttXYaJe3HpMXSOzRBS X-Received: by 2002:a05:6512:3b0e:b0:4fb:cc99:4e90 with SMTP id f14-20020a0565123b0e00b004fbcc994e90mr18315972lfv.37.1689210054161; Wed, 12 Jul 2023 18:00:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689210054; cv=none; d=google.com; s=arc-20160816; b=gfdnv6pnnuiFEG18LNPa601q/M1J2MXC8yHbR+ChVl9KpidOUBvw/D9TiQrG9di4G0 D5CV46gAqN3PeuWuDYYA2ea3d/5I5ggrO/lJ255hbAh4b3KxwN7wRanJ5hskTZZpmcEi ZW7MGmuc9KlBYpDVo2raQJQggpkw+1Rl5Jtikvd15eithju9EepbveUF62tjT+e6VELy YOEU+IlCDqqR0H+clcPlVxLHDsSXj7IGznOdx8dzKTYOwliJit815vGyIiolvurOAIl4 ka2Lwn3b7fg7SjWgQRIvWfA5pn55adcw4+KTG3JwOoAKmb8P9tza7P8zjq7PtsYCG9FM wARQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=grGiFzlDxzvz6wfqR7lcyVgzjUiMch7I2dZdDCE4ABE=; fh=cwSX+C6BcJ2FjRSjCzbObKi6YJEfaJqOP4xGjJs6TiU=; b=DSLusNIW6WMDQ4vPlI9VlBVuGvGqd3TJnU7E9h55Vk6pLLBNj6U8X2lfkyp/s1VCaS 6cU4x29pnAMrRcRXc/bin/7s2BXE4q+VxPk/HRiIwhK2MOZlta9TNGfYznlPP8vIXPw/ DY6iTnh0RHQNovYl1tyUposlvP2DhPvbN35cz29kgP765RQ0nK8Bsj4nTG0umTLuFbLO tjRbD6xaFtD/nI1IbWqTsuKNzt+aZ5LWB8HptHrDkOG7T400kIJTQR2dQ/bctStQrlfl GJkoIEz2n2Ac4GVqNiN7WoPAOzHj+TTjSqTWrnPVi4PPqF7v25hfe5tJ3I4g/GDm9qy3 usAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JfZJWpZz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o20-20020aa7c514000000b0051dd2d6c09fsi5823833edq.424.2023.07.12.18.00.39; Wed, 12 Jul 2023 18:00:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JfZJWpZz; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233032AbjGMA6a (ORCPT + 60 others); Wed, 12 Jul 2023 20:58:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233436AbjGMA60 (ORCPT ); Wed, 12 Jul 2023 20:58:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 324F62117 for ; Wed, 12 Jul 2023 17:58:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8188F619BD for ; Thu, 13 Jul 2023 00:58:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8A6FC433C8; Thu, 13 Jul 2023 00:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689209900; bh=grGiFzlDxzvz6wfqR7lcyVgzjUiMch7I2dZdDCE4ABE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JfZJWpZz3hAG3QAQdkLSuP0yyWAtMLPyMsxgZio/UgVxrszSX3T40pwZToK8Uu2e0 KLtl/KRdsqWQMfdRBkXCeR8svGDPrXopOvYIhAqU4o7aiM/reWdko+wKWkd8JDkhvA XVkCT8fORorljlQ83eDjUG4H0MbMpW4occq/CoQZRVhW+h3ubVbABx0Z1TeZftyci6 QzR3vpWGrXeiE69zuaIV7PHfazGiwDNd6WaO47xW846isHL6wC5eMDWdlE0CtldMS8 vSj03+8rueJGy6SeU3H8JYIN5DagRv4pQPjV3VwE6cGZlZyfml5jlo3CRzcsrMBE2A TO6ZojGlBGqaA== Date: Wed, 12 Jul 2023 17:58:19 -0700 From: Jakub Kicinski To: Dmitry Antipov Cc: Kalle Valo , Brian Norris , linux-wireless@vger.kernel.org Subject: Re: [PATCH] wifi: mwifiex: fix memory leak in mwifiex_histogram_read() Message-ID: <20230712175819.1f8a7c24@kernel.org> In-Reply-To: <20230711082504.18838-1-dmantipov@yandex.ru> References: <20230711082504.18838-1-dmantipov@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 11 Jul 2023 11:24:53 +0300 Dmitry Antipov wrote: > Always free the zeroed page on return from mwifiex_histogram_read(). Fixes: ?