Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>,
        Kalle Valo <kvalo@kernel.org>,
        Rajkumar Manoharan <rmanoharan@atheros.com>,
        "John W. Linville" <linville@tuxdriver.com>,
        Sujith Manoharan <Sujith.Manoharan@atheros.com>,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH net v1] net:wireless:Fix an NULL vs IS_ERR() bug for debugfs_create_dir()
Date:   Thu, 13 Jul 2023 11:03:44 +0800
Message-Id: <20230713030358.12379-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lhMKmVBWuRHPm6o+AZ85Nzkcls7ti/pO2z9FsIV9y1mMd1nI1ZenPIM2IuQF?=
 =?us-ascii?Q?HLLzWh3l9bVT6mk4hyx9aNziajm0Nfv9sqms+QzeDhhSDcENoWlg0WLpBL8K?=
 =?us-ascii?Q?VHwWtydUZEuQDSJzGNsPvIBduor1U36NHALKXRW3c6Qhx7umkq0LVLcWQ4N3?=
 =?us-ascii?Q?CnUAtMKwxS0vNmQjzYiI7BVqYnwZO2g8tw0OEEpZpAJCdMBOMPhY01ifXhab?=
 =?us-ascii?Q?dF/b0HwkoxZRcGHlo3WjoN1oOA3EiIuDpqR/Cp+Yq4rlHQtH5d+I00detVx8?=
 =?us-ascii?Q?j5Da8YZALSSv3ZpAxS3dc7HAj6EgaWYwEcKXpwmiWzmZr8yYUlCye8j5wn7b?=
 =?us-ascii?Q?7gbwXmfhCjoHftVz2aONeZsExjtnBg1LFJivCiUI/3Vvj3mfId6Bjv8dNeJg?=
 =?us-ascii?Q?ZwA+tbSc6t/6Tz5Sn155SP5Ue7NeICGkFdyoCob+1HAJr/4j1keXhos8UOwG?=
 =?us-ascii?Q?zzRXmgzhLDuMTmKAMv4pkGR7hq9cNFkoDPQ2hKWXg4Ak0cQcvHo7154A3bZx?=
 =?us-ascii?Q?s1NVqqMfr+PBKB5uRh2VyheYeRqQIaOnsVzD2SmOtlxC1Mg3WMUN0wqJQDJI?=
 =?us-ascii?Q?bzfWtbRcF0YiedoIqJq4ghzO2jpGq184qXoB4DHBA6eXwlY4s4MkR4xgrZia?=
 =?us-ascii?Q?EaZtuAXrUeLOgkPUnulqiTr2LLxAs86eZlIHmcZauoDulQrt9Ul3mtrNKUYL?=
 =?us-ascii?Q?rPyrcmiWF17dvBSq3R1UIh0XsFvU2FO0wHZqwGiZG7WpY7DOLb+0FGA/tAtB?=
 =?us-ascii?Q?nZsnXtW8/BHGoRTOMkr3RBNY2s9YK0otHlL8J0deq2uPA8j0xebezRcHcL5I?=
 =?us-ascii?Q?U1aCnikiS5LBEuHG5DpADPDOi4tHAcB/BroaxkAEOqLtqDqzI/gOo1koGLRL?=
 =?us-ascii?Q?o7dSmeY/nT9gg6ouCP1/aEuadLqNw8Fpx7ru/iHczIRAGTTnjoH5zwUWPsYt?=
 =?us-ascii?Q?E39pSNe4T2j0lxzmDj0dNEPElVjOVjs445yEloJidqkPzSehWmc3fNqXxQ4i?=
 =?us-ascii?Q?Bwz7sG8zL9A4tes4Rj0KBpVkt6CzNem/InqxE8R/u5l+qVD7IOXbxZioss38?=
 =?us-ascii?Q?FCuSOQVDtXkZxB2kSgNKRUFTEHFxr7TQyiX4FBc5BBy8dhAXxkzlxjULzXMX?=
 =?us-ascii?Q?z3Fz65N0wjtlUTr9GmXjYevnCAzPsRc5g4KDEBIC2ChzqmjgIAi014TH8+yD?=
 =?us-ascii?Q?aI1TjolOIt60jQlgsaG1lsfmLPpMXhaBj1W0KAnHU1QDVr6SUYeDiMi29i0t?=
 =?us-ascii?Q?17HY6vrSXfLKa0alB/dmxWDM6IZU/PLbfYTHAwaap+Q8vbESf9p+zp/ET7W+?=
 =?us-ascii?Q?gG1zKOvFAtAMiKhF5AraAeAcSR4ePgFO/7xnwYtf0wPEp6mNNKbAfMeb5uKI?=
 =?us-ascii?Q?jc6hTH/VDYyAM/yMNOhOY53hVk591P/cQGuKV5MfOSRtSw2JLMbgC/KRTkjB?=
 =?us-ascii?Q?DmjC65CFeCnYCYYpYTWYKCi2mQC16VCTrL7oetUIz5oIOLtJFOfkDZOtNvge?=
 =?us-ascii?Q?g2Vy7YBpCas+Ul0rPFiKkNrS1/5ksXLGO+vjALZYyJ0uEUuYC5s2+MLNSGww?=
 =?us-ascii?Q?Elp9cZy31kATkqWWDE14Cs6T4eFwHG9moD0hFbW3?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9b56668-e8ea-427e-d78f-08db834deffa
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 03:04:56.6828
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +YBt/QjlLQaJOuIjBtSARYNxlzopPZKKcCsycM31y3jCEB6ewAhxSyqoLQs1VZC0UhEXvEsKjXAprNmEMAFqJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB5928
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

The debugfs_create_dir() function returns error pointers,
it never returns NULL. Most incorrect error checks were fixed,
but the one in ath9k_htc_init_debug() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>

Fixes: e5facc75fa91 ("ath9k_htc: Cleanup HTC debugfs")
---
 drivers/net/wireless/ath/ath9k/htc_drv_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_debug.c b/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
index b3ed65e5c4da..c55aab01fff5 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
@@ -491,7 +491,7 @@ int ath9k_htc_init_debug(struct ath_hw *ah)
 
 	priv->debug.debugfs_phy = debugfs_create_dir(KBUILD_MODNAME,
 					     priv->hw->wiphy->debugfsdir);
-	if (!priv->debug.debugfs_phy)
+	if (IS_ERR(priv->debug.debugfs_phy))
 		return -ENOMEM;
 
 	ath9k_cmn_spectral_init_debug(&priv->spec_priv, priv->debug.debugfs_phy);
-- 
2.25.1