Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Jiri Slaby <jirislaby@kernel.org>,
        Nick Kossifidis <mickflemm@gmail.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        linux-wireless@vger.kernel.org (open list:ATHEROS ATH5K WIRELESS DRIVER),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v2] drivers: wireless: ath5k: fix parameter check in ath5k_debug_init_device()
Date:   Thu, 13 Jul 2023 11:36:47 +0800
Message-Id: <20230713033647.2109-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pDcVBShTGCtmNSkTDmgnixJspKMRTjPrlLLrkkRcW9rS1+yfXqNZhb2FcXcI?=
 =?us-ascii?Q?HZ6CIwkSSL7K1PYjlLjCl/H0MJAvvbEe2mcfHqRTYdMWfRFD/a2y8BQ9RHUx?=
 =?us-ascii?Q?bO3AvNpvXLp9xjb8V48P8b9PPDUhMGuQmFFm/dOFDlYVz+MHdvlKDzOa2w7f?=
 =?us-ascii?Q?K4MzGgAcsMBr5YYmNaM+8rGztQ0m5NOFdx4PfpFD0s6BLtFzvn2zdMwaOGSz?=
 =?us-ascii?Q?2EUYXapVK8+0jSlfRLFVh/lm6UJV17v2QbDcyJD0JMvmpbMJhydaZFrPkd2W?=
 =?us-ascii?Q?5IJYWStEfOhDKs4UuofhAvBIaiOaxaBIFVKBWWtV/9XKSe4C28Fz2KwAhL2a?=
 =?us-ascii?Q?j89Y8YdtzcptjGXxPrbc0JylwOCCCN3fZTztDNt2tZr13LcHh1q9E85OnShj?=
 =?us-ascii?Q?5QcpxmuL9eEr7zK47m0xljjIMtPonk8knePa/ADw4heCzSV6R+XWLy1yeiaY?=
 =?us-ascii?Q?yrU2fxI7x3Q7STSg7ejw6uH3/ovaTmZgu10JOdChJt0LwJIUGMqbXt6/Wgbu?=
 =?us-ascii?Q?z8iaHYyw9smk0F2hncsI0ce40c+wAvyko6JEuJEPElAfJOZqp38l+GfLGb6O?=
 =?us-ascii?Q?vq9SHpm3iiMX3q3K7gIFaJ6FIgMzQfxSYNbB7scgrKncU3i2WNw+oL/ZrEj0?=
 =?us-ascii?Q?iOqO941C9KGb4V65T478CQgEGxInO+TiAxQPaY32qm7iu/9CzzuFwrEHhzSc?=
 =?us-ascii?Q?D2igy3DGAoT4GIDJg8NhQ81XyZ2xJwEthnoJu3wf71EEWGMtSUd6IlQpp3cp?=
 =?us-ascii?Q?S+Ll4/FCUKvDj6i5jE9mLsix5soYZ/OqFr+dP+fVDgfheYlp6h81DjQyXfgn?=
 =?us-ascii?Q?w/ufuonvZcvk2m5l/mg3HJsLRe0FmtiN8v3eD0iWO1u36QMKOdHC9qEkwfIP?=
 =?us-ascii?Q?jKwKkrjTZ2pbF6h1nIKG/lLeFXGC9s9xss0ntDeQ7TxWdPGDYQHzT/dkM4Pa?=
 =?us-ascii?Q?NVlRoQUClFKprhiIi485RrDxgX1H9UfnzrxqQTKDyPGL5RfMO0q8k1KTnfwL?=
 =?us-ascii?Q?M2ec6x6KfAZOZrHjb6o3II8DZT8gNusWyQUjPgQEJbFU4+bHLRp0h1liwILk?=
 =?us-ascii?Q?OcndswXbaP7A8FhdrTYG9PelOeaWI66TQp7SPuSTcmP20HjgUWoS/TuQrdgj?=
 =?us-ascii?Q?CR3Xw5854nErjJft2jmOXKrQbqdYVN0UyN8L8CwC7aTEY+z1fWgwoGkRHlWn?=
 =?us-ascii?Q?DeZvUEz5Edb6UepEi/GuiO99UDZeLbRBX8vHionJ/CvKrI3RrAsipWy+GQ1c?=
 =?us-ascii?Q?dSm3PRnocTlAc8rbZlw2JTFr6h6eZzK3SMlrLi/bX3Y/k1sK5t/d+nx2qDg/?=
 =?us-ascii?Q?cGFPFhtUwh7PZB6brfNRKJZgWGj1lXLGZu6TWedtvuDdo+YmarztTiL2dunf?=
 =?us-ascii?Q?0B/WCj3Z1y3FXJTNmNPAKKxNyooBIPLsc5QxPVn3gvyUoZcU2DfqhJRDwMks?=
 =?us-ascii?Q?sVCGYJ4AEMApm5aIBXkVgXaQwZdRUcesHavi+FyFGPAfMRt8cJivRMMryOVg?=
 =?us-ascii?Q?U39Fpc7eK/0/oIi1R1CZdCVjEOtMWNQw4yfcT2osuaxm42D/EZbgLBeH5urZ?=
 =?us-ascii?Q?wSU/bIZD7CE6YrSPDmqCZ4Gz/J3T1mIRkt8OtdL1?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16d2d2e6-9d24-419d-9e43-08db8352675a
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 03:36:55.6539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xq8IGI7XkvzKo+XwzsvSIW/0l9tZpSQou85MmxUNtdxMxoH2ENAD57358O5wPXEQqnkRZ5DhvaTDNqQntduzIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6579
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Make IS_ERR_OR_NULL() judge the debugfs_create_dir() function return
in ath5k_debug_init_device().

Signed-off-by: Minjie Du <duminjie@vivo.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
---
v1-v2:
use IS_ERR_OR_NULL() instead of IS_ERR()
---
 drivers/net/wireless/ath/ath5k/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
index 4b41160e5..7c8823759 100644
--- a/drivers/net/wireless/ath/ath5k/debug.c
+++ b/drivers/net/wireless/ath/ath5k/debug.c
@@ -982,7 +982,7 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
 	ah->debug.level = ath5k_debug;
 
 	phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
-	if (!phydir)
+	if (IS_ERR_OR_NULL(phydir))
 		return;
 
 	debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
-- 
2.39.0