Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Kalle Valo <kvalo@kernel.org>, Wang Ming <machel@vivo.com>,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Subject: [PATCH net v1] ath6kl:Fix error checking for debugfs_create_dir()
Date:   Thu, 13 Jul 2023 12:05:02 +0800
Message-Id: <20230713040518.13734-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dM+wTcMva/T2t880e0JVyZ/qCshRm4eTCmC6nY8qOIqnsR/SsQmh57OkkrKe?=
 =?us-ascii?Q?HvuX3XgDVs3PheK3dp35M2yWbLVwZHHgsxi2/wta6MyhFtlOZOjUWQf9gdnd?=
 =?us-ascii?Q?2DJe+qo3LPjE10nTf1ahkYX7Mx7W4mf5AmG89RzxX14hjIQD32WaqRvjEJoV?=
 =?us-ascii?Q?NmeRc4bdJCJIHzsucrKFRdzpNX4uEMuSf0EC4W8PXLpBddB2nDUtzBLuDamF?=
 =?us-ascii?Q?tx3pnke85igx4UWN01+FScSHxJdJjr8qxyGLJuyBf1LYMhPrNWAkRmfsuHC3?=
 =?us-ascii?Q?Ofn7JAtWmHXO3kWWCw6mFQq70WuDpGpSbDEjbiEVUFEugYY0z5VuIWyNXZrI?=
 =?us-ascii?Q?Tr0tFzll0fZSJEeWoNvii1lI37LHTU6MdbOva2zq77w0XTdg8gxOGoF56+Uz?=
 =?us-ascii?Q?H0YqZ2TnFm6ncJlLB4UXUogUb6Ol41/rkZ7vA2a3kR/ONY6TxA4gsWPPX1ak?=
 =?us-ascii?Q?j3PHaz9BfY53Fz1qbnWfN2cVRJlyoGubvAduMaojRRA6MOE0iFgCxJSH0CdA?=
 =?us-ascii?Q?QoHwQ5mWs0isDaDCjbR7fvSbYrKcimdgRUUsghgnruF1YbwweyyeCQEw1E+N?=
 =?us-ascii?Q?nxC5nlYQN8RfMF3EfDjAcVHbhAbVxnc/lagQqM5b9sJXTOcx3me/nFj8+/h+?=
 =?us-ascii?Q?0mEcfBIx+0DGPSeOONqefjDl+ibKOpw5PzQ8KHPgcEjEJutP25azFkewUpzB?=
 =?us-ascii?Q?h5tm7cS/cKx761DFfF4dXhks5X2Vz8/+BkLuN6cTF6T+Xu4Nhz0HIBjHYARJ?=
 =?us-ascii?Q?rDCP0QJiEdfAaCSGpERK0zOWcwoEMuRvhdf+qkcy4IoJ7Nr//iGhmdiP/stp?=
 =?us-ascii?Q?hj8LChlEY9iULHi5RmMHJCvEw4lEUpuoHKL0eQ7o0Pdnfh+9XTMDjc/T7rLf?=
 =?us-ascii?Q?O6sPG+quonl8ZbGSin27ouMGwbZrKLRf+Wz014ycrqp1OQLRXRFDFgOEk15/?=
 =?us-ascii?Q?bc9xV/Rw3FByCU1G7SxxORO41sPsYZRloAcXfJ4V1oeJJ7eaRnGEtGN7eKNW?=
 =?us-ascii?Q?kJm8VHpi9fSOOAlXSHavr2K/RHvASbYunXSFAOf90OxG4c4Ii7iyIvApJUSp?=
 =?us-ascii?Q?VyYhFC7ZveIt1U/GdSQ3W9S1tZNdWU4t6wA1+RQh9M/PLZe4cWZCv0L6npq6?=
 =?us-ascii?Q?K+fYVPbCujkManjm+tcZn5JaDJDXkTp71d5g+k+9uLzRLpuRr+LXdjw9qwVJ?=
 =?us-ascii?Q?2geXXce2u2IPQo3AYIHYXhGtWeQMuOkWfsyvDu75C9JORnxOAcNF7jDMynbc?=
 =?us-ascii?Q?a+jxRa6/n0z6aIya0LX4gSvoIC5K/kCjpAhHkHAEeRtekORJPxx7zn94wD3V?=
 =?us-ascii?Q?oN8cDqZ9DSqxHjrdR5wGD4VXpz416WCbdcUnQwd3MDsx5F6nnq0+Fyi89BlW?=
 =?us-ascii?Q?x3sQhZ6AWj9VRiJ01ZkBPhApoTmWwTS8yMFmooAJKkaSN9sWicd90iPQx4Q8?=
 =?us-ascii?Q?o1tn9SNNMsOo/7MiDnaWrV0++0q1oJ8eLXpzbJ2A3RwZZq2H2GCgmNGVRaZZ?=
 =?us-ascii?Q?fEuBeQjCxLGKL8SmVkojwM+S7fvolmZmaMvhqKFYYC0JZEDNx3BMlkB6iMfY?=
 =?us-ascii?Q?wW6phpVRa7wuHTAI8ESPrvnfzJyFzievcjvapcnx?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bab07618-c226-4665-60df-08db83566320
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 04:05:25.8259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KaS6I2uyf7lge5Liy4WWHgDMH4zLzPxsY6hhYBQfRa3PxUo+CAddFQFGCWFh+a9pJMCYIA/Sb5AsvGqZj7+jIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6421
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

The debugfs_create_dir() function returns error pointers,
it never returns NULL. Most incorrect error checks were fixed,
but the one in ath6kl_debug_init_fs() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>

Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs")
---
 drivers/net/wireless/ath/ath6kl/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
index 433a047f3747..505af195e299 100644
--- a/drivers/net/wireless/ath/ath6kl/debug.c
+++ b/drivers/net/wireless/ath/ath6kl/debug.c
@@ -1793,7 +1793,7 @@ int ath6kl_debug_init_fs(struct ath6kl *ar)
 {
 	ar->debugfs_phy = debugfs_create_dir("ath6kl",
 					     ar->wiphy->debugfsdir);
-	if (!ar->debugfs_phy)
+	if (IS_ERR(ar->debugfs_phy))
 		return -ENOMEM;
 
 	debugfs_create_file("tgt_stats", 0400, ar->debugfs_phy, ar,
-- 
2.25.1