Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Jiri Slaby <jirislaby@kernel.org>,
        Nick Kossifidis <mickflemm@gmail.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        linux-wireless@vger.kernel.org (open list:ATHEROS ATH5K WIRELESS DRIVER),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v4] wifi: ath5k: remove parameter check in ath5k_debug_init_device()
Date:   Thu, 13 Jul 2023 16:24:32 +0800
Message-Id: <20230713082433.11485-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pPRdNEZgdbwwYFcnSNvU5V6cPyK5xTOTs7A7DywznWtC+eQxnBWtda+0y5Or?=
 =?us-ascii?Q?GQVIUW1UgR0TB8r4pjEBzsvI+wV6cz8Boh2tV/veyBIU1htfvJ1xGmS9crdH?=
 =?us-ascii?Q?KvgL6TKSfc8oQEABa6X3YuwGGNGn3u05ak6P8Nlcd+L/eHLAsKUF9M2BFuvw?=
 =?us-ascii?Q?E91gCxj5KAz6ZJX7BgUi56RO14UelQ8pOia574s50yF9bRRSmiWX9AJVS2bm?=
 =?us-ascii?Q?kACa3gccLhBmXMUSE9+H+PXLPeTm7F+PgNBzVIVXe5UQdJCCiuNsDc98Z6iK?=
 =?us-ascii?Q?8b6bIbHH+QhbiDWf5mPSug+sVvlQt9fVvKL9WXR07rOg8BlD/SDdCVci7UOn?=
 =?us-ascii?Q?6ZepWMYJnuhJ80clxWIm4jNBwCbNYCP5/jXxj18wWeHBzwoxvlohoenu+ph8?=
 =?us-ascii?Q?dBMCvAAylLcM/amkbImrx1m6J6pQlDsrivnEUR5Xq8XukWQY9/OhF2+y/bfO?=
 =?us-ascii?Q?55rrttUUHbT0dLnax3sXwu4C/JsHHx9ZHcmcLT5zSalmwey3Q1SzzIQvC/BY?=
 =?us-ascii?Q?mvIYadLsWweCSwr7RwoIq9YoFVDIHjbVY4Fmj/X4w/10jv1VnE963jVefK4O?=
 =?us-ascii?Q?bZRkYiTYSM75Q5fEBh2Nr2iYCaM/m9bPSmmLxgbDDTYNihawLsIC8KfxQg3v?=
 =?us-ascii?Q?iStBcu0UbULbaHmAE1+hO6Vk9PCui8QEUlWlwYTW+dvFQhwTqqLb2f3BkJUb?=
 =?us-ascii?Q?bkfLLDK4TiyzEdCKzJW9gCwCosaesLXC49uVCVOqRZi6Xzgdnlpl1G0+Iny8?=
 =?us-ascii?Q?vi7Dj0wz8FweRne5MFURoAhIFmcgekI/aya2QG8pCJN2N1lUEl/RX/tTcGRA?=
 =?us-ascii?Q?J2GSjL/ZBQ+hKAxbo/0+P16lP/VYHCjQBctbp+XEsWqOe4m5zPVubJy94pbF?=
 =?us-ascii?Q?6dBij09d6/jFg/evfEkostOFRstjY0Vs5Ax0s3Xyy/Ktjzh8BxQtbpYgBkVb?=
 =?us-ascii?Q?bMTkYd5kGEvxmiyUj1Ud3R8e1xRJ+vqEYjawXPuQhy2NDPxQWBMj7VD4U9zk?=
 =?us-ascii?Q?9YhQTogx4UhKh6pnBNBgLXX7vufmk9b+U3r4OWP1AoXojCvoUB4BAkiqBtNx?=
 =?us-ascii?Q?A3UW9D77iNNAepOVUIo08ZT7Gb1gq9e9elogwgayniZZoZ2iaHG5lLqwnB6v?=
 =?us-ascii?Q?K2tyuCO3d6zjAwU/8Rd8ZwHscTI2+SvDnfjc+2mLGmyD9cdzzKPTJOml8tc5?=
 =?us-ascii?Q?uH5mTfgE04Nu5w7VKWXHmRPwSdBnI4JRbjYZbNaz/Q7fzBJLLdSt84ugqDe/?=
 =?us-ascii?Q?W6TsIATe9J0/oaS+nNbUQ6xm9VsnmmFl5vhf6RfdNTBKyEkp3iueG5DdmbOo?=
 =?us-ascii?Q?kay1Lfp7NUq7++4OREfYZeNIgnydkcuWQikuTRqzQ/HGEKodBIqeSM1FDHmN?=
 =?us-ascii?Q?q+60ZnMNnKqQg0+6tZL1z/P7D4fbrYMWww2jbgMoij46b7EOMpRspo+2G6mT?=
 =?us-ascii?Q?LhGGBbaHNkMXWx6Lr0D5z7cQ4/GUxdN/E7g62dN3ADeNtwBqD6MYETXD6BdR?=
 =?us-ascii?Q?AZFmaa8CDAyUNgrDcd+DwgQUWRXYENEoKa62QvwXVWwTZC8MJn4qseHI0nNi?=
 =?us-ascii?Q?gYaN1Am9uvpbx2HvVnt0hZcswGmlNp/tIYyZ0+lr?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b570493d-45bc-4582-3857-08db837a9c18
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:24:43.3193
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SmdyKGE41bGHeqqXHVy95UoEf7Sjn1D8C9qmWdCUnK/W7MKDIYO6YViX1n0rcO0Jcx7ZIEN8edeUxOBOJj6oBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6686
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

The parameter 'phydir' error check is mistake.
debugfs_create_file() will return early if 'phydir' is an error pointer,
so the error check is removed.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
v1: use IS_ERR() to error check.
v2: use IS_ERR_OR_NULL() to error check.
v3: remove the error check.
v4: fix the patch format.
---
 drivers/net/wireless/ath/ath5k/debug.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
index 4b41160e5..ec130510a 100644
--- a/drivers/net/wireless/ath/ath5k/debug.c
+++ b/drivers/net/wireless/ath/ath5k/debug.c
@@ -982,8 +982,6 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
 	ah->debug.level = ath5k_debug;
 
 	phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
-	if (!phydir)
-		return;
 
 	debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
 	debugfs_create_file("registers", 0400, phydir, ah, &registers_fops);
-- 
2.39.0