Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a9dc336793322d3525280e4f30b2acbd0c88bbf8.camel@redhat.com>
Subject: Re: [PATCH net v1] ath6kl:Fix error checking for
 debugfs_create_dir()
From:   Paolo Abeni <pabeni@redhat.com>
To:     Wang Ming <machel@vivo.com>, Kalle Valo <kvalo@kernel.org>,
        linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Date:   Thu, 13 Jul 2023 11:29:30 +0200
In-Reply-To: <20230713040518.13734-1-machel@vivo.com>
References: <20230713040518.13734-1-machel@vivo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-07-13 at 12:05 +0800, Wang Ming wrote:
> The debugfs_create_dir() function returns error pointers,
> it never returns NULL. Most incorrect error checks were fixed,
> but the one in ath6kl_debug_init_fs() was forgotten.
>=20
> Fix the remaining error check.
>=20
> Signed-off-by: Wang Ming <machel@vivo.com>
>=20
> Fixes: 9b9a4f2acac2 ("ath6kl: store firmware logs in skbuffs")

The SoB tag should be after the 'Fixes' one and you must avoid empty
lines in between.

(The same applies to your other patch)

Cheers,

Paolo